[hostcfgd] record feature state in STATE DB#61
Closed
stepanblyschak wants to merge 109 commits intomasterfrom
Closed
[hostcfgd] record feature state in STATE DB#61stepanblyschak wants to merge 109 commits intomasterfrom
stepanblyschak wants to merge 109 commits intomasterfrom
Conversation
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Co-authored-by: Zhi Yuan (Carl) Zhao <zyzhao@arista.com> Why I did it Arista 7060 platform has a rare and unreproduceable PCIe timeout that could possibly be solved with increasing the switch PCIe timeout value. To do this we'll call a script for this platform to increase the PCIe timeout on boot-up. No issues would be expected from the setpci command. From the PCIe spec: "Software is permitted to change the value in this field at any time. For Requests already pending when the Completion Timeout Value is changed, hardware is permitted to use either the new or the old value for the outstanding Requests, and is permitted to base the start time for each Request either on when this value was changed or on when each request was issued. " How I did it Add "platform-init" support in swss docker similar to how "hwsku-init" is called, only this would be for any device belonging to a platform. Then the script would reside in device data folder. Additionally, add pciutils dependency to docker-orchagent so it can run the setpci commands. How to verify it On bootup of an Arista 7060, can execute: lspci -vv -s 01:00.0 | grep -i "devctl2" In order to check that the timeout has changed.
Why I did it Adding platform support for centec v682-48y8c and v682-48x8c. V682-48y8c switch has 48 SFP+ (1G/10G/25G) ports, 8 QSFP28 (40G/100G) ports on CENTEC TsingMa.MX. V682-48y8c is different from V682-48y8c_d in that: transceiver is managed by cpu smbus rather than TsingMa.MX i2c bus. port led is managed by mcu inside TsingMa.MX. fan, psu, sensors, leds are managed by cpu smbus other than the cpu board vendor's close sourse driver. V682-48x8c switch has 48 SFP+ (1G/10G) ports, 8 QSFP28 (40G/100G) ports on CENTEC TsingMa.MX. CPU used in v682-48y8c and v682-48x8c is Intel(R) Xeon(R) CPU D-1527. How I did it Modify related code in platform and device directory. Upgrade centec sai to v1.9. upgrade python to python3 and kernel version to 5.0 for V682-48y8c_d. How to verify it Build centec amd64 sonic image, verify platform functions (port, sfp, led etc) on centec v682-48y8c and v682-48x8c board. Co-authored-by: shil <shil@centecnetworks.com>
#### Why I did it Including below commits: ``` fe00bbf 2021-12-17 | Revert "[sonic-package-manager] support sonic-cli-gen and packages with YANG model (sonic-net#1650)" (sonic-net#1972) [Prince George] 5fe6d92 2021-12-16 | [warm/fast-reboot] Fix kexec portion to support platforms based on Device Tree (sonic-net#1966) [dflynn-Nokia] 74d2a09 2021-12-17 | [portstat] check TX/RX utilization calculation correctness (sonic-net#1840) [Andriy Yurkiv] e44c3f6 2021-12-16 | [generic-config-updater] Improving CreateOnly validator and marking /LOOPBACK_INTERFACE/LOOPBACK#/vrf_name as create-only (sonic-net#1969) [Mohamed Ghoneim] 0067cc4 2021-12-15 | [build] adapt for upstream target path change (sonic-net#1971) [Qi Luo] 96143ee 2021-12-09 | preserve old order for config reload (sonic-net#1964) [arlakshm] f08c81d 2021-12-10 | [vxlan] remove unnecessary whitespace for show commands (sonic-net#1792) [Gord Chen] 14889ce 2021-12-09 | [soft-reboot] Add support for platforms based on Device Tree (sonic-net#1963) [dflynn-Nokia] 7ceccd7 2021-12-08 | [generic-config-updater] Adding non-strict mode (sonic-net#1929) [Mohamed Ghoneim] 2e462ef 2021-12-07 | [sfputil] Firmware download/upgrade CLI support for QSFP-DD (sonic-net#1947) [Prince George] 7c34b79 2021-12-07 | [config] Add portchannel support for static route (sonic-net#1857) [Dmytro] 54cc370 2021-12-06 | [doc] Refine doc on show loopback/mgmt ports (sonic-net#1958) [Qi Luo] 3714f63 2021-12-06 | [port2alias]: Fix to get right number of return values (sonic-net#1906) [SuvarnaMeenakshi] 3fa0854 2021-12-06 | [CLI][show bgp] On chassis don't show internal BGP sessions by default (sonic-net#1927) [Mahesh Maddikayala] 6de91af 2021-12-06 | [Auto-Techsupport] Issues related to Multiple Cores crashing handled (sonic-net#1948) [Vivek Reddy] 656ade1 2021-12-06 | SFP-Refactor: Vendor revision is not displayed properly (sonic-net#1950) [Aravind Mani] 67466cb 2021-12-05 | [port] Fix port speed set (sonic-net#1952) [Mykola Gerasymenko] 5172972 2021-12-04 | Fix invalid output of syslog IPv6 servers (sonic-net#1933) [jingwenxie] 290ff5f 2021-12-03 | Routed subinterface enhancements (sonic-net#1821) [Preetham] 1ea88e2 2021-12-01 | Enhance sfputil for CMIS QSFP (sonic-net#1949) [andywongarista] 4e132c1 2021-11-30 | [debug dump] Refactoring Modules and Unit Tests (sonic-net#1943) [Vivek Reddy] b550c44 2021-11-30 | Add command reference for trap flow counters (sonic-net#1876) [Junchao-Mellanox] 67a267b 2021-11-30 | [Reclaim buffer] [Mellanox] Db migrator support reclaiming reserved buffer for unused ports (sonic-net#1822) [Stephen Sun] 30e4654 2021-11-25 | Add show command for BFD sessions (sonic-net#1942) [Shi Su] e63f47e 2021-11-25 | [warm-reboot] Fix failures of warm reboot on disconnect of ssh session (sonic-net#1529) [maksymbelei95] c05845d 2021-11-25 | Add trap flow counter support (sonic-net#1868) [Junchao-Mellanox] ef82f00 2021-11-24 | [load_minigraph] Delay pfcwd start until the buffer templates are rendered (sonic-net#1937) [Neetha John] f5e5a56 2021-11-24 | [sonic-package-manager] support sonic-cli-gen and packages with YANG model (sonic-net#1650) [Stepan Blyshchak] 64777a4 2021-11-23 | generic_config_updater: Filename changed & VLAN validator added (sonic-net#1919) [Renuka Manavalan] 1f8f6ab 2021-11-23 | [config reload] Update command reference (sonic-net#1941) [Sudharsan Dhamal Gopalarathnam] ```
…ed breakout modes. (sonic-net#9278) Closes sonic-net#7958 #### Why I did it The previous implementation of sonic-cfggen did a simple comparison between default breakout mode in hwsku.json and supported modes in platform.json. To set a different default speed in hwsku.json it was required to add one more entry to supported modes in platfrom.json file: 1x10G[100G,50G] vs 1x100G[50G,10G] The new implementation does more intelligent parsing and analysis of supported and default modes. It allows changing default speed without adding a new entry to platform.json. #### How I did it Add more intelligent parsing and analysis of supported and default modes. #### How to verify it Run sonic-config-engine unit tests from sonic-config-engine/tests directory
#### Why I did it POLL_INTERVAL cannot be set if any of the detection/restoration times in this table is less than the POLL_INTERVAL. #### How I did it Add "must" constraint to make sure detection/restoration times are greater than POLL_INTERVAL. #### How to verify it Use apply-patch command to update POLL_INTERVAL. Build sonic-yang-model.
…onic-net#9537) Why I did it Fix typo and missing files in SN3800 and SN4600C's buffer templates How I did it ingress_lossless_xoff_size => ingress_lossless_pool_xoff add missing files for SN4600C-D100C12S2 How to verify it Deploy the fix and verify whether the device can be up. Signed-off-by: Stephen Sun <stephens@nvidia.com>
…#9593) Why I did it Config db schema generated from test minigraph can't pass yang validation. How I did it Update minigraph xml to add DeploymentId. How to verify it Build sonic-config-engine. Run command 'sonic-cfggen -m xxx.xml --print-data', and check deployment_id field. Signed-off-by: Gang Lv ganglv@microsoft.com
Why I did it Config db schema generated from test minigraph can't pass yang validation. How I did it Update test minigraph to fix interface How to verify it Build sonic-config-engine. Run command 'sonic-cfggen -m xxx.xml --print-data', and check interface table and port table. Signed-off-by: Gang Lv ganglv@microsoft.com
Why I did it
'SYSLOG_SERVER': {'': {}, '10.0.10.5': {}, '10.0.10.6': {}},
Config db schema generated by minigraph can’t pass yang validation, server address can't be empty.
How I did it
Update test minigraph to remove wrong configuration.
How to verify it
Build sonic-config-engine.
Run command 'sonic-cfggen -m xxx.xml --print-data', and SYSLOG_SERVERS table.
Signed-off-by: Gang Lv ganglv@microsoft.com
) [Build]: Support reproducible build for release branches sonic-net#9426
- Why I did it The feature state can be a jinja template, like in this file - https://github.com/Azure/sonic-buildimage/blob/master/files/build_templates/init_cfg.json.j2#L39. Without this change it is not possible to validate a configuration file. - How I did it Relaxes the constraint on feature state. Feature state leaf can be any string. - How to verify it Run UT. Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
691c37b [Route bulk] Fix bugs in case a SET operation follows a DEL operation in the same bulk (sonic-net/sonic-swss#2086) a4c80c3 patch for issue sonic-net/sonic-swss#1971 - enable Rx Drop handling for cisco-8000 (sonic-net/sonic-swss#2041) 71751d1 [macsec] Support setting IPG by gearbox_config.json (sonic-net/sonic-swss#2051) 5d5c169 [bulk mode] Fix bulk conflict when in case there are both remove and set operations (sonic-net/sonic-swss#2071) 8bbdbd2 Fix SRV6 NHOP CRM object type (sonic-net/sonic-swss#2072) ef5b35f [vstest] VS test failure fix after fabric port orch PR merge (sonic-net/sonic-swss#1811) 89ea538 Supply the missing ingress/egress port profile list in document (sonic-net/sonic-swss#2064) 8123437 [pfc_detect] fix RedisReply errors (sonic-net/sonic-swss#2040) b38f527 [swss][CRM][MPLS] MPLS CRM Nexthop - switch back to using SAI OBJECT rather than SWITCH OBJECT ae061e5 create debug_shell_enable config to enable debug shell (sonic-net/sonic-swss#2060) 45e446d [cbf] Fix max FC value (sonic-net/sonic-swss#2049) b1b5b29 Initial p4orch pytest code. (sonic-net/sonic-swss#2054) d352d5a Update default route status to state DB (sonic-net/sonic-swss#2009) 24a64d6 Orchagent: Integrate P4Orch (sonic-net/sonic-swss#2029) 15a3b6c Delete the IPv6 link-local Neighbor when ipv6 link-local mode is disabled (sonic-net/sonic-swss#1897) ed783e1 [orchagent] Add trap flow counter support (sonic-net/sonic-swss#1951) e9b05a3 [vnetorch] ECMP for vnet tunnel routes with endpoint health monitor (sonic-net/sonic-swss#1955) bcb7d61 P4Orch: inital add of source (sonic-net/sonic-swss#1997) f6f6f86 [mclaglink] fix acl out ports (sonic-net/sonic-swss#2026) fd887bf [Reclaim buffer] Reclaim unused buffer for dynamic buffer model (sonic-net/sonic-swss#1910) 9258978 [orchagent, cfgmgr] Add response publisher and state recording (sonic-net/sonic-swss#1992) 3d862a7 Fixing subport vs test script for subport under VNET (sonic-net/sonic-swss#2048) fb0a5fd Don't handle buffer pool watermark during warm reboot reconciling (sonic-net/sonic-swss#1987) 16d4bcd Routed subinterface enhancements (sonic-net/sonic-swss#1907) 9639db7 [vstest/subintf] Add vs test to validate sub interface ingress to a vnet (sonic-net/sonic-swss#1642) Signed-off-by: Stephen Sun stephens@nvidia.com
- Why I did it Rename MSN4800 to SN4800 in platform files - How I did it Rename MSN4800 to SN4800 in platform files - How to verify it Run build.
…onic-net#9621) - Why I did it Added missing functionality for dynamic buffer calculation in Spectrum-4. - How I did it Added a section of code in asic_table.j2 for Spectrum-4, and added the simx version of SN5600 to the supported list. - How to verify it Manually: buffershow -l should show all ingress/egress lossy/lossless pools, and all fields of profiles should show values. Automatically: https://github.com/Azure/sonic-mgmt/blob/master/tests/qos/test_buffer.py Signed-off-by: Raphael Tryster <raphaelt@nvidia.com>
…ilation (sonic-net#9582) - Why I did it There were compilation errors and warnings like, /usr/src/linux-headers-5.10.0-8-2-common/scripts/Makefile.build:69: You cannot use subdir-y/m to visit a module Makefile. Use obj-y/m instead. fatal error: linux/platform_data/pca954x.h: No such file or directory hwmon_device_register() is deprecated. Please convert the driver to use hwmon_device_register_with_info(). If PDDF kernel module compilation fails, the PDDF debian package was not detecting the break. - How I did it Modified the code with new kernel 5.10 APIs. Modified the Makefiles to use 'obj-m' instead of 'subdir-y' - How to verify it PDDF is supported on Accton platform. Load the build on AS7326 setup and check the 'dmesg'
sonic-net#9585) - Why I did it PDDF utils were python2 compliant and they needed to be migrated to Python3 (as per Bullseye) PDDF common platform APIs file name changed as the name was already in use Indentation issues Dead/redundant code needed to be removed - How I did it Made files Python3 compliant Indentation corrected Redundant code removed - How to verify it AS7326 Accton platform uses PDDF. PDDF utils were run on this platform to verify.
Why I did it Some platforms need to run few steps before the PDDF service is actually started. * Adding pre_pddf_init script in the service file * Raising exception for get_target_speed() for PSU-fan in PDDF (sonic-net#8129)
Why I did it To include newer Fan LED, thermal capabilities fields in platform.json of DellEMC S6000, S6100, Z9332f platforms. How I did it Add the capabilities fields in each platform's respective platform.json. How to verify it Ran sonic-mgmt platform api test cases that use capabilities fields and verified that the results are as expected.
Why I did it To incorporate the below changes in DellEMC S6100, S6000 platforms. S6100, S6000: Implement 'get_revision' method for Chassis Implement 'get_maximum_consumed_power' method for FanDrawer Implement 'get_revision', 'get_maximum_supplied_power' methods for PSU Implement 'get_error_description' method for SFP. S6100: Implement 'get_module_index' method for Chassis Implement 'get_description', 'get_maximum_consumed_power', 'get_oper_status', 'get_slot' methods for Module Update component names in platform.json How I did it Implement the platform API methods in the respective device files How to verify it Verified that the respective sonic-mgmt platform API test cases report success.
…#9641) Following errors are seen continuously on SMBus controller when loading bullseye kernel. [ 273.643046] DMAR: [DMA Write] Request device [00:12.0] PASID ffffffff fault addr 0 [fault reason 05] PTE Write access is not set [ 273.785784] DMAR: DRHD: handling fault status reg 2 [ 273.844072] DMAR: [DMA Write] Request device [00:12.0] PASID ffffffff fault addr 0 [fault reason 05] PTE Write access is not set [ 273.986804] DMAR: DRHD: handling fault status reg 2 [ 274.045101] DMAR: [DMA Write] Request device [00:12.0] PASID ffffffff fault addr 0 [fault reason 05] PTE Write access is not set [ 274.187789] DMAR: DRHD: handling fault status reg 2 root@sonic:~# lspci -s 00:12.0 -vv 00:12.0 System peripheral: Intel Corporation Atom Processor C3000 Series SMBus Contoller - Host (rev 11) Issue was not seen in buster. Modified platform specific installer.conf to turn off io_mmu
The character "?" is not supported in azp template trigger branches, only support *.
…onic-net#9669) Fix the gmock not found issue in debian stretch slave container. Some of platforms, such as naphos, innovium, have such issue.
…et#9659) #### Why I did it Fixes sonic-net/sonic-utilities#1871 From [generic-config-updater](https://github.com/Azure/sonic-utilities/tree/master/generic_config_updater) we call `sonic-yang-mgmt` multiple times in order to check a certain change to ConfigDb is valid or not. It is expected for some changes to be invalid, so always printing errors from `sonic-yang-mgmt` makes the output hard to read. In this PR, we are adding a way to control if logs should be printed or not. #### How I did it - Added `print_log_enabled` flag to sonic_yang ctor - Converted all `print` statements to `sysLog(..., doPrint=True)` #### How to verify it unit-test passing means the change did not break logs. #### Info about libyang logging libyang provides an extensive logging logic which can support a lot of scenarios: - ly_log_level: setting logging level - LY_LLERR - LY_LLWRN - ... - ly_set_log_clb: setting log callback to customize the default behavior which is printing the msgs - ly_log_options: setting logging options - LY_LOLOG: If callback is set use it, otherwise just print. If flag is not set, do nothing. - ... For more info refer to: - https://netopeer.liberouter.org/doc/libyang/devel/html/group__logopts.html#gaff80501597ed76344a679be2b90a1d0a - https://netopeer.liberouter.org/doc/libyang/devel/html/group__log.html#gac88b78694dfe9efe0450a69603f7eceb #### What's next? Consume the new flag `print_log_enabled` in [generic-config-updater](https://github.com/Azure/sonic-utilities/tree/master/generic_config_updater) to reduce the logging clutter. #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106 #### Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: --> #### A picture of a cute animal (not mandatory but encouraged)
Reproducible build script breaks docker-sonic-mgmt build.
Why I did it Reboot cause is not working in S52xx platforms. How I did it Modified platform API's. How to verify it Check "show reboot-cause" to verify the reboot reason
Why I did it Config db schema generated by minigraph can’t pass yang validation, there's no Vlan31 in 'VLAN' table. How I did it Update test minigraph to add vlan interface. How to verify it Build sonic-yang-models. Run command 'sonic-cfggen -m tests/fg-ecmp-sample-minigraph.xml -p tests/mellanox-sample-port-config.ini --print-data', and run yang validation. Signed-off-by: Gang Lv ganglv@microsoft.com
c4127c2 [psud] Fix PSU log issue (sonic-net#235) 07542cb [pmon][xcvrd]xcvrd process show backtrace on the internal port. (sonic-net#233) 3e432e7 [Y-Cable] Increased unit test coverage of y_cable_helper.py (sonic-net#229) 7c363f5 [ledd] prevent led crash on recirc port event (sonic-net#232) e9ccd82 [sonic-platform-daemons] fix dependency issue on py2 wheels by correcting the path (sonic-net#234) 2b0acfb [sfp-refactoring] xcvrd: add initial support for CMIS application initialization (sonic-net#217)
Why I did it Need to be able to run smartctl when pmon docker is not running. How I did it Removed the pmon dependency for pmon as well as the command wrapper and added it to the debian-extension. How to verify it Stop pmon Run smartctl from the host and verify it runs without error
Why I did it end2end test is blocked by Yang model for BGP monitor. How I did it Create new yang files for BGP monitor, and add UT. How to verify it Follow the steps in sonic-net#9711. Run UT for sonic-yang-models. Signed-off-by: Gang Lv ganglv@microsoft.com
…-net#9796) Why I did it ConfigDB schema generated by minigraph parser can't pass yang validation. How I did it Modify minigraph.py, and use 'state' to replace 'status'. How to verify it Run UT for sonic-config-engine. Use minigraph parser to generate ConfigDB schema, and run yang validation. Signed-off-by: Gang Lv ganglv@microsoft.com
…ic-net#9791) Support bullseye for docker-sonic-restapi docker-sonic-telemetry Upgrade to bullseye and Golang-1.15 to support FIPS.
[sonic-linkmgrd][master] submodule update Commits added: 0c23756 Jing Zhang 2022-01-19 Linkmgrd subscribing State DB route event (#13) 12b9951 Longxiang Lyu 2021-12-13 Add TLV support to ICMP payload (#11) 3eedda3 Longxiang Lyu 2022-01-06 Add missing intermediate states (#16) 8da4982 Ying Xie 2022-01-04 [linkmgrd] update README, set coding style guidance (#15) a897cf8 Longxiang Lyu 2021-12-13 Improve PR template (#16) 6fec701 Jing Zhang 2021-12-06 Add pull request template for linkmgrd repo (#9) signed-off-by: Jing Zhang zhangjing@microsoft.com
- External PHY is managed via gearbox (gbsybcd docker container) in SONiC
- Enhanced 'External PHY management' from SONiC's single-ASIC environment to multi-ASIC
- Enhanced gbsyncd docker container from single Namespace to multi-Namspace mode
- Added gbsyncd.service.j2 on per_namespace basis.
- Each namepace/ASIC now to have its unique gbsyncd<ASIC#> docker container with its
own Gearbox table, redis-DB
Signed-off-by: Shyam Kumar <shyakuma@cisco.com>
…dump (sonic-net#9521) Why I did it Eliminate benign firsttime boot error reported when running on platforms that do not support kdump. How I did it Change rc.local to check for presence of the file /etc/default/kdump-tools before referencing it. How to verify it Install a new image on an armhf or arm64 platform and check for a failed reference to /etc/default/kdump-tools on firsttime boot.
Why I did it ACL have ACCEPT action indeed, but yang doesn't support it. How I did it Add 'ACCEPT' enum to sonic-types.yang.j2 How to verify it Run the YANG model unit tests
…t#9786 Why I did it sonic-broadcom-dnx.bin should be able to installed on DNX supported platform, whereas it doesn't. How I did it Changed CONFIGUTED_PLATFORM to TARGET_MACHINE to distinguish broadcom and broadcom-dnx How to verify it tar sonic-broadcom-dnx.bin and verify its platforms_asic contians dnx platforms Also verify on image with other asic, no regression.
Why I did it Update Broadcom SAI to version 6.0.0.13, SDK 6.5.24, saibcm-modules to 6.5.24.gpl How I did it Brcm SAI 6.0 EA with fixes for CS00012203367, CS00012219613, CS00012213974, CS00012218290, CS00012217169, CS00012211718, CS00012213944, CS00012215529, CS00012218100, CS00012214196, CS00012212681, CS00012205138, CS00012208537, CS00012185316, CS00012208524, CS00012203367, CS00012197364.
…cause it will be change to 755 by debian build and cause dirty image version. (sonic-net#9821) #### Why I did it src\tacacs\bash_tacplus\debian\rules file mode is 644, and debian build will change it to 755, which will cause image version contains 'dirty' #### How I did it Change src\tacacs\bash_tacplus\debian\rules file mode to 755 #### How to verify it Check the image version not contains dirty #### Which release branch to backport (provide reason below if selected) - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106 - [*] 202111 #### Description for the changelog Change src\tacacs\bash_tacplus\debian\rules file mode to 755 #### A picture of a cute animal (not mandatory but encouraged)
Update the sonic-swss submodule. The following are new commits in the submodule: 6cb43ee [p4orch] Fix handlePortStatusChangeNotification status deserialize (sonic-net#2111) 863f0f1 [azp]: Enable PR diff coverage (sonic-net#2083) bf4cd4a Fix the unsafe usage of strncpy in portsorch.cpp (sonic-net#2110) c1b4b40 support port isolation group in BFN platform (sonic-net#1940) Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com>
This is to fix the issue of phy-credo package in bullseye.
* use py3 for dh build * use pybuild for python packages
…9744) Why I did it Old fan drv will be build fail under kernel 5.10. It get below error message. /sonic/platform/broadcom/sonic-platform-modules-accton/as7312-54xs/modules/accton_as7312_54x_fan.c:483:5: error: implicit declarat ion of function 'set_fs'; did you mean 'sget_fc'? [-Werror=implicit-function-declaration] set_fs(KERNEL_DS); ^~~~~~ sget_fc How I did it These code is old design and they are not needed currently. So remove them. Signed-off-by: Jostar Yang <jostar_yang@accton.com>
…ingle boot (sonic-net#9608) Why I did it Requirements from Microsoft for fwutil update all state that all firmwares which support this upgrade flow must support upgrade within a single boot cycle. This conflicted with a number of Mellanox upgrade flows which have been revised to safely meet this requirement. How I did it Added --no-power-cycle flags to SSD and ONIE firmware scripts Modified Platform API to call firmware upgrade flows with this new flag during fwutil update all Added a script to our reboot plugin to handle installing firmwares in the correct order with prior to reboot How to verify it Populate platform_components.json with firmware for CPLD / BIOS / ONIE / SSD Execute fwutil update all fw --boot cold CPLD will burn / ONIE and BIOS images will stage / SSD will schedule for reboot Reboot the switch SSD will install / CPLD will refresh / switch will power cycle into ONIE ONIE installer will upgrade ONIE and BIOS / switch will reboot back into SONiC In SONiC run fwutil show status to check that all firmware upgrades were successful
dgsudharsan
approved these changes
Jan 25, 2022
stepanblyschak
pushed a commit
that referenced
this pull request
May 17, 2022
[master][sonic-linkmgrd] submodule updates df51322 Longxiang Lyu Fri May 6 10:01:46 2022 +0800 Add `ActiveActiveStateMachine` implementation (#64) e721ceb Jing Zhang Wed May 4 10:07:14 2022 -0700 Add doc for default route related changes (#63) 7bb06fb Jing Zhang Tue May 3 09:48:28 2022 -0700 Add Cli support to enable or disable default route related feature (#68) e4b02cb Jing Zhang Mon May 2 13:27:54 2022 -0700 Reset WaitActiveUp count before switching to active (#70) 212d960 Jing Zhang Wed Apr 27 10:35:05 2022 -0700 lower log level to warning (#69) 48abc9e Jing Zhang Thu Apr 14 16:50:04 2022 -0700 Add support to enable switchover time measurement (with link prober interval decreased to 10ms) feature (#61) c4858a6 Jing Zhang Thu Apr 14 11:27:55 2022 -0700 Avoid proactively switching to `active` if default route is missing (#62) sign-off: Jing Zhang zhangjing@microsoft.com
stepanblyschak
pushed a commit
that referenced
this pull request
Nov 20, 2024
…ly (sonic-net#20678) #### Why I did it src/sonic-ztp ``` * 2ec9859 - (HEAD -> 202405, origin/202405) Merge pull request #61 from mssonicbld/cherry/202405/57 (9 hours ago) [bingwang-ms] * 208d93d - Add role field to the ztp PORT config (#57) (9 days ago) [Vivek] ``` #### How I did it #### How to verify it #### Description for the changelog
stepanblyschak
pushed a commit
that referenced
this pull request
Dec 17, 2024
…utomatically (sonic-net#20998) #### Why I did it src/sonic-host-services ``` * 438e54a - (HEAD -> master, origin/master, origin/HEAD) [Logrotate] Update log rotate configuration via ConfigDB (#61) (9 hours ago) [Yevhen Fastiuk] ``` #### How I did it #### How to verify it #### Description for the changelog
stepanblyschak
pushed a commit
that referenced
this pull request
May 20, 2025
…lly (sonic-net#896) #### Why I did it src/sonic-swss ``` * 16cc0f6 - (HEAD -> 202412, origin/202412) [code sync] Merge code from sonic-net/sonic-swss:202411 to 202412 (#61) (20 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
stepanblyschak
pushed a commit
that referenced
this pull request
Jun 10, 2025
…ly (sonic-net#22572) #### Why I did it src/sonic-stp ``` * cc80f49 - (HEAD -> master, origin/master, origin/HEAD) MSTP configuration handling APIs (#61) (18 hours ago) [Divya Kumaran Chandralekha] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stepan Blyschak stepanb@nvidia.com
Why I did it
To implement blocking feature state change.
How I did it
Record the actual feature state in STATE DB from hostcfg.
How to verify it
Run with PR stepanblyschak/sonic-utilities#38.
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)