[yang] support acl ACCEPT action#9784
Merged
wen587 merged 2 commits intosonic-net:masterfrom Jan 21, 2022
Merged
Conversation
5 tasks
arlakshm
previously approved these changes
Jan 19, 2022
praveen-li
reviewed
Jan 19, 2022
| } | ||
| } | ||
| }, | ||
| "ACL_TABLE_CTRLPLANE_ACCEPT_ACTION": { |
Member
There was a problem hiding this comment.
The test name can be "ACL_PACKET_ACTION_VALIDATE_VALUE_ACCEPT", i.e. test name must be closer to describing what are we testing, instead of the config. Thx.
bingwang-ms
previously approved these changes
Jan 19, 2022
qiluo-msft
approved these changes
Jan 19, 2022
Collaborator
qiluo-msft
left a comment
qiluo-msft
left a comment
There was a problem hiding this comment.
LGTM. Please check with other reviewers.
dgsudharsan
added
the
Request for 202111 Branch
judyjoseph
pushed a commit
that referenced
this pull request
Mar 28, 2022
Why I did it ACL have ACCEPT action indeed, but yang doesn't support it. How I did it Add 'ACCEPT' enum to sonic-types.yang.j2 How to verify it Run the YANG model unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9638
Why I did it
ACL have ACCEPT action indeed, but yang doesn't support it.
How I did it
Add 'ACCEPT' enum to sonic-types.yang.j2
How to verify it
Run the YANG model unit tests
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)