[sonic-cfggen]: Fix missing vlan interface#9639
Merged
lguohan merged 1 commit intosonic-net:masterfrom Jan 5, 2022
Merged
Conversation
Signed-off-by: Gang Lv ganglv@microsoft.com
Contributor
Author
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@kktheballer Could you help review? |
lguohan
approved these changes
Jan 5, 2022
ganglyu
added
the
Request for 202111 Branch
judyjoseph
pushed a commit
that referenced
this pull request
Jan 9, 2022
Why I did it Config db schema generated by minigraph can’t pass yang validation, there's no Vlan31 in 'VLAN' table. How I did it Update test minigraph to add vlan interface. How to verify it Build sonic-yang-models. Run command 'sonic-cfggen -m tests/fg-ecmp-sample-minigraph.xml -p tests/mellanox-sample-port-config.ini --print-data', and run yang validation. Signed-off-by: Gang Lv ganglv@microsoft.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gang Lv ganglv@microsoft.com
Why I did it
Config db schema generated by minigraph can’t pass yang validation, there's no Vlan31 in 'VLAN' table.
How I did it
Update test minigraph to add vlan interface.
How to verify it
Build sonic-yang-models.
Run command 'sonic-cfggen -m tests/fg-ecmp-sample-minigraph.xml -p tests/mellanox-sample-port-config.ini --print-data', and run yang validation.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Fix #9581
A picture of a cute animal (not mandatory but encouraged)