[sonic-swss] Submodule update by stephenxs · Pull Request #9397 · sonic-net/sonic-buildimage

stephenxs · 2021-11-29T23:17:01Z

691c37b [Route bulk] Fix bugs in case a SET operation follows a DEL operation in the same bulk (sonic-net/sonic-swss#2086)
a4c80c3 patch for issue sonic-net/sonic-swss#1971 - enable Rx Drop handling for cisco-8000 (sonic-net/sonic-swss#2041)
71751d1 [macsec] Support setting IPG by gearbox_config.json (sonic-net/sonic-swss#2051)
5d5c169 [bulk mode] Fix bulk conflict when in case there are both remove and set operations (sonic-net/sonic-swss#2071)
8bbdbd2 Fix SRV6 NHOP CRM object type (sonic-net/sonic-swss#2072)
ef5b35f [vstest] VS test failure fix after fabric port orch PR merge (sonic-net/sonic-swss#1811)
89ea538 Supply the missing ingress/egress port profile list in document (sonic-net/sonic-swss#2064)
8123437 [pfc_detect] fix RedisReply errors (sonic-net/sonic-swss#2040)
b38f527 [swss][CRM][MPLS] MPLS CRM Nexthop - switch back to using SAI OBJECT rather than SWITCH OBJECT
ae061e5 create debug_shell_enable config to enable debug shell (sonic-net/sonic-swss#2060)
45e446d [cbf] Fix max FC value (sonic-net/sonic-swss#2049)
b1b5b29 Initial p4orch pytest code. (sonic-net/sonic-swss#2054)
d352d5a Update default route status to state DB (sonic-net/sonic-swss#2009)
24a64d6 Orchagent: Integrate P4Orch (sonic-net/sonic-swss#2029)
15a3b6c Delete the IPv6 link-local Neighbor when ipv6 link-local mode is disabled (sonic-net/sonic-swss#1897)
ed783e1 [orchagent] Add trap flow counter support (sonic-net/sonic-swss#1951)
e9b05a3 [vnetorch] ECMP for vnet tunnel routes with endpoint health monitor (sonic-net/sonic-swss#1955)
bcb7d61 P4Orch: inital add of source (sonic-net/sonic-swss#1997)
f6f6f86 [mclaglink] fix acl out ports (sonic-net/sonic-swss#2026)
fd887bf [Reclaim buffer] Reclaim unused buffer for dynamic buffer model (sonic-net/sonic-swss#1910)
9258978 [orchagent, cfgmgr] Add response publisher and state recording (sonic-net/sonic-swss#1992)
3d862a7 Fixing subport vs test script for subport under VNET (sonic-net/sonic-swss#2048)
fb0a5fd Don't handle buffer pool watermark during warm reboot reconciling (sonic-net/sonic-swss#1987)
16d4bcd Routed subinterface enhancements (sonic-net/sonic-swss#1907)
9639db7 [vstest/subintf] Add vs test to validate sub interface ingress to a vnet (sonic-net/sonic-swss#1642)

Signed-off-by: Stephen Sun stephens@nvidia.com

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

stephenxs · 2021-11-30T05:51:01Z

/azpw run

mssonicbld · 2021-11-30T05:51:04Z

/AzurePipelines run

azure-pipelines · 2021-11-30T05:51:09Z

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

stephenxs · 2021-11-30T05:53:03Z

/azpw run Azure.sonic-buildimage

mssonicbld · 2021-11-30T05:53:04Z

/AzurePipelines run Azure.sonic-buildimage

azure-pipelines · 2021-11-30T05:53:16Z

Azure Pipelines successfully started running 1 pipeline(s).

f6f6f86 [mclaglink] fix acl out ports (sonic-net#2026) fd887bf [Reclaim buffer] Reclaim unused buffer for dynamic buffer model (sonic-net#1910) 9258978 [orchagent, cfgmgr] Add response publisher and state recording (sonic-net#1992) 3d862a7 Fixing subport vs test script for subport under VNET (sonic-net#2048) fb0a5fd Don't handle buffer pool watermark during warm reboot reconciling (sonic-net#1987) 16d4bcd Routed subinterface enhancements (sonic-net#1907) 9639db7 [vstest/subintf] Add vs test to validate sub interface ingress to a vnet (sonic-net#1642) Signed-off-by: Stephen Sun <stephens@nvidia.com>

stephenxs · 2021-12-01T03:45:47Z

KVM v0 test bgp/test_bgp_speaker.py::test_bgp_speaker_bgp_sessions failed due to a bulk operation error.

Nov 30 18:18:03.998387 vlab-01 ERR swss#orchagent: :- meta_sai_validate_route_entry: object key SAI_OBJECT_TYPE_ROUTE_ENTRY:{"dest":"193.9.80.128/25","switch_id":"oid:0x21000000000000","vr":"oid:0x3000000000022"} doesn't exist
Nov 30 18:18:03.998979 vlab-01 ERR swss#orchagent: :- flush_setting_entries: EntityBulker.flush set entry attribute failed, number of entries to set: 1000, status: SAI_STATUS_INVALID_PARAMETER
Nov 30 18:18:03.999571 vlab-01 ERR swss#orchagent: :- meta_sai_validate_route_entry: object key SAI_OBJECT_TYPE_ROUTE_ENTRY:{"dest":"192.236.72.128/25","switch_id":"oid:0x21000000000000","vr":"oid:0x3000000000022"} doesn't exist
Nov 30 18:18:04.000069 vlab-01 ERR swss#orchagent: :- flush_setting_entries: EntityBulker.flush set entry attribute failed, number of entries to set: 1000, status: SAI_STATUS_INVALID_PARAMETER
Nov 30 18:18:04.000690 vlab-01 ERR swss#orchagent: :- meta_sai_validate_route_entry: object key SAI_OBJECT_TYPE_ROUTE_ENTRY:{"dest":"192.254.80.128/25","switch_id":"oid:0x21000000000000","vr":"oid:0x3000000000022"} doesn't exist
Nov 30 18:18:04.001128 vlab-01 ERR swss#orchagent: :- flush_setting_entries: EntityBulker.flush set entry attribute failed, number of entries to set: 1000, status: SAI_STATUS_INVALID_PARAMETER
Nov 30 18:18:04.001549 vlab-01 ERR swss#orchagent: :- meta_sai_validate_route_entry: object key SAI_OBJECT_TYPE_ROUTE_ENTRY:{"dest":"192.188.120.128/25","switch_id":"oid:0x21000000000000","vr":"oid:0x3000000000022"} doesn't exist
Nov 30 18:18:04.001984 vlab-01 ERR swss#orchagent: :- flush_setting_entries: EntityBulker.flush set entry attribute failed, number of entries to set: 321, status: SAI_STATUS_INVALID_PARAMETER
Nov 30 18:18:04.003547 vlab-01 ERR swss#orchagent: :- addRoutePost: Failed to set route 0.0.0.0/0 with packet action forward, -23
Nov 30 18:18:04.003869 vlab-01 ERR swss#orchagent: :- handleSaiSetStatus: Encountered failure in set operation, exiting orchagent, SAI API: SAI_API_ROUTE, status: SAI_STATUS_NOT_EXECUTED

@prsunny @qiluo-msft can you please check it?

Signed-off-by: Stephen Sun <stephens@nvidia.com>

prsunny · 2021-12-01T17:35:18Z

Could you please update to latest?

d352d5a Update default route status to state DB (sonic-net#2009) 24a64d6 Orchagent: Integrate P4Orch (sonic-net#2029) Signed-off-by: Stephen Sun <stephens@nvidia.com>

stephenxs · 2021-12-01T23:15:18Z

Could you please update to latest?

@prsunny Done. Can you help check failures as well? It's related to routing/neighbor handling. If necessary I can open an issue with all the details
Thanks.

stephenxs · 2021-12-03T21:43:38Z

/azpw run

mssonicbld · 2021-12-03T21:43:39Z

/AzurePipelines run

azure-pipelines · 2021-12-03T21:43:45Z

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

stephenxs · 2021-12-03T23:39:56Z

/azpw run azure.sonic-buildimage

mssonicbld · 2021-12-03T23:39:57Z

/AzurePipelines run azure.sonic-buildimage

azure-pipelines · 2021-12-03T23:40:10Z

Azure Pipelines successfully started running 1 pipeline(s).

liat-grozovik · 2021-12-06T18:08:35Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2021-12-06T18:08:46Z

Azure Pipelines successfully started running 1 pipeline(s).

stephenxs · 2021-12-07T11:03:53Z

This PR fails due to issue #9434

mssonicbld · 2021-12-15T08:43:00Z

/AzurePipelines run Azure.sonic-buildimage

azure-pipelines · 2021-12-15T08:43:12Z

Azure Pipelines successfully started running 1 pipeline(s).

stephenxs · 2021-12-15T13:35:49Z

/azpw run Azure.sonic-buildimage

mssonicbld · 2021-12-15T13:35:50Z

/AzurePipelines run Azure.sonic-buildimage

azure-pipelines · 2021-12-15T13:36:03Z

Azure Pipelines successfully started running 1 pipeline(s).

stephenxs · 2021-12-16T00:42:58Z

/azpw run Azure.sonic-buildimage

mssonicbld · 2021-12-16T00:43:00Z

/AzurePipelines run Azure.sonic-buildimage

azure-pipelines · 2021-12-16T00:43:11Z

Azure Pipelines successfully started running 1 pipeline(s).

stephenxs · 2021-12-16T05:24:39Z

/azpw run Azure.sonic-buildimage

mssonicbld · 2021-12-16T05:24:41Z

/AzurePipelines run Azure.sonic-buildimage

azure-pipelines · 2021-12-16T05:24:53Z

Azure Pipelines successfully started running 1 pipeline(s).

stephenxs · 2021-12-16T06:19:40Z

/azpw run Azure.sonic-buildimage

mssonicbld · 2021-12-16T06:19:42Z

/AzurePipelines run Azure.sonic-buildimage

azure-pipelines · 2021-12-16T06:19:54Z

Azure Pipelines successfully started running 1 pipeline(s).

stephenxs · 2021-12-16T15:06:54Z

With issue #9434 fixed the orchagent will be no longer aborted but the test still fails because route_check didn't find some routing entries in ASIC_DB.
From the log I saw there were ROUTE_TABLE setting operations but it was not be passed to ASIC_Db. The entry was not in the bulk create call. The nexthop and neighbor have been added to ASIC_DB when routing entry was being added.

stephenxs · 2021-12-20T09:46:43Z

The check failures should be fixed by PR swss 2086

691c37b [Route bulk] Fix bugs in case a SET operation follows a DEL operation in the same bulk (sonic-net#2086) a4c80c3 patch for issue sonic-net#1971 - enable Rx Drop handling for cisco-8000 (sonic-net#2041) 71751d1 [macsec] Support setting IPG by gearbox_config.json (sonic-net#2051) Signed-off-by: Stephen Sun <stephens@nvidia.com>

stephenxs · 2021-12-23T08:05:47Z

@qiluo-msft
Eventually, this PR got all passed :) can you please approve and merge it?
Thanks.

stephenxs · 2022-01-06T05:43:51Z

@judyjoseph can you please cherry-pick this PR to the 202111 branch? thank you

qiluo-msft · 2022-01-06T06:16:38Z

@stephenxs We normally do not cherry-pick a submodule PR. Could you create a new PR on 202111 branch?

stephenxs · 2022-01-06T06:18:21Z

@stephenxs We normally do not cherry-pick a submodule PR. Could you create a new PR on 202111 branch?

Sure.

691c37b [Route bulk] Fix bugs in case a SET operation follows a DEL operation in the same bulk (sonic-net/sonic-swss#2086) a4c80c3 patch for issue sonic-net/sonic-swss#1971 - enable Rx Drop handling for cisco-8000 (sonic-net/sonic-swss#2041) 71751d1 [macsec] Support setting IPG by gearbox_config.json (sonic-net/sonic-swss#2051) 5d5c169 [bulk mode] Fix bulk conflict when in case there are both remove and set operations (sonic-net/sonic-swss#2071) 8bbdbd2 Fix SRV6 NHOP CRM object type (sonic-net/sonic-swss#2072) ef5b35f [vstest] VS test failure fix after fabric port orch PR merge (sonic-net/sonic-swss#1811) 89ea538 Supply the missing ingress/egress port profile list in document (sonic-net/sonic-swss#2064) 8123437 [pfc_detect] fix RedisReply errors (sonic-net/sonic-swss#2040) b38f527 [swss][CRM][MPLS] MPLS CRM Nexthop - switch back to using SAI OBJECT rather than SWITCH OBJECT ae061e5 create debug_shell_enable config to enable debug shell (sonic-net/sonic-swss#2060) 45e446d [cbf] Fix max FC value (sonic-net/sonic-swss#2049) b1b5b29 Initial p4orch pytest code. (sonic-net/sonic-swss#2054) d352d5a Update default route status to state DB (sonic-net/sonic-swss#2009) 24a64d6 Orchagent: Integrate P4Orch (sonic-net/sonic-swss#2029) 15a3b6c Delete the IPv6 link-local Neighbor when ipv6 link-local mode is disabled (sonic-net/sonic-swss#1897) ed783e1 [orchagent] Add trap flow counter support (sonic-net/sonic-swss#1951) e9b05a3 [vnetorch] ECMP for vnet tunnel routes with endpoint health monitor (sonic-net/sonic-swss#1955) bcb7d61 P4Orch: inital add of source (sonic-net/sonic-swss#1997) f6f6f86 [mclaglink] fix acl out ports (sonic-net/sonic-swss#2026) fd887bf [Reclaim buffer] Reclaim unused buffer for dynamic buffer model (sonic-net/sonic-swss#1910) 9258978 [orchagent, cfgmgr] Add response publisher and state recording (sonic-net/sonic-swss#1992) 3d862a7 Fixing subport vs test script for subport under VNET (sonic-net/sonic-swss#2048) fb0a5fd Don't handle buffer pool watermark during warm reboot reconciling (sonic-net/sonic-swss#1987) 16d4bcd Routed subinterface enhancements (sonic-net/sonic-swss#1907) 9639db7 [vstest/subintf] Add vs test to validate sub interface ingress to a vnet (sonic-net/sonic-swss#1642) Signed-off-by: Stephen Sun stephens@nvidia.com

stephenxs changed the title ~~f6f6f867 [mclaglink] fix acl out ports (#2026)~~ [sonic-swss] Submodule update Nov 29, 2021

stephenxs force-pushed the advance-swss branch from 32aa71b to 395b412 Compare November 30, 2021 14:08

dprital added the Request for 202111 Branch For PRs being requested for 202111 branch label Dec 1, 2021

Add more update

25b698b

Signed-off-by: Stephen Sun <stephens@nvidia.com>

prsunny mentioned this pull request Dec 1, 2021

Update swss submodule to include p4orch. #9417

Closed

Update swss

ace5ef2

d352d5a Update default route status to state DB (sonic-net#2009) 24a64d6 Orchagent: Integrate P4Orch (sonic-net#2029) Signed-off-by: Stephen Sun <stephens@nvidia.com>

Merge branch 'Azure:master' into advance-swss

97cf0e6

stephenxs mentioned this pull request Dec 2, 2021

Routeorch calls SAI API set attribute for a routing entry which was just removed from SAI in the same bulk operation. Should recreate it in such case. #9434

Closed

qiluo-msft previously approved these changes Dec 6, 2021

View reviewed changes

stephenxs marked this pull request as ready for review December 7, 2021 08:36

stephenxs requested a review from lguohan as a code owner December 7, 2021 08:36

stephenxs dismissed akokhan’s stale review via daef985 December 22, 2021 23:39

stephenxs requested a review from qiluo-msft December 23, 2021 04:23

liat-grozovik approved these changes Dec 28, 2021

View reviewed changes

liat-grozovik merged commit b749c67 into sonic-net:master Dec 28, 2021

stephenxs deleted the advance-swss branch December 28, 2021 13:47

stephenxs removed the Request for 202111 Branch For PRs being requested for 202111 branch label Jan 6, 2022

Conversation

stephenxs commented Nov 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Uh oh!

stephenxs commented Nov 30, 2021

Uh oh!

mssonicbld commented Nov 30, 2021

Uh oh!

azure-pipelines bot commented Nov 30, 2021

Uh oh!

stephenxs commented Nov 30, 2021

Uh oh!

mssonicbld commented Nov 30, 2021

Uh oh!

azure-pipelines bot commented Nov 30, 2021

Uh oh!

stephenxs commented Dec 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

prsunny commented Dec 1, 2021

Uh oh!

stephenxs commented Dec 1, 2021

Uh oh!

stephenxs commented Dec 3, 2021

Uh oh!

mssonicbld commented Dec 3, 2021

Uh oh!

azure-pipelines bot commented Dec 3, 2021

Uh oh!

stephenxs commented Dec 3, 2021

Uh oh!

mssonicbld commented Dec 3, 2021

Uh oh!

azure-pipelines bot commented Dec 3, 2021

Uh oh!

liat-grozovik commented Dec 6, 2021

Uh oh!

azure-pipelines bot commented Dec 6, 2021

Uh oh!

stephenxs commented Dec 7, 2021

Uh oh!

mssonicbld commented Dec 15, 2021

Uh oh!

azure-pipelines bot commented Dec 15, 2021

Uh oh!

stephenxs commented Dec 15, 2021

Uh oh!

mssonicbld commented Dec 15, 2021

Uh oh!

azure-pipelines bot commented Dec 15, 2021

Uh oh!

stephenxs commented Dec 16, 2021

Uh oh!

mssonicbld commented Dec 16, 2021

Uh oh!

azure-pipelines bot commented Dec 16, 2021

Uh oh!

stephenxs commented Dec 16, 2021

Uh oh!

mssonicbld commented Dec 16, 2021

Uh oh!

azure-pipelines bot commented Dec 16, 2021

Uh oh!

stephenxs commented Dec 16, 2021

Uh oh!

mssonicbld commented Dec 16, 2021

Uh oh!

azure-pipelines bot commented Dec 16, 2021

Uh oh!

stephenxs commented Dec 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stephenxs commented Dec 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

stephenxs commented Nov 29, 2021 •

edited

Loading

stephenxs commented Dec 1, 2021 •

edited

Loading

stephenxs commented Dec 16, 2021 •

edited

Loading

stephenxs commented Dec 20, 2021 •

edited

Loading