[yang]: Add Yang models for BGP monitor by ganglyu · Pull Request #9752 · sonic-net/sonic-buildimage

ganglyu · 2022-01-13T06:06:17Z

Signed-off-by: Gang Lv ganglv@microsoft.com

Why I did it

end2end test is blocked by Yang model for BGP monitor.

How I did it

Create new yang files for BGP monitor, and add UT.

How to verify it

Follow the steps in #9711.
Run UT for sonic-yang-models.

Which release branch to backport (provide reason below if selected)

Description for the changelog

Fix #9711

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Gang Lv ganglv@microsoft.com

wen587 · 2022-01-13T08:53:04Z

Tested on KVM env. apply-patch can succeed. But bgpcfgd report ERR. It may be caused by invalid value in my patch because I am not sure how to configure that.

BTW, I saw in production that asn could be 0.

admin@vlab-01:~/bgpl$ cat add.json
[ {
  "op": "add",
  "path": "/BGP_MONITORS",
  "value": {
   "10.0.0.57": {
    "asn": "1",
    "holdtime": "180",
    "keepalive": "60",
    "local_addr": "10.0.0.58",
    "name": "BGPMonitor",
    "nhopself": "0",
    "rrclient": "0"
   }
  }
 }
]

admin@vlab-01:~/bgpl$ sudo cat /var/log/syslog | less

Jan 13 07:12:17.930661 vlab-01 NOTICE config: Patch Applier: Applying 7 changes in order:
Jan 13 07:12:17.930783 vlab-01 NOTICE config: Patch Applier:   * [{"op": "add", "path": "/BGP_MONITORS", "value": {"10.0.0.57": {"asn": "1"}}}]
Jan 13 07:12:18.269504 vlab-01 DEBUG bgp#bgpcfgd: Received message : '('10.0.0.57', 'SET', (('asn', '1'),))'
Jan 13 07:12:18.271356 vlab-01 WARNING bgp#bgpcfgd: Peer 10.0.0.57. Missing attribute 'local_addr'
Jan 13 07:12:18.272549 vlab-01 INFO bgp#bgpcfgd: Routing policy for peer '10.0.0.57' has been scheduled to be updated
Jan 13 07:12:18.272549 vlab-01 INFO bgp#bgpcfgd: Peer-group for peer '10.0.0.57' has been scheduled to be updated
Jan 13 07:12:18.273635 vlab-01 INFO bgp#bgpcfgd: Peer '(default|10.0.0.57)' has been scheduled to be added with attributes '{'asn': '1'}'
Jan 13 07:12:18.274026 vlab-01 DEBUG bgp#bgpcfgd: execute command '['vtysh', '-f', '/tmp/tmph_geju49']'.
Jan 13 07:12:18.399504 vlab-01 ERR bgp#bgpcfgd: command execution returned 2. Command: '['vtysh', '-f', '/tmp/tmph_geju49']', stdout: '', stderr: 'line 29: % Unknown command[24]:   neighbor 10.0.0.57 description #012'
Jan 13 07:12:18.400561 vlab-01 ERR bgp#bgpcfgd: ConfigMgr::commit(): can't push configuration from file='/tmp/tmph_geju49', rc='2', stdout='', stderr='line 29: % Unknown command[24]:   neighbor 10.0.0.57 description #012'
Jan 13 07:12:18.401146 vlab-01 CRIT bgp#bgpcfgd: Runner::commit was unsuccessful
Jan 13 07:12:18.574125 vlab-01 NOTICE config: Patch Applier:   * [{"op": "add", "path": "/BGP_MONITORS/10.0.0.57/holdtime", "value": "180"}]
Jan 13 07:12:18.926387 vlab-01 DEBUG bgp#bgpcfgd: Received message : '('10.0.0.57', 'SET', (('asn', '1'), ('holdtime', '180')))'
Jan 13 07:12:18.926801 vlab-01 ERR bgp#bgpcfgd: Peer '(default|10.0.0.57)': Can't update the peer. Only 'admin_status' attribute is supported
Jan 13 07:12:19.269490 vlab-01 NOTICE config: Patch Applier:   * [{"op": "add", "path": "/BGP_MONITORS/10.0.0.57/keepalive", "value": "60"}]
Jan 13 07:12:19.599301 vlab-01 DEBUG bgp#bgpcfgd: Received message : '('10.0.0.57', 'SET', (('asn', '1'), ('holdtime', '180'), ('keepalive', '60')))'
Jan 13 07:12:19.599526 vlab-01 ERR bgp#bgpcfgd: Peer '(default|10.0.0.57)': Can't update the peer. Only 'admin_status' attribute is supported
Jan 13 07:12:19.926194 vlab-01 NOTICE config: Patch Applier:   * [{"op": "add", "path": "/BGP_MONITORS/10.0.0.57/local_addr", "value": "10.0.0.58"}]
Jan 13 07:12:20.264585 vlab-01 DEBUG bgp#bgpcfgd: Received message : '('10.0.0.57', 'SET', (('asn', '1'), ('holdtime', '180'), ('keepalive', '60'), ('local_addr', '10.0.0.58')))'
Jan 13 07:12:20.264926 vlab-01 ERR bgp#bgpcfgd: Peer '(default|10.0.0.57)': Can't update the peer. Only 'admin_status' attribute is supported
Jan 13 07:12:20.574737 vlab-01 NOTICE config: Patch Applier:   * [{"op": "add", "path": "/BGP_MONITORS/10.0.0.57/name", "value": "BGPMonitor"}]
Jan 13 07:12:20.896012 vlab-01 DEBUG bgp#bgpcfgd: Received message : '('10.0.0.57', 'SET', (('asn', '1'), ('holdtime', '180'), ('keepalive', '60'), ('local_addr', '10.0.0.58'), ('name', 'BGPMonitor')))'
Jan 13 07:12:20.896012 vlab-01 ERR bgp#bgpcfgd: Peer '(default|10.0.0.57)': Can't update the peer. Only 'admin_status' attribute is supported
Jan 13 07:12:21.228961 vlab-01 NOTICE config: Patch Applier:   * [{"op": "add", "path": "/BGP_MONITORS/10.0.0.57/nhopself", "value": "0"}]
Jan 13 07:12:21.562566 vlab-01 DEBUG bgp#bgpcfgd: Received message : '('10.0.0.57', 'SET', (('asn', '1'), ('holdtime', '180'), ('keepalive', '60'), ('local_addr', '10.0.0.58'), ('name', 'BGPMonitor'), ('nhopself', '0')))'
Jan 13 07:12:21.562566 vlab-01 ERR bgp#bgpcfgd: Peer '(default|10.0.0.57)': Can't update the peer. Only 'admin_status' attribute is supported
Jan 13 07:12:21.898524 vlab-01 NOTICE config: Patch Applier:   * [{"op": "add", "path": "/BGP_MONITORS/10.0.0.57/rrclient", "value": "0"}]
Jan 13 07:12:22.256744 vlab-01 DEBUG bgp#bgpcfgd: Received message : '('10.0.0.57', 'SET', (('asn', '1'), ('holdtime', '180'), ('keepalive', '60'), ('local_addr', '10.0.0.58'), ('name', 'BGPMonitor'), ('nhopself', '0'), ('rrclient', '0')))'
Jan 13 07:12:22.256744 vlab-01 ERR bgp#bgpcfgd: Peer '(default|10.0.0.57)': Can't update the peer. Only 'admin_status' attribute is supported
Jan 13 07:12:22.625071 vlab-01 NOTICE config: Patch Applier: Verifying patch updates are reflected on ConfigDB.
Jan 13 07:12:23.670024 vlab-01 NOTICE config: Patch Applier: Patch application completed.

shi-su · 2022-01-13T18:09:16Z

src/sonic-yang-models/yang-models/sonic-bgp-monitor.yang

+                        range "0..1";
+                    }
+                    description "Route reflector client";
+                }


I am not sure if nhopself and rrclient are required fields. Could you please confirm?

Per bgpcfgd code, these are required fields.

qiluo-msft · 2022-01-13T18:34:28Z

@venkatmahalingam Could you help review?

venkatmahalingam · 2022-01-13T20:14:49Z

@venkatmahalingam Could you help review?

Sure, will do.

venkatmahalingam · 2022-01-15T03:30:28Z

src/sonic-yang-models/yang-models/sonic-bgp-monitor.yang

+    }
+
+    container sonic-bgp-monitor {
+        container BGP_MONITORS {


This table fields seem to be duplicate from the table BGP_NEIGHBOR, please clarify why do we need a separate table, also, please use the grouping to group the fields and use them in multiple places.

This table fields seem to be duplicate from the table BGP_NEIGHBOR, please clarify why do we need a separate table

This is a good question, and I believe it is large than the PR trying to solve, ie, add the missing yang model for BGP_MONITORS table, which is existing for long,.

This PR will help minigraph parser unit test improvement, which validate each minigraph generated ConfigDB by SONiC Yang model.

This PR will also unblock the generic config updater end-to-end test.

We can create an issue that BGP_NEIGHBOR and BGP_MONITORS tables should be unified.

Created issue #9793

venkatmahalingam · 2022-01-15T03:31:58Z

src/sonic-yang-models/tests/yang_model_tests/tests_config/bgp.json

        }
-    }
+    },



I think, we should add YANG for BGP_PEER_RANGE table as well, please check and create the PR for review.

wen587 · 2022-01-18T03:33:34Z

Tested on KVM env. apply-patch can succeed. But bgpcfgd report ERR. It may be caused by invalid value in my patch because I am not sure how to configure that.

BTW, I saw in production that asn could be 0.

admin@vlab-01:~/bgpl$ cat add.json
[ {
  "op": "add",
  "path": "/BGP_MONITORS",
  "value": {
   "10.0.0.57": {
    "asn": "1",
    "holdtime": "180",
    "keepalive": "60",
    "local_addr": "10.0.0.58",
    "name": "BGPMonitor",
    "nhopself": "0",
    "rrclient": "0"
   }
  }
 }
]

admin@vlab-01:~/bgpl$ sudo cat /var/log/syslog | less

Jan 13 07:12:17.930661 vlab-01 NOTICE config: Patch Applier: Applying 7 changes in order:
Jan 13 07:12:17.930783 vlab-01 NOTICE config: Patch Applier:   * [{"op": "add", "path": "/BGP_MONITORS", "value": {"10.0.0.57": {"asn": "1"}}}]
Jan 13 07:12:18.269504 vlab-01 DEBUG bgp#bgpcfgd: Received message : '('10.0.0.57', 'SET', (('asn', '1'),))'
Jan 13 07:12:18.271356 vlab-01 WARNING bgp#bgpcfgd: Peer 10.0.0.57. Missing attribute 'local_addr'
Jan 13 07:12:18.272549 vlab-01 INFO bgp#bgpcfgd: Routing policy for peer '10.0.0.57' has been scheduled to be updated
Jan 13 07:12:18.272549 vlab-01 INFO bgp#bgpcfgd: Peer-group for peer '10.0.0.57' has been scheduled to be updated
Jan 13 07:12:18.273635 vlab-01 INFO bgp#bgpcfgd: Peer '(default|10.0.0.57)' has been scheduled to be added with attributes '{'asn': '1'}'
Jan 13 07:12:18.274026 vlab-01 DEBUG bgp#bgpcfgd: execute command '['vtysh', '-f', '/tmp/tmph_geju49']'.
Jan 13 07:12:18.399504 vlab-01 ERR bgp#bgpcfgd: command execution returned 2. Command: '['vtysh', '-f', '/tmp/tmph_geju49']', stdout: '', stderr: 'line 29: % Unknown command[24]:   neighbor 10.0.0.57 description #012'
Jan 13 07:12:18.400561 vlab-01 ERR bgp#bgpcfgd: ConfigMgr::commit(): can't push configuration from file='/tmp/tmph_geju49', rc='2', stdout='', stderr='line 29: % Unknown command[24]:   neighbor 10.0.0.57 description #012'
Jan 13 07:12:18.401146 vlab-01 CRIT bgp#bgpcfgd: Runner::commit was unsuccessful
Jan 13 07:12:18.574125 vlab-01 NOTICE config: Patch Applier:   * [{"op": "add", "path": "/BGP_MONITORS/10.0.0.57/holdtime", "value": "180"}]
Jan 13 07:12:18.926387 vlab-01 DEBUG bgp#bgpcfgd: Received message : '('10.0.0.57', 'SET', (('asn', '1'), ('holdtime', '180')))'
Jan 13 07:12:18.926801 vlab-01 ERR bgp#bgpcfgd: Peer '(default|10.0.0.57)': Can't update the peer. Only 'admin_status' attribute is supported
Jan 13 07:12:19.269490 vlab-01 NOTICE config: Patch Applier:   * [{"op": "add", "path": "/BGP_MONITORS/10.0.0.57/keepalive", "value": "60"}]
Jan 13 07:12:19.599301 vlab-01 DEBUG bgp#bgpcfgd: Received message : '('10.0.0.57', 'SET', (('asn', '1'), ('holdtime', '180'), ('keepalive', '60')))'
Jan 13 07:12:19.599526 vlab-01 ERR bgp#bgpcfgd: Peer '(default|10.0.0.57)': Can't update the peer. Only 'admin_status' attribute is supported
Jan 13 07:12:19.926194 vlab-01 NOTICE config: Patch Applier:   * [{"op": "add", "path": "/BGP_MONITORS/10.0.0.57/local_addr", "value": "10.0.0.58"}]
Jan 13 07:12:20.264585 vlab-01 DEBUG bgp#bgpcfgd: Received message : '('10.0.0.57', 'SET', (('asn', '1'), ('holdtime', '180'), ('keepalive', '60'), ('local_addr', '10.0.0.58')))'
Jan 13 07:12:20.264926 vlab-01 ERR bgp#bgpcfgd: Peer '(default|10.0.0.57)': Can't update the peer. Only 'admin_status' attribute is supported
Jan 13 07:12:20.574737 vlab-01 NOTICE config: Patch Applier:   * [{"op": "add", "path": "/BGP_MONITORS/10.0.0.57/name", "value": "BGPMonitor"}]
Jan 13 07:12:20.896012 vlab-01 DEBUG bgp#bgpcfgd: Received message : '('10.0.0.57', 'SET', (('asn', '1'), ('holdtime', '180'), ('keepalive', '60'), ('local_addr', '10.0.0.58'), ('name', 'BGPMonitor')))'
Jan 13 07:12:20.896012 vlab-01 ERR bgp#bgpcfgd: Peer '(default|10.0.0.57)': Can't update the peer. Only 'admin_status' attribute is supported
Jan 13 07:12:21.228961 vlab-01 NOTICE config: Patch Applier:   * [{"op": "add", "path": "/BGP_MONITORS/10.0.0.57/nhopself", "value": "0"}]
Jan 13 07:12:21.562566 vlab-01 DEBUG bgp#bgpcfgd: Received message : '('10.0.0.57', 'SET', (('asn', '1'), ('holdtime', '180'), ('keepalive', '60'), ('local_addr', '10.0.0.58'), ('name', 'BGPMonitor'), ('nhopself', '0')))'
Jan 13 07:12:21.562566 vlab-01 ERR bgp#bgpcfgd: Peer '(default|10.0.0.57)': Can't update the peer. Only 'admin_status' attribute is supported
Jan 13 07:12:21.898524 vlab-01 NOTICE config: Patch Applier:   * [{"op": "add", "path": "/BGP_MONITORS/10.0.0.57/rrclient", "value": "0"}]
Jan 13 07:12:22.256744 vlab-01 DEBUG bgp#bgpcfgd: Received message : '('10.0.0.57', 'SET', (('asn', '1'), ('holdtime', '180'), ('keepalive', '60'), ('local_addr', '10.0.0.58'), ('name', 'BGPMonitor'), ('nhopself', '0'), ('rrclient', '0')))'
Jan 13 07:12:22.256744 vlab-01 ERR bgp#bgpcfgd: Peer '(default|10.0.0.57)': Can't update the peer. Only 'admin_status' attribute is supported
Jan 13 07:12:22.625071 vlab-01 NOTICE config: Patch Applier: Verifying patch updates are reflected on ConfigDB.
Jan 13 07:12:23.670024 vlab-01 NOTICE config: Patch Applier: Patch application completed.

Any insight for bgpcfgd issue?

Signed-off-by: Gang Lv ganglv@microsoft.com

venkatmahalingam · 2022-01-19T08:43:54Z

src/sonic-yang-models/tests/yang_model_tests/tests_config/bgp.json

+                        "holdtime": "180",
+                        "keepalive": "60",
+                        "local_addr": "10.0.0.2",
+                        "name":"BGPMonitor123",


Does this test case validate 'name' field? having the digit in the name is invalid?

https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-config-engine/minigraph.py#L823
It seems that the name must be 'BGPMonitor'

Why I did it end2end test is blocked by Yang model for BGP monitor. How I did it Create new yang files for BGP monitor, and add UT. How to verify it Follow the steps in #9711. Run UT for sonic-yang-models. Signed-off-by: Gang Lv ganglv@microsoft.com

ghooo · 2022-01-28T07:36:00Z

Tested on KVM env. apply-patch can succeed. But bgpcfgd report ERR. It may be caused by invalid value in my patch because I am not sure how to configure that.
BTW, I saw in production that asn could be 0.

admin@vlab-01:~/bgpl$ cat add.json
[ {
  "op": "add",
  "path": "/BGP_MONITORS",
  "value": {
   "10.0.0.57": {
    "asn": "1",
    "holdtime": "180",
    "keepalive": "60",
    "local_addr": "10.0.0.58",
    "name": "BGPMonitor",
    "nhopself": "0",
    "rrclient": "0"
   }
  }
 }
]

admin@vlab-01:~/bgpl$ sudo cat /var/log/syslog | less

Jan 13 07:12:17.930661 vlab-01 NOTICE config: Patch Applier: Applying 7 changes in order:
Jan 13 07:12:17.930783 vlab-01 NOTICE config: Patch Applier:   * [{"op": "add", "path": "/BGP_MONITORS", "value": {"10.0.0.57": {"asn": "1"}}}]
Jan 13 07:12:18.269504 vlab-01 DEBUG bgp#bgpcfgd: Received message : '('10.0.0.57', 'SET', (('asn', '1'),))'
Jan 13 07:12:18.271356 vlab-01 WARNING bgp#bgpcfgd: Peer 10.0.0.57. Missing attribute 'local_addr'
Jan 13 07:12:18.272549 vlab-01 INFO bgp#bgpcfgd: Routing policy for peer '10.0.0.57' has been scheduled to be updated
Jan 13 07:12:18.272549 vlab-01 INFO bgp#bgpcfgd: Peer-group for peer '10.0.0.57' has been scheduled to be updated
Jan 13 07:12:18.273635 vlab-01 INFO bgp#bgpcfgd: Peer '(default|10.0.0.57)' has been scheduled to be added with attributes '{'asn': '1'}'
Jan 13 07:12:18.274026 vlab-01 DEBUG bgp#bgpcfgd: execute command '['vtysh', '-f', '/tmp/tmph_geju49']'.
Jan 13 07:12:18.399504 vlab-01 ERR bgp#bgpcfgd: command execution returned 2. Command: '['vtysh', '-f', '/tmp/tmph_geju49']', stdout: '', stderr: 'line 29: % Unknown command[24]:   neighbor 10.0.0.57 description #012'
Jan 13 07:12:18.400561 vlab-01 ERR bgp#bgpcfgd: ConfigMgr::commit(): can't push configuration from file='/tmp/tmph_geju49', rc='2', stdout='', stderr='line 29: % Unknown command[24]:   neighbor 10.0.0.57 description #012'
Jan 13 07:12:18.401146 vlab-01 CRIT bgp#bgpcfgd: Runner::commit was unsuccessful
Jan 13 07:12:18.574125 vlab-01 NOTICE config: Patch Applier:   * [{"op": "add", "path": "/BGP_MONITORS/10.0.0.57/holdtime", "value": "180"}]
Jan 13 07:12:18.926387 vlab-01 DEBUG bgp#bgpcfgd: Received message : '('10.0.0.57', 'SET', (('asn', '1'), ('holdtime', '180')))'
Jan 13 07:12:18.926801 vlab-01 ERR bgp#bgpcfgd: Peer '(default|10.0.0.57)': Can't update the peer. Only 'admin_status' attribute is supported
Jan 13 07:12:19.269490 vlab-01 NOTICE config: Patch Applier:   * [{"op": "add", "path": "/BGP_MONITORS/10.0.0.57/keepalive", "value": "60"}]
Jan 13 07:12:19.599301 vlab-01 DEBUG bgp#bgpcfgd: Received message : '('10.0.0.57', 'SET', (('asn', '1'), ('holdtime', '180'), ('keepalive', '60')))'
Jan 13 07:12:19.599526 vlab-01 ERR bgp#bgpcfgd: Peer '(default|10.0.0.57)': Can't update the peer. Only 'admin_status' attribute is supported
Jan 13 07:12:19.926194 vlab-01 NOTICE config: Patch Applier:   * [{"op": "add", "path": "/BGP_MONITORS/10.0.0.57/local_addr", "value": "10.0.0.58"}]
Jan 13 07:12:20.264585 vlab-01 DEBUG bgp#bgpcfgd: Received message : '('10.0.0.57', 'SET', (('asn', '1'), ('holdtime', '180'), ('keepalive', '60'), ('local_addr', '10.0.0.58')))'
Jan 13 07:12:20.264926 vlab-01 ERR bgp#bgpcfgd: Peer '(default|10.0.0.57)': Can't update the peer. Only 'admin_status' attribute is supported
Jan 13 07:12:20.574737 vlab-01 NOTICE config: Patch Applier:   * [{"op": "add", "path": "/BGP_MONITORS/10.0.0.57/name", "value": "BGPMonitor"}]
Jan 13 07:12:20.896012 vlab-01 DEBUG bgp#bgpcfgd: Received message : '('10.0.0.57', 'SET', (('asn', '1'), ('holdtime', '180'), ('keepalive', '60'), ('local_addr', '10.0.0.58'), ('name', 'BGPMonitor')))'
Jan 13 07:12:20.896012 vlab-01 ERR bgp#bgpcfgd: Peer '(default|10.0.0.57)': Can't update the peer. Only 'admin_status' attribute is supported
Jan 13 07:12:21.228961 vlab-01 NOTICE config: Patch Applier:   * [{"op": "add", "path": "/BGP_MONITORS/10.0.0.57/nhopself", "value": "0"}]
Jan 13 07:12:21.562566 vlab-01 DEBUG bgp#bgpcfgd: Received message : '('10.0.0.57', 'SET', (('asn', '1'), ('holdtime', '180'), ('keepalive', '60'), ('local_addr', '10.0.0.58'), ('name', 'BGPMonitor'), ('nhopself', '0')))'
Jan 13 07:12:21.562566 vlab-01 ERR bgp#bgpcfgd: Peer '(default|10.0.0.57)': Can't update the peer. Only 'admin_status' attribute is supported
Jan 13 07:12:21.898524 vlab-01 NOTICE config: Patch Applier:   * [{"op": "add", "path": "/BGP_MONITORS/10.0.0.57/rrclient", "value": "0"}]
Jan 13 07:12:22.256744 vlab-01 DEBUG bgp#bgpcfgd: Received message : '('10.0.0.57', 'SET', (('asn', '1'), ('holdtime', '180'), ('keepalive', '60'), ('local_addr', '10.0.0.58'), ('name', 'BGPMonitor'), ('nhopself', '0'), ('rrclient', '0')))'
Jan 13 07:12:22.256744 vlab-01 ERR bgp#bgpcfgd: Peer '(default|10.0.0.57)': Can't update the peer. Only 'admin_status' attribute is supported
Jan 13 07:12:22.625071 vlab-01 NOTICE config: Patch Applier: Verifying patch updates are reflected on ConfigDB.
Jan 13 07:12:23.670024 vlab-01 NOTICE config: Patch Applier: Patch application completed.

Any insight for bgpcfgd issue?

I think this is because the fields under BGP_MONITORS are all create-only. The patch steps are adding each field one by one, this is not correct, The field needs to be added when the parent is created, if they are to be updated The parent needs to be deleted and added back. related issue: sonic-net/sonic-utilities#2029

wen587 · 2022-01-28T07:59:10Z

Hi Mohamed, I agree with you on the create-only conclusion. It is not an urgent need to fix as it can work now after I modify the patch.
Above example are trying to update peer address 10.0.0.57 which may not be a valid operation.
Check the test example here:
sonic-net/sonic-mgmt#4987

[yang]: Add Yang models for BGP monitor

02a0754

Signed-off-by: Gang Lv ganglv@microsoft.com

ganglyu assigned wen587 Jan 13, 2022

ganglyu requested a review from qiluo-msft as a code owner January 13, 2022 06:06

ganglyu assigned qiluo-msft and praveen-li and unassigned wen587, qiluo-msft and praveen-li Jan 13, 2022

ganglyu requested review from dgsudharsan, losha228, praveen-li, rathnasabapathyv and wen587 January 13, 2022 06:07

qiluo-msft requested review from isabelmsft and shi-su January 13, 2022 06:49

shi-su reviewed Jan 13, 2022

View reviewed changes

dgsudharsan requested a review from venkatmahalingam January 15, 2022 02:47

venkatmahalingam reviewed Jan 15, 2022

View reviewed changes

qiluo-msft mentioned this pull request Jan 19, 2022

BGP_NEIGHBOR and BGP_MONITORS tables should be unified. #9793

Open

Use grouping for BGP_MONITORS and BGP_NEIGHBOR

3280ed9

Signed-off-by: Gang Lv ganglv@microsoft.com

ganglyu mentioned this pull request Jan 19, 2022

Need YANG for BGP_PEER_RANGE table #9794

Closed

ganglyu requested review from shi-su and venkatmahalingam January 19, 2022 07:42

venkatmahalingam reviewed Jan 19, 2022

View reviewed changes

ganglyu requested a review from venkatmahalingam January 19, 2022 08:54

venkatmahalingam approved these changes Jan 19, 2022

View reviewed changes

qiluo-msft approved these changes Jan 19, 2022

View reviewed changes

ganglyu merged commit dde5f37 into sonic-net:master Jan 20, 2022

ganglyu added the Request for 202111 Branch For PRs being requested for 202111 branch label Jan 20, 2022

judyjoseph added the Included in 202111 Branch label Jan 23, 2022

Conversation

ganglyu commented Jan 13, 2022

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Uh oh!

wen587 commented Jan 13, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

qiluo-msft commented Jan 13, 2022

Uh oh!

venkatmahalingam commented Jan 13, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wen587 commented Jan 18, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ghooo commented Jan 28, 2022

Uh oh!

wen587 commented Jan 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants