[Build]: Support reproducible build for release branches#9426
[Build]: Support reproducible build for release branches#9426xumia merged 7 commits intosonic-net:masterfrom
Conversation
There was a problem hiding this comment.
- '202[1-9]*'
The 5th and 6th digits are the month. Let's pattern match them and keep string length fixed. #Closed
There was a problem hiding this comment.
The regex is not supported in AZP yet, it only supports ? and *.
There was a problem hiding this comment.
What happen if the SourceBranchName is not a number? Should we explicitly handle this case? #Closed
There was a problem hiding this comment.
@qiluo-msft , we use string comparing, will skip the reproducible build feature if not in the range.
There was a problem hiding this comment.
VERSION_CONTROL_OPTIONS is not defined in that case. Is it going to be a problem?
There was a problem hiding this comment.
It is depended how to use the variable.
Micro: $(VERSION_CONTROL_OPTIONS) --- not work
Template: ${{ variables.VERSION_CONTROL_OPTIONS }} --- empty
Runtime: $[variables.VERSION_CONTROL_OPTIONS ] --- empty
Currently, we are good, we use template way.
24b6b7b to
4578a0a
Compare
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| - 202012 | ||
| - 20???? | ||
| exclude: | ||
| - 200* |
.github/workflows/label.yml
Outdated
| - reopened | ||
| branches: | ||
| - '202012' | ||
| - '202[1-9]*' |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
[Build]: Support reproducible build for release branches #9426
|
@xumia Do you need this commit on 202012 branch? |
) [Build]: Support reproducible build for release branches sonic-net#9426
[Build]: Support reproducible build for release branches #9426
Why I did it
Support reproducible build for release branches
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)