[pmon] Move smartctl from pmon to host#9607
Merged
sujinmkang merged 2 commits intosonic-net:masterfrom Jan 19, 2022
Merged
Conversation
alexrallen
requested review from
lguohan,
qiluo-msft and
xumia
as code owners
Collaborator
|
What is the reason that pmon docker is not running? |
Contributor
Author
|
I need smartctl to be accessible during reboot in order to perform firmware installations. I also believe that it is important for a diagnostic tool such as smartctl to not be dependent on high level functionality like docker. |
liat-grozovik
added
the
Request for 202111 Branch
liat-grozovik
requested review from
sujinmkang
and removed request for
lguohan,
qiluo-msft and
xumia
sujinmkang
previously approved these changes
Jan 18, 2022
Collaborator
|
@alexrallen Can you please resolve the conflicts on this PR? |
Contributor
Author
|
@sujinmkang I fixed the conflict, please re-review. |
sujinmkang
approved these changes
Jan 19, 2022
Contributor
|
@alexrallen There are conflicts merging into 202111, please raise a new PR on branch 20211. |
judyjoseph
removed
the
Request for 202111 Branch
sujinmkang
added
the
Request for 202111 Branch
judyjoseph
pushed a commit
that referenced
this pull request
Feb 14, 2022
Why I did it Need to be able to run smartctl when pmon docker is not running. How I did it Removed the pmon dependency for pmon as well as the command wrapper and added it to the debian-extension. How to verify it Stop pmon Run smartctl from the host and verify it runs without error
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Need to be able to run
smartctlwhen pmon docker is not running.How I did it
Removed the pmon dependency for pmon as well as the command wrapper and added it to the debian-extension.
How to verify it
smartctlfrom the host and verify it runs without errorWhich release branch to backport (provide reason below if selected)
None.
Description for the changelog
[pmon] Move smartctl from pmon to host
A picture of a cute animal (not mandatory but encouraged)