Orchagent: Integrate P4Orch by donNewtonAlpha · Pull Request #2029 · sonic-net/sonic-swss

donNewtonAlpha · 2021-11-13T02:20:21Z

* support pushing switch configurations.
* support ACL table definitions.
* support insert/delete/modify in APPL_DB.
* support for L3 forwarding, WCMP, and ACL tables.
* support for response path through APPL_STATE_DB.

Co-authored-by: Robert Halstead [email protected]
Co-authored-by: Srikishen Pondicherry Shanmugam [email protected]
Co-authored-by: Steffen Smolka [email protected]
Co-authored-by: Jonathan Dilorenzo [email protected]
Co-authored-by: Richard Yu [email protected]
Co-authored-by: Brian O'Connor [email protected]
Co-authored-by: Konstantin Weitz [email protected]
Co-authored-by: Stefan Heule [email protected]
Co-authored-by: Tianyu Xia [email protected]

What I did

Why I did it

How I verified it

Details if related

donNewtonAlpha · 2021-11-13T02:22:01Z

@StephenWangGoogle

lgtm-com · 2021-11-13T02:42:22Z

This pull request introduces 1 alert when merging 7ef8440 into cdea5e9 - view on LGTM.com

new alerts:

1 for Wrong number of arguments in a class instantiation

orchagent/acltable.h

orchagent/orchdaemon.cpp

orchagent/switchorch.cpp

tests/dvslib/dvs_acl.py

lgtm-com · 2021-11-26T05:27:21Z

This pull request introduces 4 alerts when merging 2545b6b into 3d862a7 - view on LGTM.com

new alerts:

4 for Unused import

rlhui · 2021-11-30T16:13:46Z

@donNewtonAlpha - please get all tests passed, seek help from @prsunny if needed.

prsunny · 2021-11-30T17:04:36Z

/azp run

azure-pipelines · 2021-11-30T17:04:46Z

Azure Pipelines successfully started running 1 pipeline(s).

bocon13 · 2021-11-30T20:19:43Z

Rebased to include #1997 and retesting

lgtm-com · 2021-11-30T22:00:47Z

This pull request introduces 1 alert when merging 28fcc2c into bcb7d61 - view on LGTM.com

new alerts:

1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')

bocon13 · 2021-12-01T02:51:39Z

Resolved merge conflicts with #1951

prsunny · 2021-12-01T04:08:54Z

/azp run

azure-pipelines · 2021-12-01T04:09:05Z

Azure Pipelines successfully started running 1 pipeline(s).

* support pushing switch configurations. * support ACL table definitions. * support insert/delete/modify in APPL_DB. * support for L3 forwarding, WCMP, and ACL tables. * support for response path through APPL_STATE_DB. Co-authored-by: Robert Halstead [email protected] Co-authored-by: Srikishen Pondicherry Shanmugam [email protected] Co-authored-by: Steffen Smolka [email protected] Co-authored-by: Jonathan Dilorenzo [email protected] Co-authored-by: Richard Yu [email protected] Co-authored-by: Brian O'Connor [email protected] Co-authored-by: Konstantin Weitz [email protected] Co-authored-by: Stefan Heule [email protected] Co-authored-by: Tianyu Xia [email protected]

lgtm-com · 2021-12-01T07:06:24Z

This pull request introduces 1 alert when merging 6f3671a into 15a3b6c - view on LGTM.com

new alerts:

1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')

lgtm-com · 2021-12-01T08:50:29Z

This pull request introduces 1 alert when merging cb0da91 into 15a3b6c - view on LGTM.com

new alerts:

1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')

mint570 · 2021-12-01T14:33:51Z

@prsunny
I am not sure why the BuildArm is not finished. But it looks like all builds are passing.
There is one alert on copy constructor. Just style alert.
I think we are good to go.

prsunny · 2021-12-01T17:15:43Z

@mint570 , could you please update submodule?

mint570 · 2021-12-01T17:37:03Z

@mint570 , could you please update submodule?

sonic-net/sonic-buildimage#9417

691c37b [Route bulk] Fix bugs in case a SET operation follows a DEL operation in the same bulk (sonic-net/sonic-swss#2086) a4c80c3 patch for issue sonic-net/sonic-swss#1971 - enable Rx Drop handling for cisco-8000 (sonic-net/sonic-swss#2041) 71751d1 [macsec] Support setting IPG by gearbox_config.json (sonic-net/sonic-swss#2051) 5d5c169 [bulk mode] Fix bulk conflict when in case there are both remove and set operations (sonic-net/sonic-swss#2071) 8bbdbd2 Fix SRV6 NHOP CRM object type (sonic-net/sonic-swss#2072) ef5b35f [vstest] VS test failure fix after fabric port orch PR merge (sonic-net/sonic-swss#1811) 89ea538 Supply the missing ingress/egress port profile list in document (sonic-net/sonic-swss#2064) 8123437 [pfc_detect] fix RedisReply errors (sonic-net/sonic-swss#2040) b38f527 [swss][CRM][MPLS] MPLS CRM Nexthop - switch back to using SAI OBJECT rather than SWITCH OBJECT ae061e5 create debug_shell_enable config to enable debug shell (sonic-net/sonic-swss#2060) 45e446d [cbf] Fix max FC value (sonic-net/sonic-swss#2049) b1b5b29 Initial p4orch pytest code. (sonic-net/sonic-swss#2054) d352d5a Update default route status to state DB (sonic-net/sonic-swss#2009) 24a64d6 Orchagent: Integrate P4Orch (sonic-net/sonic-swss#2029) 15a3b6c Delete the IPv6 link-local Neighbor when ipv6 link-local mode is disabled (sonic-net/sonic-swss#1897) ed783e1 [orchagent] Add trap flow counter support (sonic-net/sonic-swss#1951) e9b05a3 [vnetorch] ECMP for vnet tunnel routes with endpoint health monitor (sonic-net/sonic-swss#1955) bcb7d61 P4Orch: inital add of source (sonic-net/sonic-swss#1997) f6f6f86 [mclaglink] fix acl out ports (sonic-net/sonic-swss#2026) fd887bf [Reclaim buffer] Reclaim unused buffer for dynamic buffer model (sonic-net/sonic-swss#1910) 9258978 [orchagent, cfgmgr] Add response publisher and state recording (sonic-net/sonic-swss#1992) 3d862a7 Fixing subport vs test script for subport under VNET (sonic-net/sonic-swss#2048) fb0a5fd Don't handle buffer pool watermark during warm reboot reconciling (sonic-net/sonic-swss#1987) 16d4bcd Routed subinterface enhancements (sonic-net/sonic-swss#1907) 9639db7 [vstest/subintf] Add vs test to validate sub interface ingress to a vnet (sonic-net/sonic-swss#1642) Signed-off-by: Stephen Sun [email protected]

* Orchagent: Integrate P4Orch * support pushing switch configurations. * support ACL table definitions. * support insert/delete/modify in APPL_DB. * support for L3 forwarding, WCMP, and ACL tables. * support for response path through APPL_STATE_DB. Co-authored-by: PINS Working Group <[email protected]>

donNewtonAlpha requested a review from prsunny as a code owner November 13, 2021 02:20

prsunny reviewed Nov 19, 2021

View reviewed changes

orchagent/acltable.h Outdated Show resolved Hide resolved

orchagent/orchdaemon.cpp Show resolved Hide resolved

orchagent/switchorch.cpp Outdated Show resolved Hide resolved

tests/dvslib/dvs_acl.py Outdated Show resolved Hide resolved

donNewtonAlpha force-pushed the integrate-p4orch branch from 31d8f17 to d26368a Compare November 20, 2021 05:29

mint570 force-pushed the integrate-p4orch branch from d4eb11a to 9c20efc Compare November 26, 2021 04:33

bocon13 mentioned this pull request Nov 30, 2021

PINS Upstream Tracking for MVP sonic-net/SONiC#841

Open

mint570 force-pushed the integrate-p4orch branch from 805d73d to a33b44d Compare November 30, 2021 17:45

bocon13 force-pushed the integrate-p4orch branch 2 times, most recently from 066ac51 to 4a351c6 Compare November 30, 2021 20:17

mint570 force-pushed the integrate-p4orch branch from 4a351c6 to a33b44d Compare November 30, 2021 20:30

mint570 force-pushed the integrate-p4orch branch from 28fcc2c to 93b17f5 Compare December 1, 2021 01:21

PINS Working Group and others added 6 commits November 30, 2021 20:22

Fixed acltable.h merge error.

2793c17

Added p4orch py test.

a0ef4b1

Remove unused Python imports for LGTM

3e48a27

Remove p4orch py test.

cfa4d8c

Fixed merge issue.

2c4d887

mint570 force-pushed the integrate-p4orch branch from bab2ddb to 2c4d887 Compare December 1, 2021 04:27

Trigger test

6f3671a

Trigger test

cb0da91

prsunny approved these changes Dec 1, 2021

View reviewed changes

prsunny merged commit 24a64d6 into sonic-net:master Dec 1, 2021

stephenxs mentioned this pull request Dec 1, 2021

[sonic-swss] Submodule update sonic-net/sonic-buildimage#9397

Merged

5 tasks

stephenxs mentioned this pull request Jan 6, 2022

[sonic-swss][202111] Submodule update (#9397) sonic-net/sonic-buildimage#9685

Merged

5 tasks

mint570 deleted the integrate-p4orch branch July 22, 2022 16:38

Conversation

donNewtonAlpha commented Nov 13, 2021

Uh oh!

donNewtonAlpha commented Nov 13, 2021

Uh oh!

lgtm-com bot commented Nov 13, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lgtm-com bot commented Nov 26, 2021

Uh oh!

rlhui commented Nov 30, 2021

Uh oh!

prsunny commented Nov 30, 2021

Uh oh!

azure-pipelines bot commented Nov 30, 2021

Uh oh!

bocon13 commented Nov 30, 2021

Uh oh!

lgtm-com bot commented Nov 30, 2021

Uh oh!

bocon13 commented Dec 1, 2021

Uh oh!

prsunny commented Dec 1, 2021

Uh oh!

azure-pipelines bot commented Dec 1, 2021

Uh oh!

lgtm-com bot commented Dec 1, 2021

Uh oh!

lgtm-com bot commented Dec 1, 2021

Uh oh!

mint570 commented Dec 1, 2021

Uh oh!

prsunny commented Dec 1, 2021

Uh oh!

mint570 commented Dec 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants