Update PDDF utils and common platform APIs for Debian Bullseye#9585
Merged
lguohan merged 2 commits intosonic-net:masterfrom Jan 3, 2022
Merged
Update PDDF utils and common platform APIs for Debian Bullseye#9585lguohan merged 2 commits intosonic-net:masterfrom
lguohan merged 2 commits intosonic-net:masterfrom
Conversation
|
This pull request introduces 2 alerts when merging 117a733 into 36673c1 - view on LGTM.com new alerts:
|
jostar-yang
approved these changes
Dec 21, 2021
Contributor
jostar-yang
left a comment
jostar-yang
left a comment
There was a problem hiding this comment.
The changes are ok to me.
Collaborator
|
can you fix lgtm warnings? |
Contributor
Author
|
Already fixed LGTM warnings |
seanwu-ec
pushed a commit
to seanwu-ec/sonic-buildimage
that referenced
this pull request
Jan 13, 2022
sonic-net#9585) - Why I did it PDDF utils were python2 compliant and they needed to be migrated to Python3 (as per Bullseye) PDDF common platform APIs file name changed as the name was already in use Indentation issues Dead/redundant code needed to be removed - How I did it Made files Python3 compliant Indentation corrected Redundant code removed - How to verify it AS7326 Accton platform uses PDDF. PDDF utils were run on this platform to verify.
Collaborator
|
@FuzailBrcm , @lguohan , the PR should be merged to 202111 branch , right? The value is not defined. Need to merge the change from master to 202111 branch: |
Contributor
Author
|
The error you pointed out is due to $(ENABLE_PY2_MODULES) not equal to 'y'. I guess bullseye is enabled in 202211 branch. Then, yes this PR is required in 202211 branch. |
xumia
added
the
Request for 202111 Branch
xumia
pushed a commit
that referenced
this pull request
Mar 25, 2022
#9585) - Why I did it PDDF utils were python2 compliant and they needed to be migrated to Python3 (as per Bullseye) PDDF common platform APIs file name changed as the name was already in use Indentation issues Dead/redundant code needed to be removed - How I did it Made files Python3 compliant Indentation corrected Redundant code removed - How to verify it AS7326 Accton platform uses PDDF. PDDF utils were run on this platform to verify.
xumia
added
Included in 202111 Branch
and removed
Request for 202111 Branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
How I did it
How to verify it
AS7326 Accton platform uses PDDF. PDDF utils were run on this platform to verify.
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)