[broadcom-dnx] Fix dnx image and dnx platform mismatch issue#9786
Merged
wen587 merged 1 commit intosonic-net:masterfrom Jan 21, 2022
Merged
[broadcom-dnx] Fix dnx image and dnx platform mismatch issue#9786wen587 merged 1 commit intosonic-net:masterfrom
wen587 merged 1 commit intosonic-net:masterfrom
Conversation
wen587
changed the title
Collaborator
|
Do we need this fix on 202111 branch? |
Contributor
Author
I think so. |
qiluo-msft
added
the
Request for 202111 Branch
Collaborator
Please check other images that this fix keep old behavior. We need to make sure there is no regression. |
Contributor
Author
Verified broadcom and mellanox and vs. |
qiluo-msft
approved these changes
Jan 21, 2022
judyjoseph
pushed a commit
that referenced
this pull request
Jan 23, 2022
Why I did it sonic-broadcom-dnx.bin should be able to installed on DNX supported platform, whereas it doesn't. How I did it Changed CONFIGUTED_PLATFORM to TARGET_MACHINE to distinguish broadcom and broadcom-dnx How to verify it tar sonic-broadcom-dnx.bin and verify its platforms_asic contians dnx platforms Also verify on image with other asic, no regression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #9759
Why I did it
sonic-broadcom-dnx.binshould be able to installed on DNX supported platform, whereas it doesn't.How I did it
Changed
CONFIGUTED_PLATFORMtoTARGET_MACHINEto distinguishbroadcomandbroadcom-dnxHow to verify it
tar
sonic-broadcom-dnx.binand verify itsplatforms_asiccontians dnx platformsWhich release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)