Skip to content

[Platform] accton update driver and sync as5712-54x from 201807.#2110

Merged
lguohan merged 5 commits intosonic-net:masterfrom
roylee123:platform_accton_update_driver_for_stretch
Oct 2, 2018
Merged

[Platform] accton update driver and sync as5712-54x from 201807.#2110
lguohan merged 5 commits intosonic-net:masterfrom
roylee123:platform_accton_update_driver_for_stretch

Conversation

@roylee123
Copy link
Collaborator

@roylee123 roylee123 commented Oct 2, 2018

Existing platform dpkg for as5712-54x has a problem on installing.

- What I did
. fix the problem that accton platform dpkg are depending on linux-3.16.
. fix i2c_mux struct mismatching on as5712-54x cpld driver.
. remove redundant optoe driver.
. Sync PR of as5712-54x from 201807.

- How I did it
Delete the depends at debain/control.
Change driver code for new i2c_mux struct on linux 4.x.

- How to verify it
psuutil status
sfputil show presence
sfputil show eeprom
decode-syseeprom
sensors

- Description for the changelog
As above.

@roylee123 roylee123 mentioned this pull request Oct 2, 2018
Closed
lguohan
lguohan approved these changes Oct 2, 2018
View reviewed changes
Copy link
Collaborator

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@lguohan lguohan merged commit 593bcb1 into sonic-net:master Oct 2, 2018
@roylee123 roylee123 mentioned this pull request May 13, 2019
Merged
abdosi pushed a commit that referenced this pull request Jan 21, 2022
[swss] Update submodule (#9816)
e88d7b3 
Update the sonic-swss submodule. The following are new commits in the submodule:

6cb43ee [p4orch] Fix handlePortStatusChangeNotification status deserialize (#2111)
863f0f1 [azp]: Enable PR diff coverage (#2083)
bf4cd4a Fix the unsafe usage of strncpy in portsorch.cpp (#2110)
c1b4b40 support port isolation group in BFN platform (#1940)


Signed-off-by: Andriy Kokhan <[email protected]>
judyjoseph added a commit that referenced this pull request Jan 23, 2022
@judyjoseph
Update src/sonic-swss
0fb6c33 
ad65bd3 Fix the unsafe usage of strncpy in portsorch.cpp (#2110)
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this pull request Feb 5, 2022
@stephenxs
Fix the unsafe usage of strncpy in portsorch.cpp (sonic-net#2110)
bf4cd4a 
Originally, strncpy is used in the following way:
strncpy(attr.value.chardata, src_string, sizeof(attr.value.chardata));
where attr.value.chardata is a char array.

However, this is not safe in case strlen(src_string) >= sizeof(attr.value.chardata) because there will no space in attr.value.chardata to store the terminating character.
It will leave the string attr.value.chardata open, the receiver of attr cannot determine the end of the string and suffer buffer overflow.

According to SAI API definition, the actually length of SAI_HOSTIF_ATTR_NAME should be SAI_HOSTIF_NAME_SIZE - 1 which is less than sizeof(attr.value.chardata)`. So a safe way to do it should be:

strncpy(attr.value.chardata, src_string, SAI_HOSTIF_NAME_SIZE);
attr.value.chardata[SAI_HOSTIF_NAME_SIZE - 1] = '\0'

Signed-off-by: Stephen Sun <[email protected]>
stepanblyschak added a commit to stepanblyschak/sonic-buildimage that referenced this pull request Apr 22, 2022
@stepanblyschak
[sonic-utilities] submodule update
e734afa 
```
22a388b [show] fix get routing stack routine (sonic-net#2137)
cb3a047 Support option --ports of config qos reload for reloading ports' QoS and buffer configuration to default (sonic-net#2125)
154a801 Enhance "config interface type/advertised-type" to be blocked on RJ45 ports  (sonic-net#2112)
3732ac5 Add CLI for route flow counter feature (sonic-net#2031)
29771e7 [techsupport] improve robustness (sonic-net#2117)
f9dc681 [intfutil] Display RJ45 port and portchannel speed in 'M' instead of 'G' when it's <= 1000M (sonic-net#2110)
781ae9f [config] Do not enable pfcwd for BmcMgmtToRRouter (sonic-net#2136)
23e9398 [scripts/fast-reboot] Shutdown remaining containers through systemd (sonic-net#2133)
576c9ef [scripts/fast-reboot] stop timers in advance (sonic-net#2131)
4dad79c bugfix: incorrect command for portchannel creation (sonic-net#2134)
c17b1f4 [show][muxcable] Decrease the timeout for show mux status/hwmode (sonic-net#2130)
49d61f8 [scripts/fast-reboot] cleanup (sonic-net#2132)
52ca324 [config/config_mgmt.py]: Fix dpb issue with upper case mac in (sonic-net#2066)
9e2fbf4 Update db_migrator to support `pfcwd_sw_enable` (sonic-net#2087)
4010bd0 FGNHG CLI changes (sonic-net#1588)
6bd54d0 Fix 'show mac' output when FDB entry for default vlan is None instead of 1 (sonic-net#2126)
```

Signed-off-by: Stepan Blyschak <[email protected]>
@Junchao-Mellanox Junchao-Mellanox mentioned this pull request Apr 25, 2022
Merged
6 tasks
liat-grozovik pushed a commit that referenced this pull request May 12, 2022
@Junchao-Mellanox
[submodule] Advance sonic-utilities pointer (#10670)
9887e76 
288c2d8 Revert "[scripts/fast-reboot] Shutdown remaining containers through systemd (#2133)" (#2161)
bce4694 [autoneg] add support for remote speed advertisement (#2124)
a73f156 [show][vrf]Fixing show vrf to include vlan subinterface (#2158)
7a06457 [auto_ts] Enable register/de-register auto_ts config for APP Extension (#2139)
083ebcc Add transceiver-info items advertised for cmis-supported moddules (#2135)
0811214 Validate destination port is not LAG (#2053)
6ab1c51 [minigraph]  Consume golden_config_db.json while loading minigraph (#2140)
c37a957 [Kdump] Remove the duplicate logic if Kdump was disabled (#2128)
1143869 Ordering fix for sfpshow eeprom (#2113)
fdb79b8 Allow fw update for other boot type against on the previous "none" boot fw update (#2040)
a54a091 [GCU] Supressing YANG errors from libyang while sorting (#1991)
fbfa8bc [GCU] Enabling AddRack and adding RemoveRack tests (#2143)
d012be9 [Command-Reference] Add CLI docs for route flow counter (#2069)
8c07d59 [Mellanox] [reboot] [asan] stop asan-enabled containers on reboot (#2107)
697aae3 Fix speed parsing when speed is NOT fetched from APPL_DB (#2138)
22a388b [show] fix get routing stack routine (#2137)
cb3a047 Support option --ports of config qos reload for reloading ports' QoS and buffer configuration to default (#2125)
154a801 Enhance "config interface type/advertised-type" to be blocked on RJ45 ports  (#2112)
3732ac5 Add CLI for route flow counter feature (#2031)
29771e7 [techsupport] improve robustness (#2117)
f9dc681 [intfutil] Display RJ45 port and portchannel speed in 'M' instead of 'G' when it's <= 1000M (#2110)
781ae9f [config] Do not enable pfcwd for BmcMgmtToRRouter (#2136)
23e9398 [scripts/fast-reboot] Shutdown remaining containers through systemd (#2133)
576c9ef [scripts/fast-reboot] stop timers in advance (#2131)
4dad79c bugfix: incorrect command for portchannel creation (#2134)
c17b1f4 [show][muxcable] Decrease the timeout for show mux status/hwmode (#2130)
49d61f8 [scripts/fast-reboot] cleanup (#2132)
52ca324 [config/config_mgmt.py]: Fix dpb issue with upper case mac in (#2066)
9e2fbf4 Update db_migrator to support `pfcwd_sw_enable` (#2087)
4010bd0 FGNHG CLI changes (#1588)
6bd54d0 Fix 'show mac' output when FDB entry for default vlan is None instead of 1 (#2126)
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Jun 20, 2022
@yxieca
Merged PR 6148955: Manual merge internal branch with github master br…
a1e7352 
…anch

Related work items: #52, #71, #73, #75, #77, sonic-net#1306, sonic-net#1588, sonic-net#1991, sonic-net#2031, sonic-net#2040, sonic-net#2053, sonic-net#2066, sonic-net#2069, sonic-net#2087, sonic-net#2107, sonic-net#2110, sonic-net#2112, sonic-net#2113, sonic-net#2117, sonic-net#2124, sonic-net#2125, sonic-net#2126, sonic-net#2128, sonic-net#2130, sonic-net#2131, sonic-net#2132, sonic-net#2133, sonic-net#2134, sonic-net#2135, sonic-net#2136, sonic-net#2137, sonic-net#2138, sonic-net#2139, sonic-net#2140, sonic-net#2143, sonic-net#2158, sonic-net#2161, sonic-net#2233, sonic-net#2243, sonic-net#2250, sonic-net#2254, sonic-net#2260, sonic-net#2261, sonic-net#2267, sonic-net#2278, sonic-net#2282, sonic-net#2285, sonic-net#2288, sonic-net#2289, sonic-net#2292, sonic-net#2294, sonic-net#8887, sonic-net#9279, sonic-net#9390, sonic-net#9511, sonic-net#9700, sonic-net#10025, sonic-net#10322, sonic-net#10479, sonic-net#10484, sonic-net#10493, sonic-net#10500, sonic-net#10580, sonic-net#10595, sonic-net#10628, sonic-net#10634, sonic-net#10635, sonic-net#10644, sonic-net#10670, sonic-net#10691, sonic-net#10716, sonic-net#10731, sonic-net#10750, sonic-net#10751, sonic-net#10752, sonic-net#10761, sonic-net#10769, sonic-net#10775, sonic-net#10776, sonic-net#10779, sonic-net#10786, sonic-net#10792, sonic-net#10793, sonic-net#10800, sonic-net#10806, sonic-net#10826, sonic-net#10839, sonic-net#10840, sonic-net#10842, sonic-net#10844, sonic-net#10847, sonic-net#10849, sonic-net#10852, sonic-net#10865, sonic-net#10872, sonic-net#10877, sonic-net#10886, sonic-net#10889, sonic-net#10903, sonic-net#10904, sonic-net#10905, sonic-net#10913, sonic-net#10914, sonic-net#10916, sonic-net#10919, sonic-net#10925, sonic-net#10926, sonic-net#10929, sonic-net#10933, sonic-net#10934, sonic-net#10937, sonic-net#10941, sonic-net#10947, sonic-net#10952, sonic-net#10953, sonic-net#10957, sonic-net#10959, sonic-net#10971, sonic-net#10972, sonic-net#10980
vadymhlushko-mlnx pushed a commit to vadymhlushko-mlnx/sonic-buildimage that referenced this pull request Nov 11, 2022
@keboliu
[intfutil] Display RJ45 port and portchannel speed in 'M' instead of …
f9dc681 
…'G' when it's <= 1000M (sonic-net#2110)

* enhance port speed for RJ45 ports

Signed-off-by: Kebo Liu <[email protected]>

* fix speed notation for the speed of LAG port based on RJ45 ports

* on RJ45 ports display speed with unit 'M' when it's <= 1000M

Signed-off-by: Kebo Liu <[email protected]>
vadymhlushko-mlnx pushed a commit to vadymhlushko-mlnx/sonic-buildimage that referenced this pull request Nov 11, 2022
@keboliu
Fix speed parsing when speed is NOT fetched from APPL_DB (sonic-net#2138
697aae3 
)

- What I did
In PR sonic-net#2110 introduced an enhancement to support display port speed with different unit when it is RJ45 ports, however, it only covered the case that the speed was fetched from APPL_DB.
Recently there is a change to fetch the speed from STATE_DB in some cases, the same logic also needs to be applied in this case.

- How I did it
Rename appl_db_port_speed_parse to a more generic name port_speed_parse.
Call port_speed_parse when speed is fetched from STATE_DB.
In UT test, add port status entries to mocked STATE_DB to cover the logic that get port speed from STATE_DB.

- How to verify it
UT and test it on platform support RJ45 ports

Signed-off-by: Kebo Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lguohan lguohan lguohan approved these changes

Assignees

No one assigned

Labels

Enhancement ➕ Platform: Accton

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@roylee123 @lguohan @stcheng @pollyhsu2git