Update PDDF kernel modules with 5.10 kernel and fix some compilation …#9582
Merged
lguohan merged 3 commits intosonic-net:masterfrom Jan 3, 2022
Merged
Update PDDF kernel modules with 5.10 kernel and fix some compilation …#9582lguohan merged 3 commits intosonic-net:masterfrom
lguohan merged 3 commits intosonic-net:masterfrom
Conversation
Contributor
Author
|
/azp run Azure.sonic-buildimage |
|
Commenter does not have sufficient privileges for PR 9582 in repo Azure/sonic-buildimage |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
jostar-yang
previously approved these changes
Dec 21, 2021
Contributor
jostar-yang
left a comment
There was a problem hiding this comment.
The changes are ok to me.
Contributor
Author
|
/azp run Azure.sonic-buildimage |
|
Commenter does not have sufficient privileges for PR 9582 in repo Azure/sonic-buildimage |
Contributor
|
/azpw run |
geans-pin
previously approved these changes
Dec 21, 2021
f6c136c
geans-pin
previously approved these changes
Dec 22, 2021
jostar-yang
approved these changes
Dec 22, 2021
Contributor
jostar-yang
left a comment
There was a problem hiding this comment.
Th changes are fine to me.
jostar-yang
previously approved these changes
Dec 22, 2021
Contributor
jostar-yang
left a comment
There was a problem hiding this comment.
The change is fine to me.
525c5b0
4 tasks
seanwu-ec
pushed a commit
to seanwu-ec/sonic-buildimage
that referenced
this pull request
Jan 13, 2022
…ilation (sonic-net#9582) - Why I did it There were compilation errors and warnings like, /usr/src/linux-headers-5.10.0-8-2-common/scripts/Makefile.build:69: You cannot use subdir-y/m to visit a module Makefile. Use obj-y/m instead. fatal error: linux/platform_data/pca954x.h: No such file or directory hwmon_device_register() is deprecated. Please convert the driver to use hwmon_device_register_with_info(). If PDDF kernel module compilation fails, the PDDF debian package was not detecting the break. - How I did it Modified the code with new kernel 5.10 APIs. Modified the Makefiles to use 'obj-m' instead of 'subdir-y' - How to verify it PDDF is supported on Accton platform. Load the build on AS7326 setup and check the 'dmesg'
Contributor
Author
|
@prgeor @vdahiya12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…warnings
Why I did it
There were compilation errors and warnings like,
How I did it
How to verify it
Some logs are here,
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)