Skip to content

[pytest][cacl] Remove unused 'testbed_devices' from parameters#1689

Merged
jleveque merged 1 commit intosonic-net:masterfrom
jleveque:fix_cacl
May 20, 2020
Merged

[pytest][cacl] Remove unused 'testbed_devices' from parameters#1689
jleveque merged 1 commit intosonic-net:masterfrom
jleveque:fix_cacl

Conversation

@jleveque
Copy link
Contributor

@jleveque jleveque commented May 20, 2020

Bug was introduced in #1672.

@jleveque jleveque requested a review from lguohan May 20, 2020 17:27
@jleveque jleveque self-assigned this May 20, 2020
@jleveque jleveque merged commit 87f3a23 into sonic-net:master May 20, 2020
@jleveque jleveque deleted the fix_cacl branch May 20, 2020 17:42
shlomibitton pushed a commit to Junchao-Mellanox/sonic-mgmt that referenced this pull request Jul 12, 2020
Squashed commit of the following:
5e7f7a8 
commit d79d500
Author: Xin Wang <xiwang5@microsoft.com>
Date:   Sat May 23 11:31:48 2020 +0800

    Fix acl testing for new t1 routes (sonic-net#1688)

    The t1 and t1-lag routes have been changed after replacing static
    routes on VM with exabgp announced routes. This caused the acl
    testing failed. This PR is to fix this issue reported in sonic-net#1603.

    Changes:
    1. Update the acl rules template to use new IP addresses
    2. Update the acl script to use new IP addresses

    Signed-off-by: Xin Wang <xiwang5@microsoft.com>

commit c84e699
Author: yvolynets-mlnx <50697593+yvolynets-mlnx@users.noreply.github.com>
Date:   Sat May 23 04:41:19 2020 +0300

    [pytest/ntp] Minor fix for NTP test case. (sonic-net#1698)

    Added verification of 'wait_until' result, to easier understand test case failure reason.

    Signed-off-by: Yuriy Volynets <yuriyv@mellanox.com>

commit 441ddfa
Author: Vitaliy Senchyshyn <43479243+vsenchyshyn@users.noreply.github.com>
Date:   Sat May 23 00:40:02 2020 +0300

    [wr_arp][pytest] Fixed wr_arp test (sonic-net#1695)

    * [wr_arp] Fixed wr_arp test

    Signed-off-by: Vitaliy Senchyshyn <vsenchyshyn@barefootnetworks.com>

    * Make show ip protocol command working for different sonic images

    * Fixed review comments

    * Made records variable a class memeber

    * Fixed DIP taking from ip route show for sonic master

commit abdb746
Author: Xin Wang <xiwang5@microsoft.com>
Date:   Fri May 22 18:45:56 2020 +0800

    [pytest/fib]: Fix the issue of using wrong port announcing IPv6 routes (sonic-net#1697)

    I used wrong port for announcing IPv6 routes in PR sonic-net#1692. This PR is to fix that issue.

    Signed-off-by: Xin Wang <xiwang5@microsoft.com>

commit 9e52bba
Author: lguohan <lguohan@gmail.com>
Date:   Fri May 22 03:45:14 2020 -0700

    [pytest/snmp_cpu]: query nproc when ansible facts does not have vcpu info (sonic-net#1693)

    sometimes, ansible facts does not gather vcpu information. in this case, use nproc to query the cpu number directly.

    Signed-off-by: Guohan Lu <gulv@microsoft.com>

commit b175f8f
Author: yvolynets-mlnx <50697593+yvolynets-mlnx@users.noreply.github.com>
Date:   Fri May 22 02:49:30 2020 +0300

    [pytest/test_drop_counters.py] Fixed IGMP test case (sonic-net#1624)

    Signed-off-by: Yuriy Volynets <yuriyv@mellanox.com>

commit 208d02a
Author: Xin Wang <xiwang5@microsoft.com>
Date:   Fri May 22 00:23:19 2020 +0800

    Announce vips routes for bgp_multipath_relax testing (sonic-net#1692)

    Previously the vips routes were statically configured in the VMs for
    bgp_multipath_relax testing. After the change of announcing
    routes from exabgp in PTF to VMs, the vips routes were missing.
    The bgp_multipath_relax testing depends on the vips routes failed.

    This change is to announce the vips routes to VMs  that have the
    vips routes configuration. The functions in the fib fixture definition
    file were refactored a little bit.

    Signed-off-by: Xin Wang <xiwang5@microsoft.com>

commit 6d7498f
Author: yvolynets-mlnx <50697593+yvolynets-mlnx@users.noreply.github.com>
Date:   Thu May 21 11:38:08 2020 +0300

    Fixed fib tests: test_hash_ipv4/test_hash_ipv6 (sonic-net#1683)

    Fixes sonic-net#1679

    Signed-off-by: Yuriy Volynets <yuriyv@mellanox.com>

commit f17471c
Author: Neetha John <nejo@microsoft.com>
Date:   Wed May 20 15:53:44 2020 -0700

    Qos SAI test restructure (sonic-net#1682)

    * Qos SAI test restructure

    Signed-off-by: Neetha John <nejo@microsoft.com>

commit 87f3a23
Author: Joe LeVeque <jleveque@users.noreply.github.com>
Date:   Wed May 20 10:42:22 2020 -0700

    [pytest][cacl] Remove unused 'testbed_devices' from parameters (sonic-net#1689)

commit bd6e135
Author: Ying Xie <yxieca@users.noreply.github.com>
Date:   Wed May 20 08:11:55 2020 -0700

    [reload config] redirect reload config output to /dev/null (sonic-net#1687)

    config reload command will restart interface-config service, which
    will reset eth0. Which will reset the connection issues config
    reload if the output is coming to stdio/stderr. It in turn could
    cause the pytest to stuck for long time.

    Signed-off-by: Ying Xie <ying.xie@microsoft.com>

Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@yxieca
[202012][swss][utilities] advance submodule heads (sonic-net#7267)
4a54148 
SWSS:
* d97c7c7 2021-04-07 | [Dynamic Buffer Calc] Enhancement: coding style and LGTM alerts (sonic-net#1693) (HEAD -> 202012) [Stephen Sun]
* f70b3da 2021-04-03 | [Makefile] Reorder libsaimetadata and libswsscommon (sonic-net#1689) [Kamil Cudnik]
* 72ae85d 2021-04-08 | [vlan] Add support of VLAN host interface (sonic-net#1645) [Volodymyr Samotiy]
* a555b9c 2021-04-02 | Correct the sflow default sample rate (sonic-net#1623) [fredyu190011]

Utilities:
* 1a789d2 2021-04-07 | Fixed the possibility of using uninitialized variable in route_check.py (sonic-net#1551) (HEAD -> 202012) [Renuka Manavalan]
* 2412e3c 2021-04-06 | Fix fast-reboot-dump.py SonicV2Connector after late merge (sonic-net#1546) [shlomibitton]
* f99c5f1 2021-04-02 | [fast-reboot] Fix dump script to support PortChannels in a VLAN group (sonic-net#1393) [shlomibitton]
* 716e2af 2021-04-04 | Reduce time taken by show commands on multi-asic platforms (sonic-net#1544) [abdosi]
* a160519 2021-04-03 | [setup.py]: move the module to test requirement (sonic-net#1542) [lguohan]
* eaa67fe 2021-04-04 | [config] Eliminate race condition between reloading Monit config and (sonic-net#1543) [yozhao101]
* 2497a9e 2021-04-03 | [reboot] No need enable the Linux magic system request key (sonic-net#1538) [yozhao101]
* 9fda6fe 2021-04-06 | [fwutil]: Fix next image mount (sonic-net#1533) [Nazarii Hnydyn]
* 9af50fe 2021-02-09 | Import 'mock' module from 'unittest' library (sonic-net#1415) (HEAD -> 202012) [Joe LeVeque]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@judyjoseph
Update sonic-swss submodule with
dbcb55b 
88a38f7 Ignore ALREADY_EXIST error in FDB creation (sonic-net#1815)
b1c23f3 Change rif_rates.lua and port_rates.lua scripts to calculate rates correct (sonic-net#1848)

Update sonic-utilities submodule with

cbc25d6 [config reload] Call systemctl reset-failed for snmp,telemetry,mgmt-framework services (sonic-net#1773)
04dcd07 Improve config error handling on version_info (sonic-net#1760)
e567a60 Load the database global_db. (sonic-net#1752)
c15fb8f [sfputil] Gracefully handle improper 'specification_compliance' field (sonic-net#1741)
39350f8 [dhcp_relay] Update CLI reference document and add a new API for ip address type (sonic-net#1717)
18f13c6 [sonic-package-manager] switch from poetry-semver to semantic_version due to bugs found in poetry-semver (sonic-net#1710)
b16724a [voq][chassis] VOQ cli show commands implementation (sonic-net#1689)
9427cd6 [debug dump util] Match Infrastructure (sonic-net#1666)
d9fb39b [route_check] Filter out VNET routes (sonic-net#1612)
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@mssonicbld
[submodule] Update submodule sonic-sairedis to the latest HEAD automa…
ae51f20 
…tically (#24557)

#### Why I did it
src/sonic-sairedis
```
* ece94ef5 - (HEAD -> 202505, origin/202505) migrate agent pool sonicbld-arm64->sonicso1ES-arm64 and sonicbld-armhf->sonicso1ES-armhf for branch 202505 (sonic-net#1689) (11 days ago) [yijingyan2]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lguohan lguohan lguohan approved these changes

Assignees

@jleveque jleveque

Labels

Bug 🐛 Control Plane ACL Pytest 🐍

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jleveque @lguohan