[everflow] Deprecate ARP/ND test case#1666
Merged
daall merged 1 commit intosonic-net:masterfrom May 19, 2020
Merged
Conversation
Signed-off-by: Danny Allen <daall@microsoft.com>
|
This pull request fixes 3 alerts when merging cdbfa94 into 50a6bc1 - view on LGTM.com fixed alerts:
|
Contributor
|
@daall I think we should still keep Ingress Miroring test case for ARP/ND. wr_arp testcase i don't think does everflow type mirroring. I could not confirm that from the script |
Contributor
Author
Take a look at this script: https://github.com/Azure/sonic-utilities/blob/master/scripts/neighbor_advertiser This is what gets setup prior to warm reboot to mirror the ARP/ND packets while the device is rebooting. It's not as explicit as this test case, but it is the same scenario. |
abdosi
approved these changes
May 18, 2020
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
88a38f7 Ignore ALREADY_EXIST error in FDB creation (sonic-net#1815) b1c23f3 Change rif_rates.lua and port_rates.lua scripts to calculate rates correct (sonic-net#1848) Update sonic-utilities submodule with cbc25d6 [config reload] Call systemctl reset-failed for snmp,telemetry,mgmt-framework services (sonic-net#1773) 04dcd07 Improve config error handling on version_info (sonic-net#1760) e567a60 Load the database global_db. (sonic-net#1752) c15fb8f [sfputil] Gracefully handle improper 'specification_compliance' field (sonic-net#1741) 39350f8 [dhcp_relay] Update CLI reference document and add a new API for ip address type (sonic-net#1717) 18f13c6 [sonic-package-manager] switch from poetry-semver to semantic_version due to bugs found in poetry-semver (sonic-net#1710) b16724a [voq][chassis] VOQ cli show commands implementation (sonic-net#1689) 9427cd6 [debug dump util] Match Infrastructure (sonic-net#1666) d9fb39b [route_check] Filter out VNET routes (sonic-net#1612)
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…tically (#24300) #### Why I did it src/sonic-sairedis ``` * 4dbdc05c - (HEAD -> 202411, origin/202411) Revert "[meta] do not fail bulk operations if MODE_IGNORE_ERROR (sonic-net#1666)" (sonic-net#1677) (2 weeks ago) [Nikola Dancejic] * 92fcd342 - [meta] do not fail bulk operations if MODE_IGNORE_ERROR (sonic-net#1666) (3 weeks ago) [Nikola Dancejic] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Danny Allen daall@microsoft.com
Description of PR
Summary: Deprecates the ARP/ND mirroring test case for everflow.
Fixes #1399 (issue)
Type of change
Approach
How did you do it?
I deleted "test case 6" from the Everflow testbed. Per the discussion in #1399 the ingress functionality we were trying to test is already covered by the
wr_arptest case, and since we don't presently have a good use case for egress mirroring with these specific types of packets we no longer have a use for this test case.How did you verify/test it?
Ran the test suite, removing the test doesn't affect the other tests.
Documentation