Skip to content

[wr_arp][pytest] Fixed wr_arp test#1695

Merged
pavel-shirshov merged 5 commits intosonic-net:masterfrom
vsenchyshyn:wr-arp-fix
May 22, 2020
Merged

[wr_arp][pytest] Fixed wr_arp test#1695
pavel-shirshov merged 5 commits intosonic-net:masterfrom
vsenchyshyn:wr-arp-fix

Conversation

@vsenchyshyn
Copy link
Contributor

@vsenchyshyn vsenchyshyn commented May 21, 2020

Signed-off-by: Vitaliy Senchyshyn vsenchyshyn@barefootnetworks.com

Description of PR

Summary:
Fixes # (issue)
The test fails due to several reasons after migration to pytest.

Type of change

  • [ *] Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

How did you do it?

Use the proper "ip route show" command to get the DIP from the DUT.
Pass the correct path to scripts which have to be executed on PTF host.
Call testPort() function from the separate thread in PTF part so that the ARP packets can be generated while warm-reboot script is executed.

How did you verify/test it?

Run wr_arp test on BFN platform

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@vsenchyshyn
[wr_arp] Fixed wr_arp test
054a6eb 
Signed-off-by: Vitaliy Senchyshyn <vsenchyshyn@barefootnetworks.com>
@vsenchyshyn
Make show ip protocol command working for different sonic images
0b1eaaf
@vsenchyshyn
Copy link
Contributor Author

vsenchyshyn commented May 21, 2020

@yxieca @daall @tahmed-dev Please have a look

tahmed-dev
tahmed-dev suggested changes May 21, 2020
View reviewed changes
tahmed-dev
tahmed-dev suggested changes May 21, 2020
View reviewed changes
tahmed-dev
tahmed-dev suggested changes May 21, 2020
View reviewed changes
pavel-shirshov
pavel-shirshov approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@pavel-shirshov pavel-shirshov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please check my comments?
And also wait for Tamer's opinion

tahmed-dev
tahmed-dev approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@tahmed-dev tahmed-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your efforts!

@vsenchyshyn vsenchyshyn changed the title [wr_arp][pytest] Fixed wr_arp test [wr_arp][pytest] DON'T MERGE Fixed wr_arp test May 22, 2020
@vsenchyshyn vsenchyshyn changed the title [wr_arp][pytest] DON'T MERGE Fixed wr_arp test [wr_arp][pytest] Fixed wr_arp test May 22, 2020
@pavel-shirshov pavel-shirshov merged commit 441ddfa into sonic-net:master May 22, 2020
shlomibitton pushed a commit to Junchao-Mellanox/sonic-mgmt that referenced this pull request Jul 12, 2020
Squashed commit of the following:
5e7f7a8 
commit d79d500
Author: Xin Wang <xiwang5@microsoft.com>
Date:   Sat May 23 11:31:48 2020 +0800

    Fix acl testing for new t1 routes (sonic-net#1688)

    The t1 and t1-lag routes have been changed after replacing static
    routes on VM with exabgp announced routes. This caused the acl
    testing failed. This PR is to fix this issue reported in sonic-net#1603.

    Changes:
    1. Update the acl rules template to use new IP addresses
    2. Update the acl script to use new IP addresses

    Signed-off-by: Xin Wang <xiwang5@microsoft.com>

commit c84e699
Author: yvolynets-mlnx <50697593+yvolynets-mlnx@users.noreply.github.com>
Date:   Sat May 23 04:41:19 2020 +0300

    [pytest/ntp] Minor fix for NTP test case. (sonic-net#1698)

    Added verification of 'wait_until' result, to easier understand test case failure reason.

    Signed-off-by: Yuriy Volynets <yuriyv@mellanox.com>

commit 441ddfa
Author: Vitaliy Senchyshyn <43479243+vsenchyshyn@users.noreply.github.com>
Date:   Sat May 23 00:40:02 2020 +0300

    [wr_arp][pytest] Fixed wr_arp test (sonic-net#1695)

    * [wr_arp] Fixed wr_arp test

    Signed-off-by: Vitaliy Senchyshyn <vsenchyshyn@barefootnetworks.com>

    * Make show ip protocol command working for different sonic images

    * Fixed review comments

    * Made records variable a class memeber

    * Fixed DIP taking from ip route show for sonic master

commit abdb746
Author: Xin Wang <xiwang5@microsoft.com>
Date:   Fri May 22 18:45:56 2020 +0800

    [pytest/fib]: Fix the issue of using wrong port announcing IPv6 routes (sonic-net#1697)

    I used wrong port for announcing IPv6 routes in PR sonic-net#1692. This PR is to fix that issue.

    Signed-off-by: Xin Wang <xiwang5@microsoft.com>

commit 9e52bba
Author: lguohan <lguohan@gmail.com>
Date:   Fri May 22 03:45:14 2020 -0700

    [pytest/snmp_cpu]: query nproc when ansible facts does not have vcpu info (sonic-net#1693)

    sometimes, ansible facts does not gather vcpu information. in this case, use nproc to query the cpu number directly.

    Signed-off-by: Guohan Lu <gulv@microsoft.com>

commit b175f8f
Author: yvolynets-mlnx <50697593+yvolynets-mlnx@users.noreply.github.com>
Date:   Fri May 22 02:49:30 2020 +0300

    [pytest/test_drop_counters.py] Fixed IGMP test case (sonic-net#1624)

    Signed-off-by: Yuriy Volynets <yuriyv@mellanox.com>

commit 208d02a
Author: Xin Wang <xiwang5@microsoft.com>
Date:   Fri May 22 00:23:19 2020 +0800

    Announce vips routes for bgp_multipath_relax testing (sonic-net#1692)

    Previously the vips routes were statically configured in the VMs for
    bgp_multipath_relax testing. After the change of announcing
    routes from exabgp in PTF to VMs, the vips routes were missing.
    The bgp_multipath_relax testing depends on the vips routes failed.

    This change is to announce the vips routes to VMs  that have the
    vips routes configuration. The functions in the fib fixture definition
    file were refactored a little bit.

    Signed-off-by: Xin Wang <xiwang5@microsoft.com>

commit 6d7498f
Author: yvolynets-mlnx <50697593+yvolynets-mlnx@users.noreply.github.com>
Date:   Thu May 21 11:38:08 2020 +0300

    Fixed fib tests: test_hash_ipv4/test_hash_ipv6 (sonic-net#1683)

    Fixes sonic-net#1679

    Signed-off-by: Yuriy Volynets <yuriyv@mellanox.com>

commit f17471c
Author: Neetha John <nejo@microsoft.com>
Date:   Wed May 20 15:53:44 2020 -0700

    Qos SAI test restructure (sonic-net#1682)

    * Qos SAI test restructure

    Signed-off-by: Neetha John <nejo@microsoft.com>

commit 87f3a23
Author: Joe LeVeque <jleveque@users.noreply.github.com>
Date:   Wed May 20 10:42:22 2020 -0700

    [pytest][cacl] Remove unused 'testbed_devices' from parameters (sonic-net#1689)

commit bd6e135
Author: Ying Xie <yxieca@users.noreply.github.com>
Date:   Wed May 20 08:11:55 2020 -0700

    [reload config] redirect reload config output to /dev/null (sonic-net#1687)

    config reload command will restart interface-config service, which
    will reset eth0. Which will reset the connection issues config
    reload if the output is coming to stdio/stderr. It in turn could
    cause the pytest to stuck for long time.

    Signed-off-by: Ying Xie <ying.xie@microsoft.com>

Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msosyak msosyak msosyak left review comments

+2 more reviewers

@pavel-shirshov pavel-shirshov pavel-shirshov approved these changes

@tahmed-dev tahmed-dev tahmed-dev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vsenchyshyn @pavel-shirshov @msosyak @tahmed-dev