[reboot] ignore module failure when checking SSH port status#1815
Merged
yxieca merged 2 commits intosonic-net:masterfrom Jun 25, 2020
Merged
[reboot] ignore module failure when checking SSH port status#1815yxieca merged 2 commits intosonic-net:masterfrom
yxieca merged 2 commits intosonic-net:masterfrom
Conversation
Without ignoring module failures, any command failure would be translated into exception. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Collaborator
Author
|
retest vsimage please |
Some platform takes marginally longer time to finish warm reboot. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
stepanblyschak
approved these changes
Jun 25, 2020
Collaborator
Author
|
retest vsimage please |
neethajohn
approved these changes
Jun 25, 2020
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
* d03ba4f [202012] [portstat, intfstat] added rates and utilization (sonic-net#1812) * 499ad3f [config reload] Fix config reload failure due to sonic.target job cancellation (sonic-net#1814) * 96d658c [202012][sonic installer] Add swap setup support (sonic-net#1815) * a9c6970 platform pre-check for reboot in 202012 branch (sonic-net#1788) * 0e0478b Unify the number format in the ourput of portstat and pfcstat in all cases (sonic-net#1795) * 2d1e00e [ecnconfig] Fix exception seen during display and add unit tests (#1784) (sonic-net#1789) Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
88a38f7 Ignore ALREADY_EXIST error in FDB creation (sonic-net#1815) b1c23f3 Change rif_rates.lua and port_rates.lua scripts to calculate rates correct (sonic-net#1848) Update sonic-utilities submodule with cbc25d6 [config reload] Call systemctl reset-failed for snmp,telemetry,mgmt-framework services (sonic-net#1773) 04dcd07 Improve config error handling on version_info (sonic-net#1760) e567a60 Load the database global_db. (sonic-net#1752) c15fb8f [sfputil] Gracefully handle improper 'specification_compliance' field (sonic-net#1741) 39350f8 [dhcp_relay] Update CLI reference document and add a new API for ip address type (sonic-net#1717) 18f13c6 [sonic-package-manager] switch from poetry-semver to semantic_version due to bugs found in poetry-semver (sonic-net#1710) b16724a [voq][chassis] VOQ cli show commands implementation (sonic-net#1689) 9427cd6 [debug dump util] Match Infrastructure (sonic-net#1666) d9fb39b [route_check] Filter out VNET routes (sonic-net#1612)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
Reboot test has been failing recently.
How did you do it?
Without ignoring module failures, any command failure would be translated into exception.
Signed-off-by: Ying Xie ying.xie@microsoft.com
How did you verify/test it?
Reboot test was failing waiting for switch to reboot or come back without this change. With this change. Reboot test made further progress:
(warm reboot test issue was addressed in second commit. watchdog reboot test failed due to image issue on the platform I ran test on).
============================================================================================= test session starts =============================================================================================
platform linux2 -- Python 2.7.12, pytest-4.6.5, py-1.8.1, pluggy-0.13.1
ansible: 2.8.7
rootdir: /var/src/sonic-mgmt/tests, inifile: pytest.ini
plugins: ansible-2.2.2, xdist-1.28.0, forked-1.1.3, repeat-0.8.0
collected 7 items
platform_tests/test_reboot.py::test_cold_reboot PASSED [ 14%]
platform_tests/test_reboot.py::test_fast_reboot PASSED [ 28%]
platform_tests/test_reboot.py::test_warm_reboot FAILED [ 42%]
platform_tests/test_reboot.py::test_power_off_reboot[15] SKIPPED [ 57%]
platform_tests/test_reboot.py::test_power_off_reboot[5] SKIPPED [ 71%]
platform_tests/test_reboot.py::test_watchdog_reboot FAILED [ 85%]
platform_tests/test_reboot.py::test_continuous_reboot PASSED [100%]
================================================================================================== FAILURES ===================================================================================================