Fix acl testing for new t1 routes#1688
Merged
wangxin merged 1 commit intosonic-net:masterfrom May 23, 2020
wangxin:acl-topo-fix-pr
Merged
Fix acl testing for new t1 routes#1688wangxin merged 1 commit intosonic-net:masterfrom wangxin:acl-topo-fix-pr
wangxin merged 1 commit intosonic-net:masterfrom
wangxin:acl-topo-fix-pr
Conversation
The t1 and t1-lag routes have been changed after replacing static routes on VM with exabgp announced routes. This caused the acl testing failed. This PR is to fix this issue reported in #1603. Changes: 1. Update the acl rules template to use new IP addresses 2. Update the acl script to use new IP addresses Signed-off-by: Xin Wang <[email protected]>
stepanblyschak
approved these changes
May 22, 2020
shlomibitton
pushed a commit
to Junchao-Mellanox/sonic-mgmt
that referenced
this pull request
Jul 12, 2020
commit d79d500 Author: Xin Wang <[email protected]> Date: Sat May 23 11:31:48 2020 +0800 Fix acl testing for new t1 routes (sonic-net#1688) The t1 and t1-lag routes have been changed after replacing static routes on VM with exabgp announced routes. This caused the acl testing failed. This PR is to fix this issue reported in sonic-net#1603. Changes: 1. Update the acl rules template to use new IP addresses 2. Update the acl script to use new IP addresses Signed-off-by: Xin Wang <[email protected]> commit c84e699 Author: yvolynets-mlnx <[email protected]> Date: Sat May 23 04:41:19 2020 +0300 [pytest/ntp] Minor fix for NTP test case. (sonic-net#1698) Added verification of 'wait_until' result, to easier understand test case failure reason. Signed-off-by: Yuriy Volynets <[email protected]> commit 441ddfa Author: Vitaliy Senchyshyn <[email protected]> Date: Sat May 23 00:40:02 2020 +0300 [wr_arp][pytest] Fixed wr_arp test (sonic-net#1695) * [wr_arp] Fixed wr_arp test Signed-off-by: Vitaliy Senchyshyn <[email protected]> * Make show ip protocol command working for different sonic images * Fixed review comments * Made records variable a class memeber * Fixed DIP taking from ip route show for sonic master commit abdb746 Author: Xin Wang <[email protected]> Date: Fri May 22 18:45:56 2020 +0800 [pytest/fib]: Fix the issue of using wrong port announcing IPv6 routes (sonic-net#1697) I used wrong port for announcing IPv6 routes in PR sonic-net#1692. This PR is to fix that issue. Signed-off-by: Xin Wang <[email protected]> commit 9e52bba Author: lguohan <[email protected]> Date: Fri May 22 03:45:14 2020 -0700 [pytest/snmp_cpu]: query nproc when ansible facts does not have vcpu info (sonic-net#1693) sometimes, ansible facts does not gather vcpu information. in this case, use nproc to query the cpu number directly. Signed-off-by: Guohan Lu <[email protected]> commit b175f8f Author: yvolynets-mlnx <[email protected]> Date: Fri May 22 02:49:30 2020 +0300 [pytest/test_drop_counters.py] Fixed IGMP test case (sonic-net#1624) Signed-off-by: Yuriy Volynets <[email protected]> commit 208d02a Author: Xin Wang <[email protected]> Date: Fri May 22 00:23:19 2020 +0800 Announce vips routes for bgp_multipath_relax testing (sonic-net#1692) Previously the vips routes were statically configured in the VMs for bgp_multipath_relax testing. After the change of announcing routes from exabgp in PTF to VMs, the vips routes were missing. The bgp_multipath_relax testing depends on the vips routes failed. This change is to announce the vips routes to VMs that have the vips routes configuration. The functions in the fib fixture definition file were refactored a little bit. Signed-off-by: Xin Wang <[email protected]> commit 6d7498f Author: yvolynets-mlnx <[email protected]> Date: Thu May 21 11:38:08 2020 +0300 Fixed fib tests: test_hash_ipv4/test_hash_ipv6 (sonic-net#1683) Fixes sonic-net#1679 Signed-off-by: Yuriy Volynets <[email protected]> commit f17471c Author: Neetha John <[email protected]> Date: Wed May 20 15:53:44 2020 -0700 Qos SAI test restructure (sonic-net#1682) * Qos SAI test restructure Signed-off-by: Neetha John <[email protected]> commit 87f3a23 Author: Joe LeVeque <[email protected]> Date: Wed May 20 10:42:22 2020 -0700 [pytest][cacl] Remove unused 'testbed_devices' from parameters (sonic-net#1689) commit bd6e135 Author: Ying Xie <[email protected]> Date: Wed May 20 08:11:55 2020 -0700 [reload config] redirect reload config output to /dev/null (sonic-net#1687) config reload command will restart interface-config service, which will reset eth0. Which will reset the connection issues config reload if the output is coming to stdio/stderr. It in turn could cause the pytest to stuck for long time. Signed-off-by: Ying Xie <[email protected]> Signed-off-by: Stepan Blyschak <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The t1 and t1-lag routes have been changed after replacing static
routes on VM with exabgp announced routes. This caused the acl
testing failed. This PR is to fix this issue reported in #1603.
Description of PR
Summary:
Fixes #1603
Type of change
Approach
How did you do it?
How did you verify/test it?
Test run the test_acl.py script.
Any platform specific information?
Some platform may not support egress ACL. On these platforms, the egress ACL testing can be skipped using pytest argument
-k ingressor-k "not egress"Supported testbed topology if it's a new test case?
Documentation