Announce vips routes for bgp_multipath_relax testing

[wangxin]

Description of PR

Summary:
Fixes #1587

Previously the vips routes were statically configured in the VMs for
bgp_multipath_relax testing. After the change of announcing
routes from exabgp in PTF to VMs, the vips routes were missing.
The bgp_multipath_relax testing depends on the vips routes failed.

This change is to announce the vips routes to VMs that have the
vips routes configuration. The functions in the fib fixture definition
file were refactored a little bit.

Type of change

• Bug fix
• Testbed and Framework(new/improvement)
• Test case(new/improvement)

Approach

How did you do it?

Updated the fib fixture to announce vips routes to VMs that have this configuration in topology definition.

How did you verify/test it?

• Run the test_announce_routes.py to announce all the routes.
• Run the bgp_multipath_relax ansible test. It passed.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

[lgtm-com]

This pull request introduces 2 alerts when merging a2b4fc7 into f17471c - view on LGTM.com

new alerts:

• 2 for Unused local variable

[lguohan]

I am not sure we want to advertise to every tor about the vip. I remember topology has information which tor needs to advertise the vip.

[wangxin]

This will not advertise to every tor. It will only advertise to tor VMs that have configuration "vips" in topology definition file.

For example, in ansible/vars/topo_t1-lag.yml, only two VMs have the "vips" configuration: ARISTA01T0, ARISTA03T0.

  ARISTA01T0:
    properties:
    - common
    - tor
    tornum: 1
    bgp:
      asn: 64001
      peers:
        65100:
        - 10.0.0.32
        - FC00::41
    interfaces:
      Loopback0:
        ipv4: 100.1.0.17/32
        ipv6: 2064:100::11/128
      Ethernet1:
        ipv4: 10.0.0.33/31
        ipv6: fc00::42/126
    bp_interface:
      ipv4: 10.10.246.17/24
      ipv6: fc0a::22/64
    vips:
      ipv4:
        prefixes:
           - 200.0.1.0/26
        asn: 64700

  ARISTA03T0:
    properties:
    - common
    - tor
    tornum: 3
    bgp:
      asn: 64003
      peers:
        65100:
        - 10.0.0.36
        - FC00::49
    interfaces:
      Loopback0:
        ipv4: 100.1.0.19/32
        ipv6: 2064:100::13/128
      Ethernet1:
        ipv4: 10.0.0.37/31
        ipv6: fc00::4a/126
    bp_interface:
      ipv4: 10.10.246.19/24
      ipv6: fc0a::26/64
    vips:
      ipv4:
        prefixes:
          - 200.0.1.0/26
        asn: 64700

The vips routes will only be advertised to these two tor VMs.