Skip to content

initial spytest upstream#1533

Merged
yxieca merged 1 commit intosonic-net:masterfrom
ramakristipati:spytest
Apr 3, 2020
Merged

initial spytest upstream#1533
yxieca merged 1 commit intosonic-net:masterfrom
ramakristipati:spytest

Conversation

@ramakristipati
Copy link
Contributor

@ramakristipati ramakristipati commented Apr 3, 2020 •
edited
Loading

Signed-off-by: Rama Sasthri, Kristipati rama.kristipati@broadcom.com

Description of PR

This is initial check-in of spytest framework and first set of test scripts

Summary:
New Feature

Type of chang

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

How did you do it?

used pytest as base and add needed feature on top of it
developed test scripts to excercise sonic features like port, vlan, portchannel, ARP etc

How did you verify/test it?

Executed test scripts against sonic daily build

  PassRate Executed PassCount TimeTaken SysLogs EnvFailRate SkippedRate CDT
Regression 91.43% 105 96 1:55:49 0 0.00% 0.00% 7:43:16
==== TOTAL ==== 91.43% 105 96 1:55:49 0 0.00% 0.00% 7:43:16
  PassRate SysLogs CDT FCLI TSSH DCNT Functions PrologTime EpilogTime FuncTime ExecTime PASS FAIL ENVFAIL SCRIPTERROR DEPFAIL CONFIGFAIL SKIPPED TIMEOUT TOPOFAIL TGENFAIL DUTFAIL UNSUPPORTED
system/test_ssh.py 100.00% 0 0:10:56 0 0 4 1 0:02:27 0:00:08 0:00:09 0:02:44 1 0 0 0 0 0 0 0 0 0 0 0
system/test_box_services.py 100.00% 0 0:13:08 0 0 4 1 0:02:07 0:00:00 0:01:10 0:03:17 1 0 0 0 0 0 0 0 0 0 0 0
system/test_ntp.py 0.00% 0 0:15:44 0 0 4 1 0:02:35 0:00:01 0:01:20 0:03:56 0 1 0 0 0 0 0 0 0 0 0 0
routing/BGP/test_bgp_4node.py 100.00% 0 0:17:12 0 0 4 3 0:02:36 0:00:22 0:01:20 0:04:18 3 0 0 0 0 0 0 0 0 0 0 0
security/test_tacacs.py 100.00% 0 0:17:24 0 0 4 3 0:02:23 0:00:20 0:01:38 0:04:21 3 0 0 0 0 0 0 0 0 0 0 0
routing/test_ip.py 100.00% 0 0:18:56 0 0 4 2 0:02:51 0:00:54 0:00:59 0:04:44 2 0 0 0 0 0 0 0 0 0 0 0
routing/test_arp.py 0.00% 0 0:22:08 0 0 4 1 0:02:37 0:00:08 0:02:47 0:05:32 0 1 0 0 0 0 0 0 0 0 0 0
system/test_device_mgmt.py 100.00% 0 0:22:08 0 0 4 1 0:05:03 0:00:01 0:00:28 0:05:32 1 0 0 0 0 0 0 0 0 0 0 0
system/test_lldp.py 100.00% 0 0:25:04 0 0 4 9 0:04:28 0:00:22 0:01:26 0:06:16 9 0 0 0 0 0 0 0 0 0 0 0
switching/test_portchannel.py 50.00% 0 0:35:16 0 0 4 2 0:04:16 0:00:18 0:04:15 0:08:49 1 1 0 0 0 0 0 0 0 0 0 0
sanity/test_sanity_l2.py 100.00% 0 0:42:32 0 0 4 4 0:02:11 0:00:01 0:08:26 0:10:38 4 0 0 0 0 0 0 0 0 0 0 0
routing/BGP/test_bgp.py 100.00% 0 0:56:56 0 0 4 19 0:06:48 0:01:10 0:06:16 0:14:14 19 0 0 0 0 0 0 0 0 0 0 0
qos/test_qos_save_reboot.py 100.00% 0 1:21:12 0 0 4 1 0:16:24 0:00:03 0:03:51 0:20:18 1 0 0 0 0 0 0 0 0 0 0 0
system/test_snmp.py 88.24% 0 1:25:36 0 0 4 17 0:15:57 0:00:29 0:04:58 0:21:24 15 1 0 0 0 0 0 0 0 0 1 0
==== TOTAL ==== 92.31% 0 7:44:12 0 0 56 65 1:12:43 0:04:17 0:39:03 1:56:03 60 4 0 0 0 0 0 0 0 0 1 0

Any platform specific information?

None

Supported testbed topology if it's a new test case?

PTF

Documentation

TODO

@ramakristipatibrcm
initial spytest upstream
5579a06 
Signed-off-by: Rama Sasthri, Kristipati <rama.kristipati@broadcom.com>
@msftclas
Copy link

msftclas commented Apr 3, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@yxieca yxieca self-requested a review April 3, 2020 16:02
@lgtm-com
Copy link

lgtm-com bot commented Apr 3, 2020

This pull request introduces 402 alerts when merging 5579a06 into edc1d5c - view on LGTM.com

new alerts:

  • 174 for Except block handles 'BaseException'
  • 118 for Unused local variable
  • 30 for Testing equality to None
  • 26 for Unreachable code
  • 18 for Variable defined multiple times
  • 5 for Non-iterable used in for loop
  • 4 for Use of the return value of a procedure
  • 4 for Modification of parameter with default
  • 4 for Result of integer division may be truncated
  • 3 for Nested loops with same variable
  • 3 for Insecure temporary file
  • 2 for Membership test with a non-container
  • 2 for Unused argument in a formatting call
  • 1 for Too few arguments in formatting call
  • 1 for Module is imported more than once
  • 1 for Non-callable called
  • 1 for Unused import
  • 1 for Suspicious unused loop iteration variable
  • 1 for Module is imported with 'import' and 'import from'
  • 1 for Use of 'global' at module level
  • 1 for Wrong number of arguments in a call
  • 1 for __init__ method calls overridden method

@yxieca
Copy link
Collaborator

yxieca commented Apr 3, 2020

@ramakristipati Please create subsequent PRs to address the LGTM alerts.

@yxieca yxieca merged commit f3b4e51 into sonic-net:master Apr 3, 2020
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@yxieca
[202012][swss][utilities] advance submodule heads (sonic-net#7267)
4a54148 
SWSS:
* d97c7c7 2021-04-07 | [Dynamic Buffer Calc] Enhancement: coding style and LGTM alerts (sonic-net#1693) (HEAD -> 202012) [Stephen Sun]
* f70b3da 2021-04-03 | [Makefile] Reorder libsaimetadata and libswsscommon (sonic-net#1689) [Kamil Cudnik]
* 72ae85d 2021-04-08 | [vlan] Add support of VLAN host interface (sonic-net#1645) [Volodymyr Samotiy]
* a555b9c 2021-04-02 | Correct the sflow default sample rate (sonic-net#1623) [fredyu190011]

Utilities:
* 1a789d2 2021-04-07 | Fixed the possibility of using uninitialized variable in route_check.py (sonic-net#1551) (HEAD -> 202012) [Renuka Manavalan]
* 2412e3c 2021-04-06 | Fix fast-reboot-dump.py SonicV2Connector after late merge (sonic-net#1546) [shlomibitton]
* f99c5f1 2021-04-02 | [fast-reboot] Fix dump script to support PortChannels in a VLAN group (sonic-net#1393) [shlomibitton]
* 716e2af 2021-04-04 | Reduce time taken by show commands on multi-asic platforms (sonic-net#1544) [abdosi]
* a160519 2021-04-03 | [setup.py]: move the module to test requirement (sonic-net#1542) [lguohan]
* eaa67fe 2021-04-04 | [config] Eliminate race condition between reloading Monit config and (sonic-net#1543) [yozhao101]
* 2497a9e 2021-04-03 | [reboot] No need enable the Linux magic system request key (sonic-net#1538) [yozhao101]
* 9fda6fe 2021-04-06 | [fwutil]: Fix next image mount (sonic-net#1533) [Nazarii Hnydyn]
* 9af50fe 2021-02-09 | Import 'mock' module from 'unittest' library (sonic-net#1415) (HEAD -> 202012) [Joe LeVeque]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@richardyu-ms
[202205][sairedis]advance submodule head (sonic-net#11861)
921b040 
update sai module with commit

- 566d4a8ef2 2022-08-11 | [SAI-PTF] Enable saiserverv2 with syncd-rpc and fix saithriftv2 build (sonic-net#1552) (sonic-net#1533) (sonic-net#1514) (sonic-net#1492) (sonic-net#1558) (sonic-net#1557) [Richard.Yu]
- a1796a53cc 2022-08-11 | Add support of mdio IPC server class using sai switch api and unix socket

Signed-off-by: richardyu-ms <richard.yu@microsoft.com>

Signed-off-by: richardyu-ms <richard.yu@microsoft.com>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@mssonicbld
[submodule] Update submodule sonic-sairedis to the latest HEAD automa…
a28a722 
…tically (sonic-net#21773)

#### Why I did it
src/sonic-sairedis
```
* ec8b3c30 - (HEAD -> 202411, origin/202411) Fix pipeline errors related to rsyslogd and libswsscommon installation (sonic-net#1535) (16 hours ago) [mssonicbld]
* 6b263b8e - [FC] Support Policer Counter (sonic-net#1533) (28 hours ago) [mssonicbld]
* e53489e5 - [syncd] Update log level for bulk api (sonic-net#1532) (33 hours ago) [Jianyue Wu]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yxieca yxieca yxieca approved these changes

Assignees

No one assigned

Labels

Enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ramakristipati @msftclas @yxieca @ramakristipatibrcm