Create pytest version of control plane ACL test#1672
Create pytest version of control plane ACL test#1672jleveque merged 5 commits intosonic-net:masterfrom jleveque:ctrl_plne_acl_pytest
Conversation
|
This pull request introduces 1 alert when merging 26934f0 into f11d076 - view on LGTM.com new alerts:
|
|
I do not remember if this test was developed in the service acl stage where we can have different implementation of the control plane acl. Now, since we have been using iptables to manage the control plane acl, and you have added many different rules. I would suggest to develop a new test which is comparing the iptables actual and expected output. people trust iptables implementation nowadays. as long as you have correct iptable rules, we believe it will behave correctly. |
Yes, you are correct, it was.
OK. So we should merge this PR as-is to retain the same functionality, then I can later update the test to simply verify the iptables rules are as expected. |
…or 202012 (sonic-net#7105) sonic-swss * [nbrmgrd] added function to parse IP address from APP_DB (sonic-net#1672) * [MUX/PFCWD] Use in_ports for acls instead of seperate ACL table (sonic-net#1670) * [mux] VS test for neigh, route and fdb (sonic-net#1656) * [Dynamic buffer calc] Bug fix: Remove PGs from an administratively down port. (sonic-net#1652) * spell check fixes (sonic-net#1630) sonic-utilities * [reboot]: Stop mux before reboot on dual ToR (sonic-net#1500) * [config] Disable/enable container monitoring when stopping/starting services (sonic-net#1499) * Add 'show' and 'clear' command for PG drop (sonic-net#1461) * [CLI][techsupport] Add NOOP option for commands that did not have that option (sonic-net#1445) * [202012][reload] Improve reload by using sonic.target (sonic-net#1509) Signed-off-by: Danny Allen <[email protected]>
3 participants
Create pytest version of control plane ACL test.