Skip to content

[pytest] Convert FDB MAC Expire Test#1741

Merged
tahmed-dev merged 2 commits intosonic-net:masterfrom
tahmed-dev:taahme/convert-fdb-mac-expire
Jun 12, 2020
Merged

[pytest] Convert FDB MAC Expire Test#1741
tahmed-dev merged 2 commits intosonic-net:masterfrom
tahmed-dev:taahme/convert-fdb-mac-expire

Conversation

@tahmed-dev
Copy link
Contributor

@tahmed-dev tahmed-dev commented Jun 5, 2020 •
edited
Loading

Description of PR

Summary:
Convert FDB MAC expire test from Ansible to pytest.

signed-off-by: Tamer Ahmed tamer.ahmed@microsoft.com

Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

tests$ pytest fdb/test_fdb_mac_expire.py --testbed=vms12-t0-s6000-1 --inventory=../ansible/str --testbed_file=../ansible/testbed.csv --host-pattern=str-s6000-acs-14 --module-path=../ansible/library --disable_loganalyzer
================================================================================================================================================== test session starts ===================================================================================================================================================
platform linux2 -- Python 2.7.12, pytest-4.6.9, py-1.8.1, pluggy-0.13.1
ansible: 2.8.7
rootdir: /var/host-acs-mgmt-repo/tests, inifile: pytest.ini
plugins: ansible-2.2.2
collected 1 item                                                                                                                                                                                                                                                                                                         

fdb/test_fdb_mac_expire.py .                                                                                                                                                                                                                                                                                       [100%]

========================================================================================================================================= 1 passed, 1 warnings in 218.94 seconds =========================================================================================================================================

and

tests$ pytest fdb/test_fdb_mac_expire.py --testbed=vms2-2-t0-2700 --inventory=../ansible/str --testbed_file=../ansible/testbed.csv --host-pattern=str-msn2700-20 --module-path=../ansible/library --disable_loganalyzer
================================================================================================================================================== test session starts ==================================================================================================================================================
platform linux2 -- Python 2.7.12, pytest-4.6.9, py-1.8.1, pluggy-0.13.1
ansible: 2.8.7
rootdir: /var/host-acs-mgmt-repo/tests, inifile: pytest.ini
plugins: ansible-2.2.2
collected 1 item                                                                                                                                                                                                                                                                                                        

fdb/test_fdb_mac_expire.py .                                                                                                                                                                                                                                                                                      [100%]

======================================================================================================================================== 1 passed, 1 warnings in 206.10 seconds =========================================================================================================================================

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

yxieca
yxieca reviewed Jun 8, 2020
View reviewed changes
yxieca
yxieca reviewed Jun 8, 2020
View reviewed changes
yxieca
yxieca reviewed Jun 8, 2020
View reviewed changes
@tahmed-dev tahmed-dev force-pushed the taahme/convert-fdb-mac-expire branch from 5f59c2e to ff64b43 Compare June 8, 2020 18:16
@svc-acs
Copy link
Collaborator

svc-acs commented Jun 8, 2020

Build triggered for merge commit.

@svc-acs
Copy link
Collaborator

svc-acs commented Jun 8, 2020

Build started for merge commit.

@tahmed-dev tahmed-dev requested a review from yxieca June 8, 2020 18:18
@daall
Copy link
Contributor

daall commented Jun 8, 2020

retest vsimage please

@daall
Copy link
Contributor

daall commented Jun 8, 2020

retest vsimage please

wangxin
wangxin reviewed Jun 10, 2020
View reviewed changes
@tahmed-dev tahmed-dev force-pushed the taahme/convert-fdb-mac-expire branch from ff64b43 to 446c303 Compare June 10, 2020 19:06
@tahmed-dev
Relocate fdb.j2 from Ansible to Pytest
992db05
@tahmed-dev
[pytest] Convert FDB MAC Expire Test
a46e8c3 
Convert FDB MAC expire test from Ansible to pytest.

signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
@tahmed-dev tahmed-dev force-pushed the taahme/convert-fdb-mac-expire branch from 446c303 to a46e8c3 Compare June 11, 2020 23:54
@tahmed-dev tahmed-dev merged commit 3a57da8 into sonic-net:master Jun 12, 2020
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@judyjoseph
Update sonic-swss submodule with
dbcb55b 
88a38f7 Ignore ALREADY_EXIST error in FDB creation (sonic-net#1815)
b1c23f3 Change rif_rates.lua and port_rates.lua scripts to calculate rates correct (sonic-net#1848)

Update sonic-utilities submodule with

cbc25d6 [config reload] Call systemctl reset-failed for snmp,telemetry,mgmt-framework services (sonic-net#1773)
04dcd07 Improve config error handling on version_info (sonic-net#1760)
e567a60 Load the database global_db. (sonic-net#1752)
c15fb8f [sfputil] Gracefully handle improper 'specification_compliance' field (sonic-net#1741)
39350f8 [dhcp_relay] Update CLI reference document and add a new API for ip address type (sonic-net#1717)
18f13c6 [sonic-package-manager] switch from poetry-semver to semantic_version due to bugs found in poetry-semver (sonic-net#1710)
b16724a [voq][chassis] VOQ cli show commands implementation (sonic-net#1689)
9427cd6 [debug dump util] Match Infrastructure (sonic-net#1666)
d9fb39b [route_check] Filter out VNET routes (sonic-net#1612)
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@richardyu-ms
[202211][submodule]Advance sairedis head (sonic-net#13712)
422978c 
Why I did it
include changes from sairedis submodule
102d20b | [202211][submodule][SAI]Advance header include 0031470 | improve enum values integration check (sonic-net#1727) (sonic-net#1737)
04d3c41 | [Submodule][upgrade]Upgrade SAI submodule (sonic-net#1204)

updates from SAI
7710e24 | [cherry-pick][202211]Enhance the check enum lock script (sonic-net#1741) (sonic-net#1742)
0031470 | improve enum values integration check (sonic-net#1727) (sonic-net#1737)
4f11c7e | Enable github code scanning to replace LGTM. (sonic-net#1709)

How I did it
How to verify it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wangxin wangxin wangxin approved these changes

@yxieca yxieca yxieca approved these changes

@neethajohn neethajohn Awaiting requested review from neethajohn

@daall daall Awaiting requested review from daall

Assignees

No one assigned

Labels

Jenkins-Pilot

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tahmed-dev @svc-acs @daall @wangxin @yxieca