Skip to content

Conversation

@ematipico
Copy link
Member

@ematipico ematipico commented Sep 3, 2025

Changes

Testing

Docs

@changeset-bot
Copy link

changeset-bot bot commented Sep 3, 2025

🦋 Changeset detected

Latest commit: 21d819d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Sep 3, 2025
@ematipico ematipico force-pushed the feat/environment-api branch from 15a3eab to c701fe4 Compare September 3, 2025 08:17
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 3, 2025

CodSpeed Performance Report

Merging #14306 will not alter performance

Comparing feat/environment-api (28b2f42) with main (f59581f)1

Summary

✅ 6 untouched

Footnotes

  1. No successful run was found on next (16bb9f0) during the generation of this report, so main (f59581f) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

* refactor: use environments to load modules (#14191)

* refactor: make `App` more extensible using `BaseApp` (#14197)

* refactor: App to extends the new BaseApp (#14213)

* refactor: manifest as virtual module (#14298)

* refactor: create `generate` when needed

* fix type

* remove type

* fix types

* fix breakage of code
ematipico and others added 8 commits September 8, 2025 10:23
* Use separate env to load content config

* Format
* feat(cloudflare): add Vite plugin

* Skip request handling when running in cloudflare

* Skip lots of plugins in non-runnable envs

* Use serialized-manifest

* Use separate env to load content config

* Format

* fix rebase

* fix type

* Remove overrides

* Remove trace

---------

Co-authored-by: Emanuele Stoppa <[email protected]>
@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Sep 9, 2025
…14345)

* refactor: dev app without settings and loader

* address comments

* chore: refactor to use proper dev pipeline

* revert changes

* chore: update lockfile

* conditionally propagate metadata

* revert exports
ascorbic and others added 7 commits September 15, 2025 14:34
* Add support for content layer in env API

* Lint

* Format
* Support CF Images binding

* Add support for content layer in env API

* Lint

* Format

* Use image binding in dev

---------

Co-authored-by: Samuel Macleod <[email protected]>
Co-authored-by: Alexander Niebuhr <[email protected]>
This gets framework components to render in workerd. SSR and client both
work.
@github-actions github-actions bot added pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: react Related to React (scope) pkg: preact Related to Preact (scope) pkg: solid Related to Solid (scope) labels Oct 14, 2025
@github-actions github-actions bot removed pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) 🚨 action Modifies GitHub Actions pkg: react Related to React (scope) pkg: preact Related to Preact (scope) pkg: solid Related to Solid (scope) labels Oct 20, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2025

📝 Changeset Validation Results

Changeset validation failed

Issues Found:

.changeset/open-monkeys-boil.md

Issue with: 'Runs "astro dev" using Cloudflare Vite plugin. This means that dev runs in workerd, giving a dev experience much closer to production.'

Errors:
• The description does not include actionable migration advice or sufficient details about the breaking change.
• The description does not match the required detail level for a major change type.

💡 Suggestions:
• Expand on the implications of "Runs astro dev using Cloudflare Vite plugin" and provide clear instructions to users on adapting to the new behavior.
• Include detailed migration steps or compatible alternatives to changes prompted by this update.

Issue with: 'TODO: add a lot more detail on what this means and what it breaks'

Errors:
• The presence of a "TODO" implies incomplete information.
• Unfinished details do not conform to required guidelines.

💡 Suggestions:
• Replace "TODO" with clear, actionable, and complete information about the changes and impacts.
• Ensure comprehensive documentation of the breaking changes and migration advice.

General Suggestions:

  • Consider providing detailed migration guidance for the described breaking changes.

.changeset/warm-things-allow.md

Issue with: 'Implements Vite Environment API'

Errors:
• The description lacks detail about the breaking change implications.
• Further information about user-facing aspects is missing.

💡 Suggestions:
• Expand the description to demonstrate the changes introduced by the "Vite Environment API" and any migration or usage guidance required.
• Elucidate user advantage or impact for this change.

Issue with: 'TODO: add more details'

Errors:
• The inclusion of "TODO" signifies incomplete change details.
• Guidelines prohibit the use of placeholders in descriptions.

💡 Suggestions:
• Ensure the short description is appropriately finalized, presenting thorough and complete change details.
• Replace "TODO" with necessary complete content pertaining to the modification.

General Suggestions:

  • Ensure descriptions for breaking changes adhere to guidelines by providing detailed user-facing implications.
  • Remove placeholder text and ensure full details are presented.

📖 See Astro's changeset guide for details.

ematipico and others added 2 commits October 20, 2025 15:53
Co-authored-by: Matt Kane <[email protected]>
Co-authored-by: Florian Lefebvre <[email protected]>


Co-authored-by: florian-lefebvre <[email protected]>
Co-authored-by: ascorbic <[email protected]>
Co-authored-by: matthewp <[email protected]>
ematipico and others added 7 commits October 28, 2025 13:41
* refactor: unify manifest system, use serialized manifest as source of truth

Merged the old plugin-manifest and new serialized-manifest systems into one.
The serialized manifest is now the single source of truth for both dev and
production builds. In dev, it's used directly. In prod, plugin-manifest
appends real build data (routes, assets, CSP hashes) on top of it.

This eliminates dual virtual modules and simplifies the architecture.
The serialized manifest defines the manifest module content, while
plugin-manifest handles build-specific concerns (entry point registration,
filename tracking, injection).

Enables Cloudflare Workers deployment by ensuring proper manifest handling
in environment-specific builds.

* linting

* add comments and address constant

* fix linting issues

* use the const

* linting
Co-authored-by: Florian Lefebvre <[email protected]>
* feat: full sessions support w/ environment api

- create virtual module for cloudflare config (sessionKVBindingName)
- handler dynamically accesses binding from env via virtual module
- remove hardcoded SESSION binding name, now configurable
- remove unused __env__ global
- add test fixture with sessions form
- sessions now fully integrated with astro environment api

* fix: organize imports and formatting in cloudflare handler (#14697)

* Initial plan

* fix: organize imports and formatting in handler.ts

Co-authored-by: matthewp <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: matthewp <[email protected]>

* fix: make CloudflareConfig interface internal

* fix: use AstroError for session driver resolution failures

* fix: organize imports in session vite plugin

* fix: move virtual.d.ts to package root

---------

Co-authored-by: Copilot <[email protected]>
Co-authored-by: matthewp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs pr pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) semver: major Change triggers a `major` release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants