refactor(core): clean up of apps

[ematipico]

Changes

This PR does a bit of cleanup of the internal code, here's the list of the changes:

• getApp is now createApp
• createExports is now called createAstroServerApp
• actions and middleware, in dev (when using our astro server), aren't loaded anymore using the module loader. Instead, they're injected using the same pattern we use inside createApp. loadMiddleware and loadActions are now removed
• because of that, the RenderContext now accepts a skipMiddleware flag. We were already using the "skip middleware" concpet at "caller level", in case we need to call the middleware during the rendering. This isn't needed anymore, since the render context handles it by passing the flag. I think it's way easier this way

Testing

Middleware and actions test are still passing

Docs

[changeset-bot]

⚠️ No Changeset found

Latest commit: 07df2cf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[florian-lefebvre]

Looks very good overall! One comment

[ematipico]

@florian-lefebvre do you know how to tell knip that something is actually used?

Unused files (1)
packages/astro/src/vite-plugin-app/createAstroServerApp.ts

[florian-lefebvre]

I think you should add the file to knip.js packages/astro entry array. Otherwise there's the @lintignore comment but it's not the thing we want here IMO