chore: handle invalidation of manifest #14537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
the
pkg: astro
ascorbic
reviewed
Oct 14, 2025
| }; | ||
| }); | ||
| let environment = server.environments.ssr; | ||
| if (isRunnableDevEnvironment(environment)) { |
Contributor
There was a problem hiding this comment.
What happens in other enviornments?
Member
Author
There was a problem hiding this comment.
I removed the check, it seems to be working even without it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR handles the invalidation of the manifest module when changes occur in the
srdDirdirectory.When a path that changed is detected, we invalidate the module itself, so the new routes can be calculated and passed to the
DevAppTesting
Manual testing by changing/deleting/adding routes inside the pages/ folder, and made sure that the data is up-to-date.
Docs
N/A