Skip to content

Support framework components #14382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 15, 2025
Merged

Support framework components #14382

merged 2 commits into from
Sep 15, 2025

Conversation

@matthewp
Copy link
Contributor

@matthewp matthewp commented Sep 15, 2025

This gets framework components to render in workerd. SSR and client both work.

Changes

  • Fix the dev pipeline's resolve to be dynamic.
  • Fix getComponentByRoute to first call getModuleForRoute which captures default routes.
    • This fixes 404s which were broken
  • Moves renderers into a virtual module.

Testing

  • Tested with our cloudflare example app

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: b6e6fa4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) labels Sep 15, 2025
@matthewp
Support framework components
15a135e 
This gets framework components to render in workerd. SSR and client both
work.
@matthewp matthewp force-pushed the env-api/framework-components2 branch from 595e908 to 15a135e Compare September 15, 2025 13:43
florian-lefebvre
florian-lefebvre approved these changes Sep 15, 2025
View reviewed changes
@matthewp matthewp merged commit 77fdf98 into feat/environment-api Sep 15, 2025
6 of 9 checks passed
@matthewp matthewp deleted the env-api/framework-components2 branch September 15, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ascorbic ascorbic ascorbic approved these changes

@florian-lefebvre florian-lefebvre florian-lefebvre approved these changes

Assignees

No one assigned

Labels

pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matthewp @ascorbic @florian-lefebvre