Skip to content

Conversation

Copy link

Copilot AI commented Oct 30, 2025

Fixed linting issues in the Cloudflare handler that were blocking CI. The import order violated biome's organization rules.

Changes

  • Reorganized imports in handler.ts to comply with biome linter (virtual module imports before type imports)
  • Fixed code formatting (spacing in if statement, trailing comma)

These changes ensure the PR passes pnpm run lint:ci.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2025

⚠️ No Changeset found

Latest commit: 10e2531

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI changed the title [WIP] Add full sessions support with environment API fix: organize imports and formatting in cloudflare handler Oct 30, 2025
Copilot AI requested a review from matthewp October 30, 2025 18:59
Copilot finished work on behalf of matthewp October 30, 2025 18:59
@matthewp matthewp marked this pull request as ready for review October 30, 2025 19:09
@matthewp matthewp merged commit 9af11de into feat/sessions-environment-api Oct 30, 2025
@matthewp matthewp deleted the copilot/sub-pr-14696 branch October 30, 2025 19:10
matthewp added a commit that referenced this pull request Oct 31, 2025
* feat: full sessions support w/ environment api

- create virtual module for cloudflare config (sessionKVBindingName)
- handler dynamically accesses binding from env via virtual module
- remove hardcoded SESSION binding name, now configurable
- remove unused __env__ global
- add test fixture with sessions form
- sessions now fully integrated with astro environment api

* fix: organize imports and formatting in cloudflare handler (#14697)

* Initial plan

* fix: organize imports and formatting in handler.ts

Co-authored-by: matthewp <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: matthewp <[email protected]>

* fix: make CloudflareConfig interface internal

* fix: use AstroError for session driver resolution failures

* fix: organize imports in session vite plugin

* fix: move virtual.d.ts to package root

---------

Co-authored-by: Copilot <[email protected]>
Co-authored-by: matthewp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants