Skip to content

Use imported Cloudflare handler in env API #14360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 15, 2025
Merged

Use imported Cloudflare handler in env API #14360

merged 2 commits into from
Sep 15, 2025

Conversation

@ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Sep 15, 2025 •
edited
Loading

Changes

This PR updates the Cloudflare entrypoint to generate a handler that works in dev with the env API.

Testing

This updates the Cloudflare vite plugin fixture to use the standard entrypoint, rather than the custom dev one

Docs

@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: dffab10

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) labels Sep 15, 2025
@ascorbic ascorbic self-assigned this Sep 15, 2025
florian-lefebvre
florian-lefebvre approved these changes Sep 15, 2025
View reviewed changes
Copy link
Member

@florian-lefebvre florian-lefebvre left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing this kind of thing is okay for now while we get things working, but we should use a better API eventually

@ascorbic
Copy link
Contributor Author

ascorbic commented Sep 15, 2025

Yeah. It's an improvement on the previous version though, which is just copying the entrypoint code into the fixture

@ascorbic ascorbic merged commit 48197bb into feat/environment-api Sep 15, 2025
4 checks passed
@ascorbic ascorbic deleted the env-api-cf-entrypoint branch September 15, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@florian-lefebvre florian-lefebvre florian-lefebvre approved these changes

Assignees

@ascorbic ascorbic

Labels

pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ascorbic @florian-lefebvre