refactor: make App more extensible using BaseApp
#14197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
the
pkg: astro
ematipico
changed the title
App more extensible using BaseApp
ematipico
added a commit
that referenced
this pull request
Sep 2, 2025
ematipico
added a commit
that referenced
this pull request
Sep 3, 2025
ematipico
added a commit
that referenced
this pull request
Sep 3, 2025
* refactor: use environments to load modules (#14191) * refactor: make `App` more extensible using `BaseApp` (#14197) * refactor: App to extends the new BaseApp (#14213) * refactor: manifest as virtual module (#14298) * refactor: create `generate` when needed * fix type * remove type * fix types * fix breakage of code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We need the
Appto be fully extendable and more flexible, so it can be used in other environments that aren't Node.js. At the moment it is exclusively used inside adapters, however, we foresee its usage indevand the possibility ofbuildtoo.This PR creates a new abstract
BaseAppthat implements all the methods inside theAppclass. The only method that must be implemented iscreatePipeline.The function
AppPipeline.createhas been dramatically simplified, since many of the arguments that we were passing can be computed from themanifest, and some other values were hardcoded.AppPipelineis also exposed because the creation of new "Apps" that extendApprequires the implementation ofcratePipeline. I didn't create a default implementation ofcreatePipelinebecause ofPandAppPipeline(TypeScript doesn't like it). If you know how to fix it, please let me know how.The method
AppPipeline.getModuleForRoutehas been moved insideBasePipeline. There's a chance we could reuse it.Testing
This is a refactor, so the entire CI should stay green
Docs
N/A