-
-
Notifications
You must be signed in to change notification settings - Fork 3k
refactor: routes as virtual module #14313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
ascorbic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will App be able to load this if there are no routes in the manifest?
Not yet, but now that Eventually, |
|
Important I removed the |
|
This PR broke a bunch of stuff around prerendering. Currently checking what's the best course of action once I understand the problem clearly |
|
The problem is caused now by an inconsistency between the dev/ssr pipeline and the build pipeline. Particularly, there's a plugin called I will address this in a separate PR. |
Changes
This PR adds a new virtual module that allows to return the list of routes inside an Astro project.
This virtual module essentially replaces the
RoutesListtype that we create when we start the dev server.Testing
Unit tests should pass. Integration tests pass on my machine, they will still time out here
Docs
N/A