Skip to content

[ixia/Keysight] Adding IxANVL automated deployment using PTF32 topology.#3162

Merged
yxieca merged 9 commits intosonic-net:masterfrom
aganguly-keysight:master
May 6, 2021
Merged

[ixia/Keysight] Adding IxANVL automated deployment using PTF32 topology.#3162
yxieca merged 9 commits intosonic-net:masterfrom
aganguly-keysight:master

Conversation

@aganguly-keysight
Copy link
Contributor

Description of PR

Addition of IxANVL PTF Container automated deployment using PTF32 topology.

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • [ x] Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

How did you do it?

Modified ansible/roles/vm_set/tasks/add-topo.yml, ansible/roles/vm_set/tasks/remove-topo.yml, ansible/roles/vm_set/tasks/main.yml to create and bind IxANVL container in a PTF32 topology with SONIC-VS DUT.
Added a new configuration - "ixanvl-vs-conf" in testbed.csv and testbed.yaml for this.

Found one issue during PTF32 topology deployment as the bind was throwing errors as there was no VMs needed for this topology and hence was not defined in topology ymls. Fixed that error by making "vm_names" to be an optional argument in
ansible/roles/vm_set/library/vm_topology.py main function. Made subsequent changes in that file for this purpose.

How did you verify/test it?

By running testbed-cli.sh script for add-topo and remove-topo for ixanvl-vs-conf configuration.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

A new README added in testbed section.
Readme file: README.testbed.IxANVL.VsSetup.md

@aganguly-keysight aganguly-keysight requested review from a team, wangxin and yxieca as code owners March 17, 2021 10:41
@ghost
Copy link

ghost commented Mar 17, 2021

CLA assistant check
All CLA requirements met.

@aganguly-keysight
Copy link
Contributor Author

Hello @yxieca
I have updated the PR with changes for running bgp conformance tests. Updated conftest.py and added test_bgp_conformance.py . Please share your review comments.

@yxieca yxieca merged commit 82d7084 into sonic-net:master May 6, 2021
saravanansv pushed a commit to saravanansv/sonic-mgmt that referenced this pull request May 6, 2021
…gy. (sonic-net#3162)

How did you do it?
Modified ansible/roles/vm_set/tasks/add-topo.yml, ansible/roles/vm_set/tasks/remove-topo.yml, ansible/roles/vm_set/tasks/main.yml to create and bind IxANVL container in a PTF32 topology with SONIC-VS DUT.
Added a new configuration - "ixanvl-vs-conf" in testbed.csv and testbed.yaml for this.

Found one issue during PTF32 topology deployment as the bind was throwing errors as there was no VMs needed for this topology and hence was not defined in topology ymls. Fixed that error by making "vm_names" to be an optional argument in
ansible/roles/vm_set/library/vm_topology.py main function. Made subsequent changes in that file for this purpose.

How did you verify/test it?
By running testbed-cli.sh script for add-topo and remove-topo for ixanvl-vs-conf configuration.
bingwang-ms pushed a commit to bingwang-ms/sonic-mgmt that referenced this pull request Aug 18, 2021
We are migrating from Jenkins to azure pipeline. This PR added azure pipeline yaml files and dependent template files for nightly tests. Pipeline yaml files only added for 3 testbeds yet. The pipelines were originally added to branch azp-test of repo https://dev.azure.com/mssonic/internal/_git/sonic-mgmt-int. They have been tested on Azure DevOps.

Now we formally add these pipelines to the Networking-acs-sonic-mgmt repo. Currently the internal branch of Networking-acs-sonic-mgmt is synched to same internal branch of the sonic-mgmt-int repo. After this PR is merged, we need to update configuration of the created pipelines to formally use these files from the internal branch.

If the pipelines work fine with yaml files from internal branch, we will create more pipeline files based on current templates for rest of the nightly testbeds.

Related work items: sonic-net#3021, sonic-net#3073, sonic-net#3135, sonic-net#3153, sonic-net#3162, sonic-net#3176, sonic-net#3238, sonic-net#3241, sonic-net#3346, sonic-net#3352, sonic-net#3378, sonic-net#3389, sonic-net#3395, sonic-net#3397, sonic-net#3398, sonic-net#3407, sonic-net#3410, sonic-net#3411, sonic-net#3412, sonic-net#3413, sonic-net#3414, sonic-net#3415, sonic-net#3434, sonic-net#3437, sonic-net#3445, sonic-net#3446, sonic-net#3447, #9740131, #9821349
vmittal-msft pushed a commit to vmittal-msft/sonic-mgmt that referenced this pull request Sep 28, 2021
…gy. (sonic-net#3162)

How did you do it?
Modified ansible/roles/vm_set/tasks/add-topo.yml, ansible/roles/vm_set/tasks/remove-topo.yml, ansible/roles/vm_set/tasks/main.yml to create and bind IxANVL container in a PTF32 topology with SONIC-VS DUT.
Added a new configuration - "ixanvl-vs-conf" in testbed.csv and testbed.yaml for this.

Found one issue during PTF32 topology deployment as the bind was throwing errors as there was no VMs needed for this topology and hence was not defined in topology ymls. Fixed that error by making "vm_names" to be an optional argument in
ansible/roles/vm_set/library/vm_topology.py main function. Made subsequent changes in that file for this purpose.

How did you verify/test it?
By running testbed-cli.sh script for add-topo and remove-topo for ixanvl-vs-conf configuration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants