Skip to content

[rdma] Update ptfhost fixture to handle keysight api docker#3414

Merged
neethajohn merged 1 commit intosonic-net:masterfrom
neethajohn:rdma_ptf-host
Apr 27, 2021
Merged

[rdma] Update ptfhost fixture to handle keysight api docker#3414
neethajohn merged 1 commit intosonic-net:masterfrom
neethajohn:rdma_ptf-host

Conversation

@neethajohn
Copy link
Contributor

Signed-off-by: Neetha John nejo@microsoft.com

Description of PR

For tgen topology, ptf host is the keysight-api-server and api's in the ixia packages are the means to communicate with the api server. Hence the ptfhost should return a None handle.
Also without this change, some of the testcases in test_pretest.py will run into an error while trying to access the ptfhost handle on this topology

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

How did you verify/test it?

No errors seen during test_pretest.py run on tgen topology

Signed-off-by: Neetha John <nejo@microsoft.com>
@neethajohn neethajohn requested a review from a team as a code owner April 26, 2021 22:12
@neethajohn neethajohn requested review from wangxin and yxieca April 26, 2021 22:13
@neethajohn neethajohn merged commit 38ba31a into sonic-net:master Apr 27, 2021
@neethajohn neethajohn deleted the rdma_ptf-host branch April 27, 2021 19:38
saravanansv pushed a commit to saravanansv/sonic-mgmt that referenced this pull request May 6, 2021
…t#3414)

For tgen topology, ptf host is the keysight-api-server and api's in the ixia packages are the means to communicate with the api server. Hence the ptfhost should return a None handle.
Also without this change, some of the testcases in test_pretest.py will run into an error while trying to access the ptfhost handle on this topology

Signed-off-by: Neetha John <nejo@microsoft.com>

How did you verify/test it?
No errors seen during test_pretest.py run on tgen topology
bingwang-ms pushed a commit to bingwang-ms/sonic-mgmt that referenced this pull request Aug 18, 2021
We are migrating from Jenkins to azure pipeline. This PR added azure pipeline yaml files and dependent template files for nightly tests. Pipeline yaml files only added for 3 testbeds yet. The pipelines were originally added to branch azp-test of repo https://dev.azure.com/mssonic/internal/_git/sonic-mgmt-int. They have been tested on Azure DevOps.

Now we formally add these pipelines to the Networking-acs-sonic-mgmt repo. Currently the internal branch of Networking-acs-sonic-mgmt is synched to same internal branch of the sonic-mgmt-int repo. After this PR is merged, we need to update configuration of the created pipelines to formally use these files from the internal branch.

If the pipelines work fine with yaml files from internal branch, we will create more pipeline files based on current templates for rest of the nightly testbeds.

Related work items: sonic-net#3021, sonic-net#3073, sonic-net#3135, sonic-net#3153, sonic-net#3162, sonic-net#3176, sonic-net#3238, sonic-net#3241, sonic-net#3346, sonic-net#3352, sonic-net#3378, sonic-net#3389, sonic-net#3395, sonic-net#3397, sonic-net#3398, sonic-net#3407, sonic-net#3410, sonic-net#3411, sonic-net#3412, sonic-net#3413, sonic-net#3414, sonic-net#3415, sonic-net#3434, sonic-net#3437, sonic-net#3445, sonic-net#3446, sonic-net#3447, #9740131, #9821349
vmittal-msft pushed a commit to vmittal-msft/sonic-mgmt that referenced this pull request Sep 28, 2021
…t#3414)

For tgen topology, ptf host is the keysight-api-server and api's in the ixia packages are the means to communicate with the api server. Hence the ptfhost should return a None handle.
Also without this change, some of the testcases in test_pretest.py will run into an error while trying to access the ptfhost handle on this topology

Signed-off-by: Neetha John <nejo@microsoft.com>

How did you verify/test it?
No errors seen during test_pretest.py run on tgen topology
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants