Skip to content

[platform] fixed undefined variable in test test_platform_info.py#3410

Merged
neethajohn merged 1 commit intosonic-net:masterfrom
ppikh:fix_for_test_platform_info
Apr 27, 2021
Merged

[platform] fixed undefined variable in test test_platform_info.py#3410
neethajohn merged 1 commit intosonic-net:masterfrom
ppikh:fix_for_test_platform_info

Conversation

@ppikh
Copy link
Contributor

@ppikh ppikh commented Apr 26, 2021

Description of PR

Summary: fixed undefined variable in test test_platform_info.py
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

Fix for NameError: global name 'duthost' is not defined

How did you do it?

see commit

How did you verify/test it?

executed tests from file 'platform_tests/test_platform_info.py'

Any platform specific information?

Supported testbed topology if it's a new test case?

@ppikh ppikh requested a review from jleveque as a code owner April 26, 2021 17:30
@jleveque jleveque requested a review from yxieca April 27, 2021 16:32
@neethajohn neethajohn merged commit 2b3f8e3 into sonic-net:master Apr 27, 2021
saravanansv pushed a commit to saravanansv/sonic-mgmt that referenced this pull request May 6, 2021
…nic-net#3410)

What is the motivation for this PR?
Fix for NameError: global name 'duthost' is not defined

How did you verify/test it?
executed tests from file 'platform_tests/test_platform_info.py'
bingwang-ms pushed a commit to bingwang-ms/sonic-mgmt that referenced this pull request Aug 18, 2021
We are migrating from Jenkins to azure pipeline. This PR added azure pipeline yaml files and dependent template files for nightly tests. Pipeline yaml files only added for 3 testbeds yet. The pipelines were originally added to branch azp-test of repo https://dev.azure.com/mssonic/internal/_git/sonic-mgmt-int. They have been tested on Azure DevOps.

Now we formally add these pipelines to the Networking-acs-sonic-mgmt repo. Currently the internal branch of Networking-acs-sonic-mgmt is synched to same internal branch of the sonic-mgmt-int repo. After this PR is merged, we need to update configuration of the created pipelines to formally use these files from the internal branch.

If the pipelines work fine with yaml files from internal branch, we will create more pipeline files based on current templates for rest of the nightly testbeds.

Related work items: sonic-net#3021, sonic-net#3073, sonic-net#3135, sonic-net#3153, sonic-net#3162, sonic-net#3176, sonic-net#3238, sonic-net#3241, sonic-net#3346, sonic-net#3352, sonic-net#3378, sonic-net#3389, sonic-net#3395, sonic-net#3397, sonic-net#3398, sonic-net#3407, sonic-net#3410, sonic-net#3411, sonic-net#3412, sonic-net#3413, sonic-net#3414, sonic-net#3415, sonic-net#3434, sonic-net#3437, sonic-net#3445, sonic-net#3446, sonic-net#3447, #9740131, #9821349
vmittal-msft pushed a commit to vmittal-msft/sonic-mgmt that referenced this pull request Sep 28, 2021
…nic-net#3410)

What is the motivation for this PR?
Fix for NameError: global name 'duthost' is not defined

How did you verify/test it?
executed tests from file 'platform_tests/test_platform_info.py'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants