Skip to content

[multi asic] Change the test_dip_sip for multi asic platforms#3073

Merged
arlakshm merged 3 commits intosonic-net:masterfrom
arlakshm:masic_ipfwd
May 4, 2021
Merged

[multi asic] Change the test_dip_sip for multi asic platforms#3073
arlakshm merged 3 commits intosonic-net:masterfrom
arlakshm:masic_ipfwd

Conversation

@arlakshm
Copy link
Contributor

@arlakshm arlakshm commented Mar 3, 2021

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • [ x] Test case(new/improvement)

Approach

What is the motivation for this PR?

Changes added to test_dip_sip to support multi asic platforms

How did you do it?

Change the test test_dip_sip to run on every ASIC connected to the external devices.

How did you verify/test it?

Run the test on single and multi asic platforms

  • Single asic logs:
arlakshm@61e163aff932:/data/sonic-mgmt/tests$ cd ../tests;./run_tests.sh -n vms-kvm-t0 -d vlab01 -c ipfwd/test_dip_sip.py -f vtestbed.csv -i veos_vtb -u -e "--skip_sanity"
=== Running tests in groups ===
/usr/local/lib/python2.7/dist-packages/ansible/parsing/vault/__init__.py:44: CryptographyDeprecationWarning: Python 2 is no longer supported by the Python core team. Support for it is now deprecated in cryptography, and will be removed in a future release.
  from cryptography.exceptions import InvalidSignature
========================================================================== test session starts ==========================================================================platform linux2 -- Python 2.7.17, pytest-4.6.5, py-1.9.0, pluggy-0.13.1
ansible: 2.8.12
rootdir: /data/sonic-mgmt/tests, inifile: pytest.ini
plugins: forked-1.3.0, xdist-1.28.0, repeat-0.8.0, metadata-1.10.0, html-1.22.1, ansible-2.2.2
collected 1 item

ipfwd/test_dip_sip.py::test_dip_sip[vlab-01-None] PASSED                                                                                                          [100%]

-------------------------------------------------------- generated xml file: /data/sonic-mgmt/tests/logs/tr.xml ---------------------------------------------------------======================================================================= 1 passed in 32.22 seconds =======================================================================Exception AttributeError: "'NoneType' object has no attribute 'close'" in <bound method EventDescriptor.__del__ of <ptf.ptfutils.EventDescriptor instance at 0x7fb520217190>> ignored
arlakshm@61e163aff932:/data/sonic-mgmt/tests$

  • Multi asic logs

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

arlakshm added 2 commits March 2, 2021 14:50
Signed-off-by: Arvindsrinivasan Lakshminarasimhan <arlakshm@microsoft.com>
Signed-off-by: Arvindsrinivasan Lakshminarasimhan <arlakshm@microsoft.com>
@arlakshm arlakshm requested a review from a team as a code owner March 3, 2021 00:11
Copy link
Collaborator

@wangxin wangxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @arlakshm, can you address the merge conflicts?

@arlakshm arlakshm merged commit 3ee4083 into sonic-net:master May 4, 2021
saravanansv pushed a commit to saravanansv/sonic-mgmt that referenced this pull request May 6, 2021
…net#3073)

What is the motivation for this PR?
Changes added to test_dip_sip to support multi asic platforms

How did you do it?
Change the test test_dip_sip to run on every ASIC connected to the external devices.

Signed-off-by: Arvindsrinivasan Lakshminarasimhan <arlakshm@microsoft.com>
bingwang-ms pushed a commit to bingwang-ms/sonic-mgmt that referenced this pull request Aug 18, 2021
We are migrating from Jenkins to azure pipeline. This PR added azure pipeline yaml files and dependent template files for nightly tests. Pipeline yaml files only added for 3 testbeds yet. The pipelines were originally added to branch azp-test of repo https://dev.azure.com/mssonic/internal/_git/sonic-mgmt-int. They have been tested on Azure DevOps.

Now we formally add these pipelines to the Networking-acs-sonic-mgmt repo. Currently the internal branch of Networking-acs-sonic-mgmt is synched to same internal branch of the sonic-mgmt-int repo. After this PR is merged, we need to update configuration of the created pipelines to formally use these files from the internal branch.

If the pipelines work fine with yaml files from internal branch, we will create more pipeline files based on current templates for rest of the nightly testbeds.

Related work items: sonic-net#3021, sonic-net#3073, sonic-net#3135, sonic-net#3153, sonic-net#3162, sonic-net#3176, sonic-net#3238, sonic-net#3241, sonic-net#3346, sonic-net#3352, sonic-net#3378, sonic-net#3389, sonic-net#3395, sonic-net#3397, sonic-net#3398, sonic-net#3407, sonic-net#3410, sonic-net#3411, sonic-net#3412, sonic-net#3413, sonic-net#3414, sonic-net#3415, sonic-net#3434, sonic-net#3437, sonic-net#3445, sonic-net#3446, sonic-net#3447, #9740131, #9821349
vmittal-msft pushed a commit to vmittal-msft/sonic-mgmt that referenced this pull request Sep 28, 2021
…net#3073)

What is the motivation for this PR?
Changes added to test_dip_sip to support multi asic platforms

How did you do it?
Change the test test_dip_sip to run on every ASIC connected to the external devices.

Signed-off-by: Arvindsrinivasan Lakshminarasimhan <arlakshm@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants