[psu] share the PSU line pattern across tests#3447
Merged
yxieca merged 2 commits intosonic-net:masterfrom May 6, 2021
Merged
Conversation
Signed-off-by: Ying Xie <[email protected]>
jleveque
approved these changes
May 5, 2021
|
This pull request introduces 1 alert when merging b7220ad into 541056c - view on LGTM.com new alerts:
|
jleveque
suggested changes
May 5, 2021
Contributor
jleveque
left a comment
jleveque
left a comment
There was a problem hiding this comment.
Please fix LGTM alert (no longer need to import re in test_platform_info.py).
jleveque
approved these changes
May 6, 2021
bingwang-ms
pushed a commit
to bingwang-ms/sonic-mgmt
that referenced
this pull request
Aug 18, 2021
We are migrating from Jenkins to azure pipeline. This PR added azure pipeline yaml files and dependent template files for nightly tests. Pipeline yaml files only added for 3 testbeds yet. The pipelines were originally added to branch azp-test of repo https://dev.azure.com/mssonic/internal/_git/sonic-mgmt-int. They have been tested on Azure DevOps. Now we formally add these pipelines to the Networking-acs-sonic-mgmt repo. Currently the internal branch of Networking-acs-sonic-mgmt is synched to same internal branch of the sonic-mgmt-int repo. After this PR is merged, we need to update configuration of the created pipelines to formally use these files from the internal branch. If the pipelines work fine with yaml files from internal branch, we will create more pipeline files based on current templates for rest of the nightly testbeds. Related work items: sonic-net#3021, sonic-net#3073, sonic-net#3135, sonic-net#3153, sonic-net#3162, sonic-net#3176, sonic-net#3238, sonic-net#3241, sonic-net#3346, sonic-net#3352, sonic-net#3378, sonic-net#3389, sonic-net#3395, sonic-net#3397, sonic-net#3398, sonic-net#3407, sonic-net#3410, sonic-net#3411, sonic-net#3412, sonic-net#3413, sonic-net#3414, sonic-net#3415, sonic-net#3434, sonic-net#3437, sonic-net#3445, sonic-net#3446, sonic-net#3447, #9740131, #9821349
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
What is the motivation for this PR? platform_tests/cli/test_show_platform.py::test_show_platform_psustatus is failing because the PSU output line regex is wrong. This issue was addressed for platform_tests/test_platform_info.py::test_turn_on_off_psu_and_check_psustatus before. How did you do it? Share the PSU out line regex between tests. How did you verify/test it? run platform_tests/cli/test_show_platform.py::test_show_platform_psustatus, passes with change. run platform_tests/test_platform_info.py::test_turn_on_off_psu_and_check_psustatus, passes before/after change. Signed-off-by: Ying Xie [email protected]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
platform_tests/cli/test_show_platform.py::test_show_platform_psustatus is failing because the PSU output line regex is wrong. This issue was addressed for platform_tests/test_platform_info.py::test_turn_on_off_psu_and_check_psustatus before.
How did you do it?
Share the PSU out line regex between tests.
How did you verify/test it?
run platform_tests/cli/test_show_platform.py::test_show_platform_psustatus, passes with change.
run platform_tests/test_platform_info.py::test_turn_on_off_psu_and_check_psustatus, passes before/after change.
Signed-off-by: Ying Xie [email protected]