Add loganalyzer for sairedis for advanced reboot tests#3378
Merged
shi-su merged 6 commits intosonic-net:masterfrom Apr 27, 2021
Merged
Add loganalyzer for sairedis for advanced reboot tests#3378shi-su merged 6 commits intosonic-net:masterfrom
shi-su merged 6 commits intosonic-net:masterfrom
Conversation
vaibhavhd
reviewed
Apr 21, 2021
Contributor
vaibhavhd
left a comment
There was a problem hiding this comment.
It would be great if we can generalize the LogAnalyzer to support argument based log type grepping.
For example, here analyze_sairedis is added. But, in future this can grow to many different flags.
To prevent that, if we the caller can specify what files need to be analyzed, this would be useful for several other usecases.
vaibhavhd
reviewed
Apr 23, 2021
Contributor
vaibhavhd
left a comment
There was a problem hiding this comment.
Looking good. Some refactoring suggestions added. Suggest to test another unrelated test which uses log_analyzer, to make sure that there is no regression.
vaibhavhd
reviewed
Apr 23, 2021
vaibhavhd
approved these changes
Apr 23, 2021
Contributor
vaibhavhd
left a comment
There was a problem hiding this comment.
Lgtm, thanks for this useful enhancement!
saravanansv
pushed a commit
to saravanansv/sonic-mgmt
that referenced
this pull request
May 6, 2021
Add loganalyzer for sairedis for advanced reboot tests to gather information about the time the device enters different states in fast/warm reboot.
bingwang-ms
pushed a commit
to bingwang-ms/sonic-mgmt
that referenced
this pull request
Aug 18, 2021
We are migrating from Jenkins to azure pipeline. This PR added azure pipeline yaml files and dependent template files for nightly tests. Pipeline yaml files only added for 3 testbeds yet. The pipelines were originally added to branch azp-test of repo https://dev.azure.com/mssonic/internal/_git/sonic-mgmt-int. They have been tested on Azure DevOps. Now we formally add these pipelines to the Networking-acs-sonic-mgmt repo. Currently the internal branch of Networking-acs-sonic-mgmt is synched to same internal branch of the sonic-mgmt-int repo. After this PR is merged, we need to update configuration of the created pipelines to formally use these files from the internal branch. If the pipelines work fine with yaml files from internal branch, we will create more pipeline files based on current templates for rest of the nightly testbeds. Related work items: sonic-net#3021, sonic-net#3073, sonic-net#3135, sonic-net#3153, sonic-net#3162, sonic-net#3176, sonic-net#3238, sonic-net#3241, sonic-net#3346, sonic-net#3352, sonic-net#3378, sonic-net#3389, sonic-net#3395, sonic-net#3397, sonic-net#3398, sonic-net#3407, sonic-net#3410, sonic-net#3411, sonic-net#3412, sonic-net#3413, sonic-net#3414, sonic-net#3415, sonic-net#3434, sonic-net#3437, sonic-net#3445, sonic-net#3446, sonic-net#3447, #9740131, #9821349
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
Add loganalyzer for sairedis for advanced reboot tests to gather information about the time the device enters different states in fast/warm reboot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
How did you do it?
Add loganalyzer for sairedis for advanced reboot tests to gather information about the time the device enters different states in fast/warm reboot.
How did you verify/test it?
Tested locally and check the time for each state:
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation