[crm] only set ARP cache limit setting when needed#3389
Merged
yxieca merged 3 commits intosonic-net:masterfrom May 6, 2021
Merged
[crm] only set ARP cache limit setting when needed#3389yxieca merged 3 commits intosonic-net:masterfrom
yxieca merged 3 commits intosonic-net:masterfrom
Conversation
SONiC already set ARP cache limit quit high, test shouldn't need to increase according to its needs unless the threshold is actually lower then needed. Signed-off-by: Ying Xie <[email protected]>
|
This pull request introduces 1 alert when merging f5356d8 into 08a42da - view on LGTM.com new alerts:
|
neethajohn
reviewed
Apr 26, 2021
neethajohn
approved these changes
May 6, 2021
saravanansv
pushed a commit
to saravanansv/sonic-mgmt
that referenced
this pull request
May 6, 2021
What is the motivation for this PR? SONiC already set ARP cache limit quit high, test shouldn't need to increase according to its needs unless the threshold is actually lower then needed. How did you do it? Skip ARP cache limit setting if the current limit is higher than requested limit. How did you verify/test it? Run crm test and watch ARP limit never changes during tests. Signed-off-by: Ying Xie [email protected]
bingwang-ms
pushed a commit
to bingwang-ms/sonic-mgmt
that referenced
this pull request
Aug 18, 2021
We are migrating from Jenkins to azure pipeline. This PR added azure pipeline yaml files and dependent template files for nightly tests. Pipeline yaml files only added for 3 testbeds yet. The pipelines were originally added to branch azp-test of repo https://dev.azure.com/mssonic/internal/_git/sonic-mgmt-int. They have been tested on Azure DevOps. Now we formally add these pipelines to the Networking-acs-sonic-mgmt repo. Currently the internal branch of Networking-acs-sonic-mgmt is synched to same internal branch of the sonic-mgmt-int repo. After this PR is merged, we need to update configuration of the created pipelines to formally use these files from the internal branch. If the pipelines work fine with yaml files from internal branch, we will create more pipeline files based on current templates for rest of the nightly testbeds. Related work items: sonic-net#3021, sonic-net#3073, sonic-net#3135, sonic-net#3153, sonic-net#3162, sonic-net#3176, sonic-net#3238, sonic-net#3241, sonic-net#3346, sonic-net#3352, sonic-net#3378, sonic-net#3389, sonic-net#3395, sonic-net#3397, sonic-net#3398, sonic-net#3407, sonic-net#3410, sonic-net#3411, sonic-net#3412, sonic-net#3413, sonic-net#3414, sonic-net#3415, sonic-net#3434, sonic-net#3437, sonic-net#3445, sonic-net#3446, sonic-net#3447, #9740131, #9821349
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
What is the motivation for this PR? SONiC already set ARP cache limit quit high, test shouldn't need to increase according to its needs unless the threshold is actually lower then needed. How did you do it? Skip ARP cache limit setting if the current limit is higher than requested limit. How did you verify/test it? Run crm test and watch ARP limit never changes during tests. Signed-off-by: Ying Xie [email protected]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Type of change
Approach
What is the motivation for this PR?
SONiC already set ARP cache limit quit high, test shouldn't need to increase according to its needs unless the threshold is
actually lower then needed.
How did you do it?
Skip ARP cache limit setting if the current limit is higher than requested limit.
How did you verify/test it?
Run crm test and watch ARP limit never changes during tests.
Signed-off-by: Ying Xie [email protected]