SPyTest 2.0 update

[ramakristipati]

Description of PR

This is updates to SPyTest framework and all the functional test scripts used in Broadcom

Summary:
New Testcases and KLISH/REST support

Type of change

• Bug fix
• Testbed and Framework(new/improvement)
• Test case(new/improvement)

Approach

What is the motivation for this PR?

Contribute More Test Cases and KLISH/REST support

How did you do it?

Feature APIs modified to support CLICK/KLISH/REST

How did you verify/test it?

Results on Community SONiC

(Note: CRCM module is newly added which is failing in current master, which is fixed in software PR)

Results on Current Ready PRs

Execute using build with modifications to SONiC by Broadcom

Any platform specific information?

None

Supported testbed topology if it's a new test case?

PTF, IXIA

Documentation

Added Framework Updates in Doc folder

[lgtm-com]

This pull request introduces 540 alerts and fixes 228 when merging 1300689 into 7fb76f3 - view on LGTM.com

new alerts:

• 214 for Variable defined multiple times
• 101 for Unused local variable
• 74 for Except block handles 'BaseException'
• 33 for Testing equality to None
• 30 for Unused import
• 20 for Unreachable code
• 15 for 'import *' may pollute namespace
• 13 for Non-iterable used in for loop
• 9 for Redundant assignment
• 8 for Module is imported with 'import' and 'import from'
• 4 for Membership test with a non-container
• 4 for Implicit string concatenation in a list
• 4 for Result of integer division may be truncated
• 2 for Wrong name for an argument in a call
• 2 for Modification of parameter with default
• 2 for Insecure temporary file
• 1 for Module is imported more than once
• 1 for Conflicting attributes in base classes
• 1 for Use of 'global' at module level
• 1 for Nested loops with same variable
• 1 for Binding a socket to all network interfaces

fixed alerts:

• 159 for Unused local variable
• 20 for Unreachable code
• 14 for Variable defined multiple times
• 10 for Use of the return value of a procedure
• 8 for Except block handles 'BaseException'
• 4 for Unused argument in a formatting call
• 2 for 'import *' may pollute namespace
• 2 for Nested loops with same variable
• 2 for Result of integer division may be truncated
• 1 for Membership test with a non-container
• 1 for Module is imported more than once
• 1 for Non-callable called
• 1 for Unused import
• 1 for Module is imported with 'import' and 'import from'
• 1 for Use of 'global' at module level
• 1 for Wrong number of arguments in a call

[lguohan]

can you fix all the lgtm?

[lgtm-com]

This pull request introduces 461 alerts and fixes 441 when merging 7ddb4d3 into b7a7a8a - view on LGTM.com

new alerts:

• 202 for Variable defined multiple times
• 99 for Unused local variable
• 32 for Testing equality to None
• 30 for Unused import
• 20 for Unreachable code
• 15 for 'import *' may pollute namespace
• 13 for Non-iterable used in for loop
• 10 for Except block handles 'BaseException'
• 9 for Redundant assignment
• 8 for Module is imported with 'import' and 'import from'
• 4 for Membership test with a non-container
• 4 for Implicit string concatenation in a list
• 4 for Result of integer division may be truncated
• 2 for Wrong name for an argument in a call
• 2 for Modification of parameter with default
• 2 for Insecure temporary file
• 1 for Module is imported more than once
• 1 for Conflicting attributes in base classes
• 1 for Use of 'global' at module level
• 1 for Nested loops with same variable
• 1 for Binding a socket to all network interfaces

fixed alerts:

• 171 for Except block handles 'BaseException'
• 168 for Unused local variable
• 30 for Testing equality to None
• 23 for Unreachable code
• 18 for Variable defined multiple times
• 13 for Use of the return value of a procedure
• 4 for Unused argument in a formatting call
• 2 for 'import *' may pollute namespace
• 2 for Nested loops with same variable
• 2 for Result of integer division may be truncated
• 1 for Too few arguments in formatting call
• 1 for Membership test with a non-container
• 1 for Module is imported more than once
• 1 for Non-callable called
• 1 for Unused import
• 1 for Module is imported with 'import' and 'import from'
• 1 for Use of 'global' at module level
• 1 for Wrong number of arguments in a call

[lgtm-com]

This pull request introduces 393 alerts and fixes 466 when merging e073eb6 into b7a7a8a - view on LGTM.com

new alerts:

• 197 for Variable defined multiple times
• 97 for Unused local variable
• 20 for Unreachable code
• 15 for 'import *' may pollute namespace
• 13 for Unused import
• 13 for Non-iterable used in for loop
• 9 for Redundant assignment
• 6 for Module is imported with 'import' and 'import from'
• 4 for Membership test with a non-container
• 4 for Implicit string concatenation in a list
• 4 for Result of integer division may be truncated
• 2 for Wrong name for an argument in a call
• 2 for Modification of parameter with default
• 2 for Insecure temporary file
• 1 for Module is imported more than once
• 1 for Conflicting attributes in base classes
• 1 for Use of 'global' at module level
• 1 for Nested loops with same variable
• 1 for Binding a socket to all network interfaces

fixed alerts:

• 186 for Except block handles 'BaseException'
• 170 for Unused local variable
• 32 for Testing equality to None
• 25 for Unreachable code
• 22 for Variable defined multiple times
• 13 for Use of the return value of a procedure
• 4 for Unused argument in a formatting call
• 2 for 'import *' may pollute namespace
• 2 for Nested loops with same variable
• 2 for Result of integer division may be truncated
• 1 for Too few arguments in formatting call
• 1 for Membership test with a non-container
• 1 for Module is imported more than once
• 1 for Non-callable called
• 1 for Unused import
• 1 for Module is imported with 'import' and 'import from'
• 1 for Use of 'global' at module level
• 1 for Wrong number of arguments in a call

[lgtm-com]

This pull request introduces 315 alerts and fixes 486 when merging 03b3c98 into 096c8bd - view on LGTM.com

new alerts:

• 180 for Variable defined multiple times
• 64 for Unused local variable
• 15 for 'import *' may pollute namespace
• 13 for Non-iterable used in for loop
• 12 for Unused import
• 5 for Unreachable code
• 5 for Module is imported with 'import' and 'import from'
• 4 for Membership test with a non-container
• 4 for Implicit string concatenation in a list
• 4 for Result of integer division may be truncated
• 2 for Wrong name for an argument in a call
• 2 for Modification of parameter with default
• 1 for Module is imported more than once
• 1 for Conflicting attributes in base classes
• 1 for Redundant assignment
• 1 for Nested loops with same variable
• 1 for Binding a socket to all network interfaces

fixed alerts:

• 186 for Except block handles 'BaseException'
• 170 for Unused local variable
• 34 for Unreachable code
• 32 for Testing equality to None
• 28 for Variable defined multiple times
• 13 for Use of the return value of a procedure
• 4 for Unused argument in a formatting call
• 3 for Nested loops with same variable
• 3 for Insecure temporary file
• 2 for 'import *' may pollute namespace
• 2 for Use of 'global' at module level
• 2 for Result of integer division may be truncated
• 1 for Too few arguments in formatting call
• 1 for Membership test with a non-container
• 1 for Module is imported more than once
• 1 for Non-callable called
• 1 for Unused import
• 1 for Module is imported with 'import' and 'import from'
• 1 for Wrong number of arguments in a call