MIGSMSFT-767 test_pfcwd_basic_single_lossless_prio_reboot: Loss rate of Data Flow 2 (0.1140553129761207) should be in [0, 0]#15801
Merged
yejianquan merged 2 commits intosonic-net:masterfrom Dec 3, 2024
Conversation
Signed-off-by: Zhixin Zhu <[email protected]>
sdszhang
reviewed
Dec 1, 2024
|
|
||
| flow1_delay_sec = restore_time_sec / 2 + WARM_UP_TRAFFIC_DUR | ||
| flow1_dur_sec = pfc_storm_dur_sec | ||
| flow1_delay_sec = detect_time_sec + poll_interval_sec |
Contributor
There was a problem hiding this comment.
- Warm up delay need to be added as pause traffic starts after warm_up traffic.
- can you elaborate more on why the previous delay and duration was incorrect?
The existing testing:
PFC pause sending time: [1, 2]
data flow1 sending time: [1.2, 2.2]
with this setting, the traffic should be dropped once pfcwd is detected around 1.4 second?
Contributor
Author
There was a problem hiding this comment.
data flow1 sending time: [1.4, 2.4]
pfc storm will be detected at ~1.8 second, and restored at ~2.8 second.
data flow1 will be blocked when pfc pause is triggered and dropped after pfc strom is detected. The packet drop of data flow1 will be 99.9%.
The original delay and duration should be good. Removed this change.
8 tasks
Signed-off-by: Zhixin Zhu <[email protected]>
zhixzhu
changed the title
zhixzhu
changed the title
sdszhang
approved these changes
Dec 3, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 3, 2024
…of Data Flow 2 (0.1140553129761207) should be in [0, 0] (sonic-net#15801) Description of PR Summary: Fixes # (issue) https://migsonic.atlassian.net/browse/MIGSMSFT-767 [T2 IXIA] failures in test_pfcwd_basic_single_lossless_prio_reboot: Loss rate of Data Flow 2 (0.1140553129761207) should be in [0, 0] Approach What is the motivation for this PR? Fix the failures of test_multidut_pfcwd_basic_with_snappi.py How did you do it? Data flow 2 dropped packets. 2 flows in default-voq used single voq, which caused tail drop before pfc pause was triggered. Decrease flow number from 2 to 1. Since backplane port's bandwidth is 200G, also decrease the traffic rate from 99.98% to 49.99% How did you verify/test it? Verified on T2 ixia testbed. ----------------------- generated xml file: /run_logs/ixia/18470/2024-11-28-06-00-02/tr_2024-11-28-06-00-02.xml ----------------------- INFO:root:Can not get Allure report URL. Please check logs ------------------------------------------------------- live log sessionfinish -------------------------------------------------------- 08:42:08 __init__.pytest_terminal_summary L0067 INFO | Can not get Allure report URL. Please check logs ======================================================= short test summary info ======================================================= PASSED snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py::test_pfcwd_basic_single_lossless_prio[multidut_port_info0-True] PASSED snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py::test_pfcwd_basic_single_lossless_prio[multidut_port_info0-False] PASSED snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py::test_pfcwd_basic_multi_lossless_prio[multidut_port_info0-True] PASSED snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py::test_pfcwd_basic_multi_lossless_prio[multidut_port_info0-False] PASSED snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py::test_pfcwd_basic_single_lossless_prio_reboot[multidut_port_info0-cold-yy39top-lc4|3-True] PASSED snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py::test_pfcwd_basic_single_lossless_prio_reboot[multidut_port_info0-cold-yy39top-lc4|3-False] PASSED snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py::test_pfcwd_basic_multi_lossless_prio_reboot[multidut_port_info0-cold-True] PASSED snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py::test_pfcwd_basic_multi_lossless_prio_reboot[multidut_port_info0-cold-False] PASSED snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py::test_pfcwd_basic_single_lossless_prio_service_restart[multidut_port_info0-True-swss] PASSED snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py::test_pfcwd_basic_single_lossless_prio_service_restart[multidut_port_info0-False-swss] PASSED snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py::test_pfcwd_basic_multi_lossless_prio_restart_service[multidut_port_info0-True-swss] PASSED snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py::test_pfcwd_basic_multi_lossless_prio_restart_service[multidut_port_info0-False-swss] SKIPPED [2] snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py:142: Reboot type warm is not supported on cisco-8000 switches SKIPPED [2] snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py:142: Reboot type fast is not supported on cisco-8000 switches SKIPPED [2] snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py:190: Reboot type warm is not supported on cisco-8000 switches SKIPPED [2] snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py:190: Reboot type fast is not supported on cisco-8000 switches ======================================= 12 passed, 8 skipped, 15 warnings in 9723.32s (2:42:03) ======================================= sonic@snappi-sonic-mgmt-vanilla-202405-t2:/data/tests$ Signed-off-by: Zhixin Zhu <[email protected]>
Collaborator
|
Cherry-pick PR to 202405: #15860 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Dec 5, 2024
…of Data Flow 2 (0.1140553129761207) should be in [0, 0] (#15801) Description of PR Summary: Fixes # (issue) https://migsonic.atlassian.net/browse/MIGSMSFT-767 [T2 IXIA] failures in test_pfcwd_basic_single_lossless_prio_reboot: Loss rate of Data Flow 2 (0.1140553129761207) should be in [0, 0] Approach What is the motivation for this PR? Fix the failures of test_multidut_pfcwd_basic_with_snappi.py How did you do it? Data flow 2 dropped packets. 2 flows in default-voq used single voq, which caused tail drop before pfc pause was triggered. Decrease flow number from 2 to 1. Since backplane port's bandwidth is 200G, also decrease the traffic rate from 99.98% to 49.99% How did you verify/test it? Verified on T2 ixia testbed. ----------------------- generated xml file: /run_logs/ixia/18470/2024-11-28-06-00-02/tr_2024-11-28-06-00-02.xml ----------------------- INFO:root:Can not get Allure report URL. Please check logs ------------------------------------------------------- live log sessionfinish -------------------------------------------------------- 08:42:08 __init__.pytest_terminal_summary L0067 INFO | Can not get Allure report URL. Please check logs ======================================================= short test summary info ======================================================= PASSED snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py::test_pfcwd_basic_single_lossless_prio[multidut_port_info0-True] PASSED snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py::test_pfcwd_basic_single_lossless_prio[multidut_port_info0-False] PASSED snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py::test_pfcwd_basic_multi_lossless_prio[multidut_port_info0-True] PASSED snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py::test_pfcwd_basic_multi_lossless_prio[multidut_port_info0-False] PASSED snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py::test_pfcwd_basic_single_lossless_prio_reboot[multidut_port_info0-cold-yy39top-lc4|3-True] PASSED snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py::test_pfcwd_basic_single_lossless_prio_reboot[multidut_port_info0-cold-yy39top-lc4|3-False] PASSED snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py::test_pfcwd_basic_multi_lossless_prio_reboot[multidut_port_info0-cold-True] PASSED snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py::test_pfcwd_basic_multi_lossless_prio_reboot[multidut_port_info0-cold-False] PASSED snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py::test_pfcwd_basic_single_lossless_prio_service_restart[multidut_port_info0-True-swss] PASSED snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py::test_pfcwd_basic_single_lossless_prio_service_restart[multidut_port_info0-False-swss] PASSED snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py::test_pfcwd_basic_multi_lossless_prio_restart_service[multidut_port_info0-True-swss] PASSED snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py::test_pfcwd_basic_multi_lossless_prio_restart_service[multidut_port_info0-False-swss] SKIPPED [2] snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py:142: Reboot type warm is not supported on cisco-8000 switches SKIPPED [2] snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py:142: Reboot type fast is not supported on cisco-8000 switches SKIPPED [2] snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py:190: Reboot type warm is not supported on cisco-8000 switches SKIPPED [2] snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py:190: Reboot type fast is not supported on cisco-8000 switches ======================================= 12 passed, 8 skipped, 15 warnings in 9723.32s (2:42:03) ======================================= sonic@snappi-sonic-mgmt-vanilla-202405-t2:/data/tests$ Signed-off-by: Zhixin Zhu <[email protected]>
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
https://migsonic.atlassian.net/browse/MIGSMSFT-767 [T2 IXIA] failures in test_pfcwd_basic_single_lossless_prio_reboot: Loss rate of Data Flow 2 (0.1140553129761207) should be in [0, 0]
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix the failures of test_multidut_pfcwd_basic_with_snappi.py
How did you do it?
Data flow 2 dropped packets.
2 flows in default-voq used single voq, which caused tail drop before pfc pause was triggered. Decrease flow number from 2 to 1. Since backplane port's bandwidth is 200G, also decrease the traffic rate from 99.98% to 49.99%
How did you verify/test it?
Verified on T2 ixia testbed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation