Update ixia_fixture to fix collection errors#2570
Merged
bingwang-ms merged 2 commits intosonic-net:masterfrom Nov 24, 2020
Merged
Update ixia_fixture to fix collection errors#2570bingwang-ms merged 2 commits intosonic-net:masterfrom
bingwang-ms merged 2 commits intosonic-net:masterfrom
Conversation
Errors were reported during pytest collecting test cases because ImportError for IxNetworkApi, which is available only on ixia devices. This commit attempts to catch import exception and skips cases when exception is caught. Signed-off-by: bingwang <[email protected]>
neethajohn
reviewed
Nov 23, 2020
tests/common/ixia/ixia_fixtures.py
Outdated
| try: | ||
| from ixnetwork_open_traffic_generator.ixnetworkapi import IxNetworkApi | ||
| except ImportError as e: | ||
| raise pytest.skip.Exception("Test case is skiped: " + repr(e), allow_module_level=True) |
Collaborator
Author
There was a problem hiding this comment.
Thanks. Updated
neethajohn
approved these changes
Nov 23, 2020
Signed-off-by: bingwang <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Update sonic-utilities submodule pointer to include the following: 3bc2bc6 [Mellanox][202205] Change severity to NOTICE in Mellanox buffer migrator when unable to fetch DEVICE_METADATA due to empty CONFIG_DB during initialization (sonic-net#2570) e1c8243 [202205][generate_dump] Fix for a deletion flow for all secret files in the techsupport dump (sonic-net#2572) 9f2984a [202205] Fix issue: unconfigured PGs are displayed in watermarkstat (sonic-net#2568) f7988b0 [202205] [timer.unit.j2] use wanted-by in timer unit (sonic-net#2561) f45dcfb [generate_dump] Optimize the execution time of 'show techsupport' CLI by paraller function execution (sonic-net#2565) 67cbb15 [202205]Fixes 12170: Delete subinterface and recreate the subinterface in default-vrf (sonic-net#2564) 93172c4 [202205] [generate_dump] Optimize the execution time of the 'show techsupport' script to 5-10% by reducing calls to the 'tar append' operation (sonic-net#2562) Signed-off-by: dprital <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: bingwang [email protected]
Description of PR
Summary:
Fixes # (issue)
Errors were reported during pytest collecting test cases because ImportError for IxNetworkApi, which is available only on ixia devices.
This commit attempts to catch import exception and skips cases when exception is caught.
Type of change
Approach
What is the motivation for this PR?
This PR is to address pytest collection error caused by import exception.
How did you do it?
Add a logic to catch import exception, and skip cases if exception is caught.
How did you verify/test it?
Verified on Arista-7260 by running pytest collecting command.
We can see that 3 cases were skipped and no error was observed.
Any platform specific information?
No.
Supported testbed topology if it's a new test case?
No.
Documentation
No.