Add script for testing BGP allow list#2572
Merged
wangxin merged 1 commit intosonic-net:masterfrom Nov 25, 2020
wangxin:bgp_allow_list
Merged
Add script for testing BGP allow list#2572wangxin merged 1 commit intosonic-net:masterfrom wangxin:bgp_allow_list
wangxin merged 1 commit intosonic-net:masterfrom
wangxin:bgp_allow_list
Conversation
This change is to cover the BGP allow list test. Signed-off-by: Xin Wang <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Update sonic-utilities submodule pointer to include the following: 3bc2bc6 [Mellanox][202205] Change severity to NOTICE in Mellanox buffer migrator when unable to fetch DEVICE_METADATA due to empty CONFIG_DB during initialization (sonic-net#2570) e1c8243 [202205][generate_dump] Fix for a deletion flow for all secret files in the techsupport dump (sonic-net#2572) 9f2984a [202205] Fix issue: unconfigured PGs are displayed in watermarkstat (sonic-net#2568) f7988b0 [202205] [timer.unit.j2] use wanted-by in timer unit (sonic-net#2561) f45dcfb [generate_dump] Optimize the execution time of 'show techsupport' CLI by paraller function execution (sonic-net#2565) 67cbb15 [202205]Fixes 12170: Delete subinterface and recreate the subinterface in default-vrf (sonic-net#2564) 93172c4 [202205] [generate_dump] Optimize the execution time of the 'show techsupport' script to 5-10% by reducing calls to the 'tar append' operation (sonic-net#2562) Signed-off-by: dprital <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Add script for testing BGP allow list.
This change is dependent on the changes to tests/common/devices.py in PR #2538:
Type of change
Approach
What is the motivation for this PR?
The BGP allow list feature was introduced in SONiC. This PR is to add a script for testing the BGP allow list feature.
How did you do it?
Add a new script for testing BGP allow list. Covered scenarios:
Ensure that
constants.bgp.allow_list.default_actionis"permit". No BGP allow list is configured./etc/sonic/constants.ymlshould be added to all routes. The original community of routes should be kept.Ensure that
constants.bgp.allow_list.default_actionis"permit". BGP allow list is configured.Ensure that
constants.bgp.allow_list.default_actionis"deny". No BGP allow list is configured.Ensure that
constants.bgp.allow_list.default_actionis"deny". BGP allow list is configured.Relevant change: sonic-net/sonic-buildimage#5309
How did you verify/test it?
Run the test script using latest master image.
Currently some test cases can't pass because of issue: sonic-net/sonic-buildimage#6001
If add
on-match nextto/usr/share/sonic/templates/bgpd/templates/general/policies.conf.j2and restart bgp service, then all the cases can pass:Any platform specific information?
No
Supported testbed topology if it's a new test case?
This test only supports topology type t1.
Documentation