[action] [PR:13171] Fix ASIC check on Non-SONiC leaf fanout#13176
Merged
mssonicbld merged 1 commit intosonic-net:202311from Jun 7, 2024
Merged
[action] [PR:13171] Fix ASIC check on Non-SONiC leaf fanout#13176mssonicbld merged 1 commit intosonic-net:202311from
mssonicbld merged 1 commit intosonic-net:202311from
Conversation
8 tasks
Collaborator
Author
|
Original PR: #13171 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
This PR is to fix an issue brought by PR #12931.
The issue is because if the leaf fanout is not running SONiC, then the host has no attribute
facts.This PR addressed the issue by checking OS first and the ASIC check is bypassed if OS is not SONiC.
Type of change
Back port request
Approach
What is the motivation for this PR?
This PR is to fix an issue caused by PR #12931.
How did you do it?
This PR addressed the issue by checking OS first and the ASIC check is bypassed if OS is not SONiC.
How did you verify/test it?
The change is verified on a physical testbed without leaf fanout running SONiC.
Any platform specific information?
Mellanox platform specific.
Supported testbed topology if it's a new test case?
Not a new test case.
Documentation