[reporting] Add option to skip over malformed tr.xml files#2561
Merged
daall merged 1 commit intosonic-net:masterfrom Nov 20, 2020
Merged
[reporting] Add option to skip over malformed tr.xml files#2561daall merged 1 commit intosonic-net:masterfrom
daall merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Danny Allen <daall@microsoft.com>
neethajohn
approved these changes
Nov 20, 2020
bingwang-ms
approved these changes
Nov 20, 2020
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Update sonic-utilities submodule pointer to include the following: 3bc2bc6 [Mellanox][202205] Change severity to NOTICE in Mellanox buffer migrator when unable to fetch DEVICE_METADATA due to empty CONFIG_DB during initialization (sonic-net#2570) e1c8243 [202205][generate_dump] Fix for a deletion flow for all secret files in the techsupport dump (sonic-net#2572) 9f2984a [202205] Fix issue: unconfigured PGs are displayed in watermarkstat (sonic-net#2568) f7988b0 [202205] [timer.unit.j2] use wanted-by in timer unit (sonic-net#2561) f45dcfb [generate_dump] Optimize the execution time of 'show techsupport' CLI by paraller function execution (sonic-net#2565) 67cbb15 [202205]Fixes 12170: Delete subinterface and recreate the subinterface in default-vrf (sonic-net#2564) 93172c4 [202205] [generate_dump] Optimize the execution time of the 'show techsupport' script to 5-10% by reducing calls to the 'tar append' operation (sonic-net#2562) Signed-off-by: dprital <drorp@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Danny Allen daall@microsoft.com
Description of PR
Summary: Add option to skip over malformed tr.xml files
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
We notice that occasionally test bugs can cause pytest to produce JUnit XML files that are missing information, which causes the validation checks to fail. We generally don't care about these missing test results, since they are either new tests or otherwise represent a total test failure that doesn't provide useful data.
How did you do it?
I added an option to skip over malformed files when parsing a directory. This way we don't reduce the effectiveness of the parser checks and let bad data in, but we don't let one malformed file block the entire test report from being generated.
How did you verify/test it?
Ran against existing data and ran against a set of test results where one of the tr.xml files was missing the
linefield from all the test cases.Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation