Skip to content

[Mellanox] [QoS] Support shared headroom pool #2565

Merged
liat-grozovik merged 3 commits intosonic-net:masterfrom
stephenxs:shared-headroom-pool
Jan 7, 2021
Merged

[Mellanox] [QoS] Support shared headroom pool #2565
liat-grozovik merged 3 commits intosonic-net:masterfrom
stephenxs:shared-headroom-pool

Conversation

@stephenxs
Copy link
Contributor

@stephenxs stephenxs commented Nov 20, 2020

Description of PR

Summary:
Support to verify shared headroom pool on Mellanox platform

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

To support verify shared headroom pool on Mellanox platform

How did you do it?

  • generic update
    • introduce a new fixture for calculating shared headroom pool size
    • in the sai_qos_test, determine whether SHP is supported on Mellanox platform by testing whether there is related parameters in the dict in stead of hard coded
  • Mellanox specific:
    • generate SHP parameters based on the configuration
    • this is the first test case in which there are multiple ingress ports. In this case, the numbers of packets sent to each lossless PGs differ and need to be calculated based on dynamic th, current available shared buffer pool size. Implement this logic.

How did you verify/test it?

Run the test on Mellanox platform.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@lgtm-com
Copy link

lgtm-com bot commented Nov 20, 2020

This pull request introduces 1 alert when merging 549fab036f159653c4ccad4ad5c2c64d91e55efd into 7fb76f3 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Dec 15, 2020

This pull request introduces 1 alert when merging fe04e70 into 5b4031e - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@stephenxs stephenxs marked this pull request as ready for review December 15, 2020 08:51
@liat-grozovik liat-grozovik changed the title [QoS] Support shared headroom pool on Mellanox platform [Mellanox] [QoS] Support shared headroom pool Dec 31, 2020
@neethajohn
Copy link
Contributor

Please fix the lgtm alert as well

Signed-off-by: Stephen Sun <[email protected]>
Signed-off-by: Stephen Sun <[email protected]>
@neethajohn
Copy link
Contributor

retest this please

@liat-grozovik liat-grozovik merged commit 10557ec into sonic-net:master Jan 7, 2021
@stephenxs stephenxs deleted the shared-headroom-pool branch January 7, 2021 13:09
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
Update sonic-utilities submodule pointer to include the following:

3bc2bc6 [Mellanox][202205] Change severity to NOTICE in Mellanox buffer migrator when unable to fetch DEVICE_METADATA due to empty CONFIG_DB during initialization (sonic-net#2570)
e1c8243 [202205][generate_dump] Fix for a deletion flow for all secret files in the techsupport dump (sonic-net#2572)
9f2984a [202205] Fix issue: unconfigured PGs are displayed in watermarkstat (sonic-net#2568)
f7988b0 [202205] [timer.unit.j2] use wanted-by in timer unit (sonic-net#2561)
f45dcfb [generate_dump] Optimize the execution time of 'show techsupport' CLI by paraller function execution (sonic-net#2565)
67cbb15 [202205]Fixes 12170: Delete subinterface and recreate the subinterface in default-vrf (sonic-net#2564)
93172c4 [202205] [generate_dump] Optimize the execution time of the 'show techsupport' script to 5-10% by reducing calls to the 'tar append' operation (sonic-net#2562)

Signed-off-by: dprital <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants