Skip to content

[Ansible] Start ptf_tgen in ptf container#1898

Merged
lolyu merged 1 commit intosonic-net:masterfrom
lolyu:start_ptf_tgen
Jul 16, 2020
Merged

[Ansible] Start ptf_tgen in ptf container#1898
lolyu merged 1 commit intosonic-net:masterfrom
lolyu:start_ptf_tgen

Conversation

@lolyu
Copy link
Collaborator

@lolyu lolyu commented Jul 14, 2020 •
edited
Loading

Description of PR

Add following steps to add_topo:

  1. Copy requried scripts to /ptf_tgen of PTF container.
  2. Start the ptf_tgen supervisor process inside PTF container.

NOTICE: skip if

  • topo is not fullmesh
  • ptf_tgen supervisor process is present.

Signed-off-by: Longxiang Lyu lolv@microsoft.com

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

To get PTF ready for spytest after adding topology.

How did you do it?

How did you verify/test it?

# ./testbed-cli.sh -t testbed.csv  add-topo spytest /data/password.txt

after, inside PTF container, ptf_tgen is in running state.

root@383faa151543:/# supervisorctl 
ptf_nn_agent                     RUNNING   pid 15, uptime 18:02:26
ptf_tgen                         RUNNING   pid 348, uptime 18:01:19
sshd                             RUNNING   pid 14, uptime 18:02:26

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@lolyu
Copy link
Collaborator Author

lolyu commented Jul 14, 2020

This patch depends on #1897

@yxieca
Copy link
Collaborator

yxieca commented Jul 15, 2020

retest vsimage please

@lolyu
Copy link
Collaborator Author

lolyu commented Jul 15, 2020

@yxieca, updated to add check so that only when topo is fullmesh to start ptf_tgen. And tested over vtestbed, thanks.

@wangxin
Copy link
Collaborator

wangxin commented Jul 15, 2020

retest vsimage please

@lolyu
Copy link
Collaborator Author

lolyu commented Jul 16, 2020

@wangxin, tested over vtestbed, add topo add test_bgp_facts passed.

@lolyu
[Ansible] Start ptf_tgen in ptf container
5ac1b77 
Add following steps to `add_topo`:
1. Copy requried scripts to /ptf_tgen of `PTF` container.
2. Start the ptf_tgen supervisor process inside `PTF` container.

**NOTICE**: skip if
* `topo` is not `fullmesh`
* `ptf_tgen` supervisor process is present.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
@lolyu lolyu merged commit bb1ee06 into sonic-net:master Jul 16, 2020
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@dprital
[202012] [submodule] Update sonic-utilities submodule (sonic-net#9661)
1eec2bc 
Update submodule sonic-utilities that contains the following commits:

Revert "[202012] [generate_dump] allow to extend dump with plugin scripts (sonic-net#1945)" (sonic-net#1993)
[soft-reboot] Add support for platforms based on Device Tree (sonic-net#1963)
[Reclaiming buffer][202012] Database migrator for reclaiming buffer (sonic-net#1898)
[202012] [generate_dump] allow to extend dump with plugin scripts (sonic-net#1945)

Signed-off-by: dprital <drorp@nvidia.com>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@yxieca
[201811][utilities][swss][snmpagent] advance sub module head
e302561 
snmpagent
* 187aa10 2021-09-16 | [201811][RFC1213]: Initialize lag oid map in reinit_data (sonic-net#233) (github/201811) [SuvarnaMeenakshi]

swss:
* 3503705 2021-09-05 | [201811][Cherry-pick] [acl mirror action] Mirror session ref count fix at acl rule attachment (sonic-net#1898) (HEAD -> 201811, github/201811) [bingwang-ms]

utilities:
* f3f8667 2021-10-15 | [201811] disk_check.py: Allow remote user access when disk is read-only (sonic-net#1873) (HEAD -> 201811, github/201811) [Renuka Manavalan]
* 6b351c9 2021-10-14 | [201811]  Remove exec from platform_reboot_plugin call to handle any hang issue. (sonic-net#1880) [Sujin Kang]
* d8d0461 2021-07-29 | [minigraph][port_config] Consume port_config.json while reloading minigraph (sonic-net#1726) [Blueve]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@kellyyeh @yxieca
[201811] Add DHCPv6 minigraph parsing support (sonic-net#8970)
139a58b 
* Add DHCPv6 minigraph parsing support

Co-authored-by: shlomibitton <60430976+shlomibitton@users.noreply.github.com>

Logrotate for wtmp and btmp files to fix size getting too large. (sonic-net#8744)

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>

[201811][utilities][swss][snmpagent] advance sub module head

snmpagent
* 187aa10 2021-09-16 | [201811][RFC1213]: Initialize lag oid map in reinit_data (sonic-net#233) (github/201811) [SuvarnaMeenakshi]

swss:
* 3503705 2021-09-05 | [201811][Cherry-pick] [acl mirror action] Mirror session ref count fix at acl rule attachment (sonic-net#1898) (HEAD -> 201811, github/201811) [bingwang-ms]

utilities:
* f3f8667 2021-10-15 | [201811] disk_check.py: Allow remote user access when disk is read-only (sonic-net#1873) (HEAD -> 201811, github/201811) [Renuka Manavalan]
* 6b351c9 2021-10-14 | [201811]  Remove exec from platform_reboot_plugin call to handle any hang issue. (sonic-net#1880) [Sujin Kang]
* d8d0461 2021-07-29 | [minigraph][port_config] Consume port_config.json while reloading minigraph (sonic-net#1726) [Blueve]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

[201811] Invoke disk check periodically (sonic-net#8951)

* Invoke disk check periodically. (sonic-net#7374)

Why I did it
Helps with periodic scan of disk for RO state.
If found, this script makes transient fix and raise error message.

Save DB dump after warm/fast reboot (sonic-net#8913)

Back porting the master branch change - sonic-net#8803

Save the redis DB dump after warm reboot.

[201811][swss] advance swss submodule head (sonic-net#9049)

* e0b115a 2021-10-22 | [copp] add dhcpv6 copp rules (sonic-net#1979) (HEAD -> 201811, github/201811) [Ying Xie]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

[swssconfig] load dhcpv6 copp rules by default (sonic-net#9047)

Why I did it
Need to enable DHCPv6 copp rule

How I did it
Add a separate DHCPv6 copp rule config file and load it during cold reboot.

How to verify it
cold reboot, and verify config being loaded and dhcpv6 rules got installed.

Signed-off-by: Ying Xie ying.xie@microsoft.com

[warmboot finalizer] load dhcpv6 copp rules when missing (sonic-net#9048)

Why I did it
Need to enable DHCPv6 COPP rules.

How I did it
Load the separate DHCPv6 COPP rules after warm reboot if the rules are missing.

How to verify it
Warm reboot from an image doesn't have DHCPv6 COPP rules installed.
Warm reboot from an image have DHCPv6 COPP rules already installed.
In either case, the script did the right thing and only install the COPP rules if it is missing.

Signed-off-by: Ying Xie ying.xie@microsoft.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yxieca yxieca yxieca approved these changes

Assignees

No one assigned

Labels

Spytest Testbed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lolyu @yxieca @wangxin