[action] [PR:9621] Revert PR #9256 "Remove pg lossless settings of port speed in module iface_namingmode/test_iface_namingmode.py".#9661
Merged
mssonicbld merged 1 commit intosonic-net:202305from Aug 28, 2023
Conversation
…n module iface_namingmode/test_iface_namingmode.py". (sonic-net#9621) What is the motivation for this PR? In PR sonic-net#9256, we use function delete_running_config to delete pg lossless profile in running config, which will cause orchagent coredump. Actually, from SAI side, they don't support such usage. So in module iface_namingmode/test_iface_namingmode.py, after case test_config_interface_speed running, we use our fixture core_dump_and_config_check to do config reload to recover config, thus revert this PR.
6 tasks
Collaborator
Author
|
Original PR: #9621 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
In PR #9256, we use function
delete_running_configto delete pg lossless profile in running config, which will cause orchagent coredump. Actually, from SAI side, they don't support such usage. So in moduleiface_namingmode/test_iface_namingmode.py, after casetest_config_interface_speedrunning, we use our fixturecore_dump_and_config_checkto do config reload to recover config, thus revert this PR.Summary:
Fixes #9256
Type of change
Back port request
Approach
What is the motivation for this PR?
In PR #9256, we use function
delete_running_configto delete pg lossless profile in running config, which will cause orchagent coredump. Actually, from SAI side, they don't support such usage. So in moduleiface_namingmode/test_iface_namingmode.py, after casetest_config_interface_speedrunning, we use our fixturecore_dump_and_config_checkto do config reload to recover config, thus revert this PR.How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation