Revert creds access method for advance_reboot and wr_arp testcase#1945
Closed
vaibhavhd wants to merge 1 commit intosonic-net:masterfrom
Closed
Revert creds access method for advance_reboot and wr_arp testcase#1945vaibhavhd wants to merge 1 commit intosonic-net:masterfrom
vaibhavhd wants to merge 1 commit intosonic-net:masterfrom
Conversation
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Update submodule sonic-utilities that contains the following commits: Revert "[202012] [generate_dump] allow to extend dump with plugin scripts (sonic-net#1945)" (sonic-net#1993) [soft-reboot] Add support for platforms based on Device Tree (sonic-net#1963) [Reclaiming buffer][202012] Database migrator for reclaiming buffer (sonic-net#1898) [202012] [generate_dump] allow to extend dump with plugin scripts (sonic-net#1945) Signed-off-by: dprital <drorp@nvidia.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
[202106 6e895ad] Revert "[buffer orch] Bugfix: Don't query counter SAI_BUFFER_POOL_STAT_XOFF_ROOM_WATERMARK_BYTES on a pool where it is not supported (sonic-net#1857)" (sonic-net#1945)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Regression post #1885
Fix advanced_reboot script error during starting remote command on ptf.
Fixes # (issue)
Advanced_reboot fails to start a remote command on the ptf host.
Type of change
Approach
What is the motivation for this PR?
The
credsfixture incorrectly fetchessonicadmin_userandsonicadmin_passwordas:"{{ secret_group_vars['"'"'str'"'"']['"'"'sonicadmin_user'"'"'] }}""{{ secret_group_vars['"'"'str'"'"']['"'"'sonicadmin_password'"'"'] }}"The reason for this error is
credsfixture pulls the information from theymlfiles and above dicts are not rendered.How did you do it?
Reverted the change added by #1885
More work to be soon added for ptf_runner warning and error handling.
How did you verify/test it?
Tested warm_reboot testcase and the IO thread on the PTF starts successfully.