[action] [PR:8823] Get peer fanout from the first interface on the dut connected to the …#8951
Merged
mssonicbld merged 1 commit intosonic-net:202205from Jul 13, 2023
Merged
Conversation
5 tasks
Collaborator
Author
|
Original PR: #8823 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Get peer fanout from the first interface on the dut which is connected to the fanout instead of Ethernet0
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
In is_mellanox_fanout definition interface Ethernet0 is hard coded as the interface that is connected to the fanout.
This is fine for a T2 max topology since all interfaces are connected to a fanout.
For a T2 min topology if Ethernet0 is not used (not connected to a fanout), it will produce an error:
fanout_host = dut_facts["device_conn"][duthost.hostname]["Ethernet0"]["peerdevice"]
E KeyError: 'Ethernet0'
Therefore, we should get the peer fanout from the first interface that is connected to a fanout.
How did you do it?
We get the peer fanout using the first interface that is connected to the fanout.
How did you verify/test it?
It was tested on multi ASICs T2 chassis with min topology and made sure the connected interface is not Ethernet0.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation