Skip to content

[system-health] Add regression test cases for system health feature#1873

Merged
yxieca merged 3 commits intosonic-net:masterfrom
shlomibitton:system-health
Jul 13, 2020
Merged

[system-health] Add regression test cases for system health feature#1873
yxieca merged 3 commits intosonic-net:masterfrom
shlomibitton:system-health

Conversation

@shlomibitton
Copy link
Contributor

@shlomibitton shlomibitton commented Jul 9, 2020

Description of PR

Summary:
Add test cases for system health feature. Theses test cases check system status and compare it with the data generated by system health service.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

Add 4 test cases for system health feature to cover its basic functions and make sure new changes does not break it.

How did you do it?

Add 4 cases:

  1. Check system services and verify the actual service status with system health data in redis
  2. Mock hardware status and verify the actual hardware status with system health data in redis
  3. Add external checker and verify system health service can load it and get data from it
  4. Change system health configuration file and verify the service changes its behaviour according to the new configuration

How did you verify/test it?

Manually run the new test cases for SN4600C, SN3800 and SN2700

Any platform specific information?

N/A

Supported testbed topology if it's a new test case?

N/A

Documentation

@lgtm-com
Copy link

lgtm-com bot commented Jul 9, 2020

This pull request introduces 2 alerts when merging c9df879 into 53222ad - view on LGTM.com

new alerts:

  • 2 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Jul 12, 2020

This pull request introduces 2 alerts when merging c9df879 into c42201c - view on LGTM.com

new alerts:

  • 2 for Unused import

Signed-off-by: Shlomi Bitton <shlomibi@mellanox.com>
@lgtm-com
Copy link

lgtm-com bot commented Jul 12, 2020

This pull request introduces 2 alerts when merging f6da766 into c42201c - view on LGTM.com

new alerts:

  • 2 for Unused import

@shlomibitton
Copy link
Contributor Author

retest this please

@shlomibitton shlomibitton requested a review from wangxin July 12, 2020 21:27
@yxieca yxieca merged commit 82fc719 into sonic-net:master Jul 13, 2020
@shlomibitton shlomibitton deleted the system-health branch March 25, 2021 08:11
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
snmpagent
* 187aa10 2021-09-16 | [201811][RFC1213]: Initialize lag oid map in reinit_data (sonic-net#233) (github/201811) [SuvarnaMeenakshi]

swss:
* 3503705 2021-09-05 | [201811][Cherry-pick] [acl mirror action] Mirror session ref count fix at acl rule attachment (sonic-net#1898) (HEAD -> 201811, github/201811) [bingwang-ms]

utilities:
* f3f8667 2021-10-15 | [201811] disk_check.py: Allow remote user access when disk is read-only (sonic-net#1873) (HEAD -> 201811, github/201811) [Renuka Manavalan]
* 6b351c9 2021-10-14 | [201811]  Remove exec from platform_reboot_plugin call to handle any hang issue. (sonic-net#1880) [Sujin Kang]
* d8d0461 2021-07-29 | [minigraph][port_config] Consume port_config.json while reloading minigraph (sonic-net#1726) [Blueve]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
* Add DHCPv6 minigraph parsing support

Co-authored-by: shlomibitton <60430976+shlomibitton@users.noreply.github.com>

Logrotate for wtmp and btmp files to fix size getting too large. (sonic-net#8744)

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>

[201811][utilities][swss][snmpagent] advance sub module head

snmpagent
* 187aa10 2021-09-16 | [201811][RFC1213]: Initialize lag oid map in reinit_data (sonic-net#233) (github/201811) [SuvarnaMeenakshi]

swss:
* 3503705 2021-09-05 | [201811][Cherry-pick] [acl mirror action] Mirror session ref count fix at acl rule attachment (sonic-net#1898) (HEAD -> 201811, github/201811) [bingwang-ms]

utilities:
* f3f8667 2021-10-15 | [201811] disk_check.py: Allow remote user access when disk is read-only (sonic-net#1873) (HEAD -> 201811, github/201811) [Renuka Manavalan]
* 6b351c9 2021-10-14 | [201811]  Remove exec from platform_reboot_plugin call to handle any hang issue. (sonic-net#1880) [Sujin Kang]
* d8d0461 2021-07-29 | [minigraph][port_config] Consume port_config.json while reloading minigraph (sonic-net#1726) [Blueve]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

[201811] Invoke disk check periodically (sonic-net#8951)

* Invoke disk check periodically. (sonic-net#7374)

Why I did it
Helps with periodic scan of disk for RO state.
If found, this script makes transient fix and raise error message.

Save DB dump after warm/fast reboot (sonic-net#8913)

Back porting the master branch change - sonic-net#8803

Save the redis DB dump after warm reboot.

[201811][swss] advance swss submodule head (sonic-net#9049)

* e0b115a 2021-10-22 | [copp] add dhcpv6 copp rules (sonic-net#1979) (HEAD -> 201811, github/201811) [Ying Xie]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

[swssconfig] load dhcpv6 copp rules by default (sonic-net#9047)

Why I did it
Need to enable DHCPv6 copp rule

How I did it
Add a separate DHCPv6 copp rule config file and load it during cold reboot.

How to verify it
cold reboot, and verify config being loaded and dhcpv6 rules got installed.

Signed-off-by: Ying Xie ying.xie@microsoft.com

[warmboot finalizer] load dhcpv6 copp rules when missing (sonic-net#9048)

Why I did it
Need to enable DHCPv6 COPP rules.

How I did it
Load the separate DHCPv6 COPP rules after warm reboot if the rules are missing.

How to verify it
Warm reboot from an image doesn't have DHCPv6 COPP rules installed.
Warm reboot from an image have DHCPv6 COPP rules already installed.
In either case, the script did the right thing and only install the COPP rules if it is missing.

Signed-off-by: Ying Xie ying.xie@microsoft.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants