test_radv_ipv6_ra is unnecessarily skipped on non-dualtor topology#9048
test_radv_ipv6_ra is unnecessarily skipped on non-dualtor topology#9048wangxin merged 3 commits intosonic-net:masterfrom
Conversation
There was a problem hiding this comment.
test_radv_ipv6.py uses fixture toggle_all_simulator_ports_to_upper_tor to do the mux toggle, which depends on cable_type. Actually, toggle_all_simulator_ports_to_upper_tor is designed for dualtor-io testcases. For normal t0 testcases, the practice is using fixture toggle_all_simulator_ports_to_random_side and choosing the random ToR as the testing device.
Suggest use toggle_all_simulator_ports_to_random_side instead.
Some test scripts need to support both dualtor and other topologies. These scripts may need to call a dualtor specific fixture `cable_type`. Fixture `cable_type` enforced that the topology must has "dualtor", otherwise skip the test. For scripts depend on the `cable_type` fixture, they are unnecessarily skipped on non-dualtor topologies. This change updated the check in the `cable_type` fixture. When "dualtor" is not in topology name, simply return None instead of force skip the test script. Signed-off-by: Xin Wang <[email protected]>
b230cae to
de58f3d
Compare
|
The pre-commit check detected issues in the files touched by this pull request. Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
|
@wangxin PR conflicts with 202205 branch |
…onic-net#9048) What is the motivation for this PR? Script test_radv_ipv6_ra.py is unnecessarily skipped on non-dualtor topology. The reason is that this script uses fixture toggle_all_simulator_ports_to_upper_tor which depends on cable_type fixture. The cable_type fixture requires that the topology must has "dualtor", otherwise skip the test. How did you do it? This change updated the test_radv_ipv6_ra.py to use fixture toggle_all_simulator_ports_to_random_side. Signed-off-by: Xin Wang <[email protected]>
|
Cherry-pick PR to 202305: #9299 |
…pology Cherry-pick sonic-net#9048 What is the motivation for this PR? Script test_radv_ipv6_ra.py is unnecessarily skipped on non-dualtor topology. The reason is that this script uses fixture toggle_all_simulator_ports_to_upper_tor which depends on cable_type fixture. The cable_type fixture requires that the topology must has "dualtor", otherwise skip the test. How did you do it? This change updated the test_radv_ipv6_ra.py to use fixture toggle_all_simulator_ports_to_random_side. Signed-off-by: Xin Wang <[email protected]>
…9048) What is the motivation for this PR? Script test_radv_ipv6_ra.py is unnecessarily skipped on non-dualtor topology. The reason is that this script uses fixture toggle_all_simulator_ports_to_upper_tor which depends on cable_type fixture. The cable_type fixture requires that the topology must has "dualtor", otherwise skip the test. How did you do it? This change updated the test_radv_ipv6_ra.py to use fixture toggle_all_simulator_ports_to_random_side. Signed-off-by: Xin Wang <[email protected]>
…pology (#9300) Cherry-pick #9048 What is the motivation for this PR? Script test_radv_ipv6_ra.py is unnecessarily skipped on non-dualtor topology. The reason is that this script uses fixture toggle_all_simulator_ports_to_upper_tor which depends on cable_type fixture. The cable_type fixture requires that the topology must has "dualtor", otherwise skip the test. How did you do it? This change updated the test_radv_ipv6_ra.py to use fixture toggle_all_simulator_ports_to_random_side. Signed-off-by: Xin Wang <[email protected]>
…onic-net#9048) What is the motivation for this PR? Script test_radv_ipv6_ra.py is unnecessarily skipped on non-dualtor topology. The reason is that this script uses fixture toggle_all_simulator_ports_to_upper_tor which depends on cable_type fixture. The cable_type fixture requires that the topology must has "dualtor", otherwise skip the test. How did you do it? This change updated the test_radv_ipv6_ra.py to use fixture toggle_all_simulator_ports_to_random_side. Signed-off-by: Xin Wang <[email protected]>
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Script
test_radv_ipv6_ra.pyis unnecessarily skipped on non-dualtor topology. The reason is that this script uses fixturetoggle_all_simulator_ports_to_upper_torwhich depends oncable_typefixture.The
cable_typefixture requires that the topology must has "dualtor", otherwise skip the test.How did you do it?
This change updated the
test_radv_ipv6_ra.pyto use fixturetoggle_all_simulator_ports_to_random_side.How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation