[Ixia/Keysight] Adding first RDMA test cases by abhijit-dhar · Pull Request #1979 · sonic-net/sonic-mgmt

abhijit-dhar · 2020-07-28T04:12:47Z

Description of PR

Summary:
Fixes # (issue)

Type of change

Bug fix
Testbed and Framework(new/improvement)
Test case(new/improvement)

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

This directory should contain the Ixia ECN and RDMA test cases. The lib folder contains * fixtures required to run ixia test cases * helper function required to write ixia test cases

As per review comments given against the 1819 we have to keep the ixia libraries under sonic-mgmt/tests/common/ixia/

This file should be in tests/common/ixia folder. So deleting it from tests/ixia/lib/ folder

This file should be under the folder tests/common/ixia Hence deleting it form tests/ixia/lib

This file should be under tests/common/ixia So deleting it from tests/ixia/lib

There were many review comment against this file. Some of the comments I have implemented. But some of the comments may be implemented in future. Like "(Wei Bai) Can you move all the low level IXIA API functions to ixia_helpers.py?" or "I have a high level comment. can we design some IXIA wrapper functions (e.g., configure ports, create a PFC traffic item) and only call these high level wrapper functions in py.test scripts without exposing too many IXIA low level details? (Wei Bai)" This comment may be addressed in future PRs once we come up with the high level wrapper APIs.

Added a new fixture ixia_api_server_session

This class is added to efficiently manage ixia fanout devices

Making ixia directory a package, to access ixia_fixtures.py and ixia_helpers.py

This class is a place holder right now. Ixia fanout devices (chassis) do not require this abstraction layer. Ixia PTF (ixia API server) takes care of all the operation that we can do on the ixia fanout devices (chassis) and hence we execute them via API server only. But it is still nice to have all abstractions in the same location. So future users knows where to find them.

Added a new class that should make chassis port management easier

There was an typo

Deletes accidentally

…xia_helpers.py

upcading my master with the remote master

merging master with Rdma1

lgtm-com · 2020-07-28T04:22:59Z

This pull request introduces 1 alert when merging e23970c into f785cd0 - view on LGTM.com

new alerts:

1 for Variable defined multiple times

baiwei0427 · 2020-08-05T03:40:46Z

tests/ixia/test_pfc_pause_lossless.py

+        "The topology should have at least two interfaces")
+
+    # Test pausing each lossless priority individually.
+    session = ixia_api_server_session


Can you also test pausing all the lossless priorities simultaneously?

Implemented

baiwei0427 · 2020-08-05T03:45:11Z

tests/ixia/test_pfc_pause_lossless.py

+
+        if 'Test' in flow_stat['Traffic Item']:
+            if paused:          
+                pytest_assert(tx_frames > 0 and rx_frames == 0, 


We can also check if tx_frames * frame_size is smaller than switch buffer size (optional)

This seem to be complected. Since it is optional I want to address it as a future enhancement. Please consider it.

May be with ECN test this is relevant

baiwei0427 · 2020-08-05T03:51:53Z

tests/ixia/test_pfc_pause_lossless.py

+    device_conn = conn_graph_facts['device_conn']
+    for intf in fanout_devices.get_ports():
+        peer_port = intf['peer_port'] 
+        intf['speed'] = int(device_conn[peer_port]['speed']) * 100 


why multiply by 100 here?

Not required - removed it.

baiwei0427 · 2020-08-05T04:00:10Z

tests/ixia/test_pfc_pause_lossless.py

+    start_traffic(session)
+
+    # Wait for test and background traffic to finish.
+    time.sleep(exp_dur + 1.5)


Here, the extra 1.5 seconds is because of the start delay is 1 second (line 94 and 105). We should declare a variable called 'start_delay' and avoid hardcode.

Implemented.

neethajohn · 2020-08-04T22:54:19Z

tests/common/ixia/ixia_helpers.py

+    traffic_config.FrameSize.FixedSize = pkt_size
+
+    if pkt_count is not None and duration is not None:
+        logger.info('You can only specify either pkt_count or duration')


logger.error

Replaced: logger.info --> logger.error

neethajohn · 2020-08-04T22:54:45Z

tests/common/ixia/ixia_helpers.py

+                                                  FrameCount=pkt_count)
+    elif duration is not None:
+        if type(duration) != int or duration <= 0:
+            logger.info('Invalid duration value {} (positive integer only)'.


logger.error

Replaced: logger.info --> logger.error

neethajohn · 2020-08-04T22:59:55Z

tests/common/ixia/ixia_helpers.py

+    if pause_prio_list is not None:
+        for prio in pause_prio_list:
+            if prio < 0 or prio > 7:
+                logger.info('Invalid pause priorities {}'.


logger.error

Replaced: logger.info --> logger.error

neethajohn · 2020-08-04T23:01:45Z

tests/common/ixia/ixia_helpers.py

+    traffic_config.FrameSize.FixedSize = 64
+
+    if pkt_count is not None and duration is not None:
+        logger.info('You can only specify either pkt_count or duration')


logger.error

Replaced: logger.info --> logger.error

neethajohn · 2020-08-04T23:41:34Z

tests/common/ixia/ixia_helpers.py

+
+    elif duration is not None:
+        if type(duration) != int or duration <= 0:
+            logger.info('Invalid duration value {} (positive integer only)'.


logger.error

Replaced: logger.info --> logger.error

neethajohn · 2020-08-05T00:01:03Z

tests/common/ixia/ixia_helpers.py

+    for i in range(8):
+        pause_duration = pfc_stack_obj.\
+            find(DisplayName='PFC Queue {}'.format(i))
+


remove new line

Removed the new line.

neethajohn · 2020-08-05T00:01:12Z

tests/common/ixia/ixia_helpers.py

+            find(DisplayName='PFC Queue {}'.format(i))
+
+        pause_duration.ValueType = 'singleValue'
+


remove new line

Removed the new line

neethajohn · 2020-08-05T00:01:29Z

tests/common/ixia/ixia_helpers.py

+    for i in range(8):
+        pause_duration = pfc_stack_obj.\
+            find(DisplayName='PFC Queue {}'.format(i))
+


remove new line

Removed the new line.

neethajohn · 2020-08-05T00:05:04Z

tests/common/ixia/qos_fixtures.py

+
+    # Read the port QOS map. If pfc_enable flag is false then return None.
+    port_qos_map = config_facts["PORT_QOS_MAP"]
+    lossless_priorities = list()


Removed the statement "lossless_priorities = list()"

tests/ixia/test_pfc_pause_lossless.py

baiwei0427 · 2020-08-12T04:48:53Z

tests/ixia/test_pfc_pause_lossless.py

+START_DELAY = 1.5 
+
+def run_pfc_exp(session, dut, tx_port, rx_port, port_bw, test_prio_list,
+		test_dscp_list, bg_dscp_list, exp_dur, start_delay=START_DELAY,


Arguments should be aligned.

This change is implemented.

baiwei0427 · 2020-08-12T04:53:19Z

tests/common/ixia/ixia_helpers.py

+        pkt_per_sec (int): Packets per second.
+        pkt_count (int): Packet count.
+        duration (int): Traffic duration in second (positive integer only!).
+        start_delay (int): Start delay in second.


float or int?

This is float. Change is implemented.

baiwei0427 · 2020-08-12T04:53:56Z

tests/common/ixia/ixia_helpers.py

+    if start_delay > 0:
+        traffic_config.TransmissionControl.update(
+            StartDelayUnits='nanoseconds',
+            StartDelay=start_delay*(10**6))


I think start_delay can be a float. But we need to ensure that start_delay * 1000000 is an int,

I am not changing this for the following reasons:

It look quite awkward the people will give a value like start_delay 3.4623187 so the start_delay * 1000000 becomes an floating-point number (3462318.7).

Even if start delay is some number like this 1.5, the start_delay * 1000000 becomes 1500000.0 the function which handles 1500000.0 should be able to handle 3462318.7

The function handles "traffic_config.TransmissionControl.update" handles floating point numbers gracefully.

baiwei0427 · 2020-08-12T04:57:48Z

tests/ixia/test_pfc_pause_lossless.py

+    2. IXIA sends PFC pause frames from rx_port to pause priorities.
+    3. Background traffic should not be interruped - all background traffic
+       will be received at the rx_port.
+    4. No PFC traffic will be received at the rx_port when pause priority


PFC pause frames should always be dropped, regardless of their pause priorities.

Comment added.

baiwei0427 · 2020-08-12T04:58:30Z

tests/ixia/test_pfc_pause_lossless.py

+        start_delay (float): approximated initial delay to start the traffic.
+        test_traffic_pause_expected (bool): Do you expect test traffic to
+            be stopped? If yes, this should be true; false otherwise.
+        send_pause_frame (bool): True/False depending on whether you wand to


wand -> want

Change is implemented: wand -> want

baiwei0427 · 2020-08-12T05:24:09Z

tests/ixia/test_pfc_pause_lossless.py

+          has the TC value m.
+       b. Background data traffic can assume priority m if 'Test Data Traffic'
+          has the TC value n.
+       c. Neither m or n when 'Test Data Traffic' has both the priorities.   


Remove a,b,c above

This change is implemented.

baiwei0427 · 2020-08-12T05:24:59Z

tests/ixia/test_pfc_pause_lossless.py

+          has the TC value n.
+       c. Neither m or n when 'Test Data Traffic' has both the priorities.   
+    6. Start 'Test Data Traffic' and 'Background Data Traffic'.
+    7. From Rx port send pause frames on priorities either m or n. Such that


send pause frames on priority Pn

This comment is implemented.

baiwei0427 · 2020-08-12T05:25:40Z

tests/ixia/test_pfc_pause_lossless.py

+       b. Background data traffic can assume priority m if 'Test Data Traffic'
+          has the TC value n.
+       c. Neither m or n when 'Test Data Traffic' has both the priorities.   
+    6. Start 'Test Data Traffic' and 'Background Data Traffic'.


Test and background traffic should be started after PFC pause storm

This comment is implemented.

baiwei0427 · 2020-08-12T05:26:18Z

tests/ixia/test_pfc_pause_lossless.py

+    6. Start 'Test Data Traffic' and 'Background Data Traffic'.
+    7. From Rx port send pause frames on priorities either m or n. Such that
+       priority of 'Test Data Traffic' at Tx end == Pause Priority at Rx end.
+    8. You may repeat the steps 6 and 7 several times.


Repeat the steps 6 and 7 to test each lossless priority.

This comment is implemented

baiwei0427 · 2020-08-12T05:27:09Z

tests/ixia/test_pfc_pause_lossless.py

+                        test_traffic_pause_expected=True)
+
+            clean_configuration(session=session)
+


Can we split this into two functions?

This comment is implemented. I have splatted the main function into two function as below:
test_pfc_pause_single_lossless_priority
test_pfc_pause_multi_lossless_priorities

baiwei0427 · 2020-08-17T03:02:30Z

retest this please

baiwei0427 · 2020-08-15T08:09:24Z

tests/common/ixia/ixia_helpers.py

+
+    # Construct global pause and PFC packets.
+    if global_pause:
+        set_global_pause_fields(pfc_stack_obj)


The function should be set_global_pause_fields

tests/ixia/test_pfc_pause_lossless.py

baiwei0427 · 2020-08-15T08:25:43Z

tests/ixia/test_pfc_pause_lossless.py

+                "PFC packets should be dropped")
+        else:
+            pytest_assert(tx_frames > 0 and tx_frames == rx_frames,
+                "Background traffic should not be impacted")


Why this check is required - can you please explain. Not implementing this change now.

To ensure that background traffic is not affected, we need to check if background traffic keeps sending packets at the target rate (e.g., rate_percent = 50). tx_frames > 0 can only indicate that background traffic delivers some packets.

baiwei0427 · 2020-08-15T08:34:20Z

tests/ixia/test_pfc_pause_lossless.py

+    4. The flow 'Test Data Traffic' can assume one of the lossless priority 
+       values Pi.
+    5. The flow 'Background Data Traffic' can assume all the priority values
+       which is not in 'Test Data Traffic'. For example if the priority of


which are not in

Implemented.

baiwei0427 · 2020-08-15T08:35:43Z

tests/ixia/test_pfc_pause_lossless.py

+    7. Start 'Test Data Traffic' and 'Background Data Traffic'.
+    8. You may repeat step 6 and 7 for each lossless priorities.
+    9. Expected result -
+       a. No 'Test Data Traffic' will not flow. Since priority of


No 'Test Data Traffic' will flow

implemented

baiwei0427 · 2020-08-15T08:42:46Z

tests/ixia/test_pfc_pause_lossless.py

+                                             fanout_graph_facts):
+    """
+    RDMA PFC - Pauses on multiple lossless priorities.
+    1. On SONiC DUT enable PFC any two priorities Pm, Pn. (0 <= n<= 7) also


The step 1 seems incorrect to me as this test should be able to cover any number of priorities.

This statement appears correct to me. Since this is describing actual test step. Where we are configuring two priorities.

The code has nothing to do with two priorities. It can handle any number of priorities.

implemented

baiwei0427 · 2020-08-18T06:55:28Z

tests/rdma/test_pfc_pause_lossless.py

+        test_dscp_list = []
+        test_priority_list = [prio for prio in lossless_prio_dscp_map]
+        for prio in lossless_prio_dscp_map:
+            for p in lossless_prio_dscp_map[prio]:


You can use test_dscp_list += lossless_prio_dscp_map[prio] to directly merge the DSCP value list

implemented

baiwei0427 · 2020-08-19T03:53:34Z

tests/rdma/test_pfc_pause_lossless.py

+                                             fanout_graph_facts):
+    """
+    RDMA PFC - Pauses on multiple lossless priorities.
+    1. On SONiC DUT enable PFC any two priorities Pm, Pn. (0 <= n<= 7) also


This test function should be able to cover more than two priorities. Can you modify the description correspondingly?

This statement appears correct to me. Since this is describing actual test step. Where we are configuring two priorities.

baiwei0427 · 2020-08-19T07:10:10Z

tests/rdma/test_pfc_pause_lossless.py

+                    "Test traffic should be fully paused")
+            else:
+                pytest_assert(tx_frames > 0 and tx_frames == rx_frames,
+                    "Test traffic should not be impacted")


Can you also check if tx_frames * PKT_SIZE is close to rate_percent (50/100) * duration * link capacity?

An equivalent check is implemented.

baiwei0427 · 2020-08-19T07:11:45Z

tests/rdma/test_pfc_pause_lossless.py

+            pytest_assert(tx_frames > 0 and rx_frames == 0,
+                "PFC packets should be dropped")
+        else:
+            pytest_assert(tx_frames > 0 and tx_frames == rx_frames,


Can you also check if tx_frames * PKT_SIZE is close to rate_percent (50/100) * duration * link capacity?

An equivalent check is implemented.

baiwei0427 · 2020-08-20T06:54:04Z

tests/rdma/test_pfc_pause_lossless.py

+    7. When pause frames are started 'Test Data Traffic' will stop; 
+       and when pause frames are stopped 'Test Data Traffic' will start.
+    8. 'Background Data Traffic' will always flow.
+    9. Repeat the steps 4 to 8 several times.


Why we need repeat here?

baiwei0427 · 2020-08-20T06:55:58Z

tests/rdma/test_pfc_pause_lossless.py

+    3. On the Ixia Tx port create two flows - a) 'Test Data Traffic' and
+       b) 'Background Data traffic'.
+    4. Configure 'Test Data Traffic' such that it contains traffic items
+       of two lossless priorities Pm and Pn.


two lossless priorities -> all the lossless priorities.

baiwei0427 · 2020-08-20T06:56:20Z

tests/rdma/test_pfc_pause_lossless.py

+       b) 'Background Data traffic'.
+    4. Configure 'Test Data Traffic' such that it contains traffic items
+       of two lossless priorities Pm and Pn.
+    5. Configure 'Background Data Traffic' it contains all other traffic


it contains all the lossy priorities. For example, if lossless priorities are 3 and 4, then the ...

baiwei0427 · 2020-08-20T06:56:41Z

tests/rdma/test_pfc_pause_lossless.py

+       except priorities Pm and Pn. For example if Pm = 3 and Pn = 4 then
+       the priorities of the 'Background Data Traffic' should be 0, 1, 2,
+       5, 6 and 7.
+    6. From Rx port send pause frames on priorities both Pm and Pn. Then


send pause frames on all the lossless priorities.

baiwei0427 · 2020-08-24T06:42:44Z

tests/pfc/test_pfc_pause_lossless.py

+    session = ixia_api_server_session
+    send_pause_frame = False
+    for i in range(len(port_list)):
+        vports = configure_ports(session, port_list)


Add another loop 'for send_pause_frame in [True, False]':

baiwei0427 · 2020-08-24T06:44:53Z

tests/pfc/test_pfc_pause_lossless.py

+    7. When pause frames are started 'Test Data Traffic' will stop; 
+       and when pause frames are stopped 'Test Data Traffic' will start.
+    8. 'Background Data Traffic' will always flow.
+    9. Repeat the steps 4 to 8 several times.


several times -> all the ports

baiwei0427 · 2020-08-24T06:45:30Z

tests/pfc/test_pfc_pause_lossless.py

+    # Test pausing each lossless priority individually.
+    session = ixia_api_server_session
+    for prio in lossless_prio_dscp_map:
+        send_pause_frame = False


Add another loop: for send_pause_frame in [True, False]:

baiwei0427 · 2020-08-24T06:45:58Z

tests/pfc/test_pfc_pause_lossless.py

+       'Test Data Traffic' at Tx end == Pause Priority at Rx end. That is,
+       send pause frames on priority Pi.
+    7. Start 'Test Data Traffic' and 'Background Data Traffic'.
+    8. You may repeat step 6 and 7 for each lossless priorities.


Remove 'You may'

baiwei0427 · 2020-08-24T06:48:00Z

tests/pfc/test_pfc_pause_lossless.py

+                    "Test traffic should be fully paused")
+            else:
+                pytest_assert(tx_frames > 0 and tx_frames == rx_frames,
+                    "Test traffic should not be impacted")


'Test traffic packets should not be dropped'

baiwei0427 · 2020-08-24T06:49:48Z

tests/pfc/test_pfc_pause_lossless.py

+DATA_PKT_SIZE = 1024
+START_DELAY = 1.5
+RATE_PERCENTAGE = 50 
+TOLERANCE_PARAMETER = .97


TOLERANCE_PARAMETER -> TOLERANCE_THRESHOLD

…lse]:

baiwei0427 · 2020-08-25T09:41:07Z

tests/pfc/test_pfc_pause_lossless.py

+                                             destination=topo_receiver,
+                                             pkt_size=DATA_PKT_SIZE,
+                                             duration=exp_dur,
+                                             rate_percent=RATE_PERCENTAGE,


RATE_PERCENTAGE -> 100 - RATE_PERCENTAGE

Implemented.
# Assumption: Line rate percentage of background data traffic
# is equal to Line rate percentage of test data traffic.
pytest_assert(2 * RATE_PERCENTAGE <= 100,
"Value of RATE_PERCENTAGE should not be more than 50!")

baiwei0427 · 2020-08-25T09:41:46Z

tests/pfc/test_pfc_pause_lossless.py

+    flow_statistics = get_traffic_statistics(session)
+    logger.info(flow_statistics)
+
+    exp_tx_byte = (exp_dur * port_bw * 1000000 * (RATE_PERCENTAGE / 100.0)) / 8


Test data traffic and background traffic may have different expected TX bytes.

And please change 'exp_tx_byte' to 'exp_tx_bytes'

implemented.
# Assumption: Line rate percentage of background data traffic
# is equal to Line rate percentage of test data traffic.
pytest_assert(2 * RATE_PERCENTAGE <= 100,
"Value of RATE_PERCENTAGE should not be more than 50!")

baiwei0427 · 2020-08-25T09:51:14Z

tests/pfc/test_pfc_pause_lossless.py

+    flow_statistics = get_traffic_statistics(session)
+    logger.info(flow_statistics)
+
+    exp_tx_byte = (exp_dur * port_bw * 1000000 * (RATE_PERCENTAGE / 100.0)) / 8


And please change 'exp_tx_byte' to 'exp_tx_bytes'

baiwei0427 · 2020-08-25T09:55:02Z

tests/pfc/test_pfc_pause_lossless.py

+                                  gw_start=gw_addr,
+                                  gw_incr_step='0.0.0.0')
+    start_protocols(session)
+


pytest_assert(RATE_PERCENTAGE <= 50,"xxxx")

Implemented

neethajohn · 2020-08-26T03:24:50Z

tests/pfc/test_pfc_pause_lossless.py

                    (tolerance_ratio > 1)) :
                    logger.error("Expected Tx/Rx = %s actual Rx = %s"
-                        %(exp_tx_byte, exp_tx_byte))
+                        %(exp_tx_bytes, exp_tx_bytes))


the second one should be 'rx_bytes'

Made the changed exp_tx_bytes -> rx_bytes

* e0b115a 2021-10-22 | [copp] add dhcpv6 copp rules (sonic-net#1979) (HEAD -> 201811, github/201811) [Ying Xie] Signed-off-by: Ying Xie <ying.xie@microsoft.com>

* Add DHCPv6 minigraph parsing support Co-authored-by: shlomibitton <60430976+shlomibitton@users.noreply.github.com> Logrotate for wtmp and btmp files to fix size getting too large. (sonic-net#8744) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com> [201811][utilities][swss][snmpagent] advance sub module head snmpagent * 187aa10 2021-09-16 | [201811][RFC1213]: Initialize lag oid map in reinit_data (sonic-net#233) (github/201811) [SuvarnaMeenakshi] swss: * 3503705 2021-09-05 | [201811][Cherry-pick] [acl mirror action] Mirror session ref count fix at acl rule attachment (sonic-net#1898) (HEAD -> 201811, github/201811) [bingwang-ms] utilities: * f3f8667 2021-10-15 | [201811] disk_check.py: Allow remote user access when disk is read-only (sonic-net#1873) (HEAD -> 201811, github/201811) [Renuka Manavalan] * 6b351c9 2021-10-14 | [201811] Remove exec from platform_reboot_plugin call to handle any hang issue. (sonic-net#1880) [Sujin Kang] * d8d0461 2021-07-29 | [minigraph][port_config] Consume port_config.json while reloading minigraph (sonic-net#1726) [Blueve] Signed-off-by: Ying Xie <ying.xie@microsoft.com> [201811] Invoke disk check periodically (sonic-net#8951) * Invoke disk check periodically. (sonic-net#7374) Why I did it Helps with periodic scan of disk for RO state. If found, this script makes transient fix and raise error message. Save DB dump after warm/fast reboot (sonic-net#8913) Back porting the master branch change - sonic-net#8803 Save the redis DB dump after warm reboot. [201811][swss] advance swss submodule head (sonic-net#9049) * e0b115a 2021-10-22 | [copp] add dhcpv6 copp rules (sonic-net#1979) (HEAD -> 201811, github/201811) [Ying Xie] Signed-off-by: Ying Xie <ying.xie@microsoft.com> [swssconfig] load dhcpv6 copp rules by default (sonic-net#9047) Why I did it Need to enable DHCPv6 copp rule How I did it Add a separate DHCPv6 copp rule config file and load it during cold reboot. How to verify it cold reboot, and verify config being loaded and dhcpv6 rules got installed. Signed-off-by: Ying Xie ying.xie@microsoft.com [warmboot finalizer] load dhcpv6 copp rules when missing (sonic-net#9048) Why I did it Need to enable DHCPv6 COPP rules. How I did it Load the separate DHCPv6 COPP rules after warm reboot if the rules are missing. How to verify it Warm reboot from an image doesn't have DHCPv6 COPP rules installed. Warm reboot from an image have DHCPv6 COPP rules already installed. In either case, the script did the right thing and only install the COPP rules if it is missing. Signed-off-by: Ying Xie ying.xie@microsoft.com

abhijit-dhar and others added 30 commits June 25, 2020 21:38

[ixia/Keysight] sample test cases and fixtures

06cd811

This directory should contain the Ixia ECN and RDMA test cases. The lib folder contains * fixtures required to run ixia test cases * helper function required to write ixia test cases

[ixia/Keysight] adding ixia libraries

b6a0963

As per review comments given against the 1819 we have to keep the ixia libraries under sonic-mgmt/tests/common/ixia/

[ixia/Keysight] This file should be in common/ixia

2a8ad2b

This file should be in tests/common/ixia folder. So deleting it from tests/ixia/lib/ folder

[ixia/Keysight] lib/ixia_fixtures.py

694ae89

This file should be under the folder tests/common/ixia Hence deleting it form tests/ixia/lib

[ixia/Keysight] deleting ixia_helpers.py

b5316e8

This file should be under tests/common/ixia So deleting it from tests/ixia/lib

Update test_ixia_traffic_restpy.py

61ff293

[ixia/Keysight] Changed as per review comments

721b6b1

Added a new fixture ixia_api_server_session

[ixia/Keysight] added new IxiaFanoutManager class

4833513

This class is added to efficiently manage ixia fanout devices

[ixia/Keysight] Adding __init__().py

b0f1bf6

Making ixia directory a package, to access ixia_fixtures.py and ixia_helpers.py

[ixia/Keysight] corrected typo added a new class

cbf0235

Added a new class that should make chassis port management easier

[ixia/Keysight] Deleted from the review

84f3201

There was an typo

[ixia/Keysight] adding ixia_fixtures

f0098d1

Deletes accidentally

[ixia/Keysight] updated ixia_fixtures.py

b91dc5e

modifying and rdma test case according to ixia proposal

b288123

modifying and rdma test case according to ixia proposal

318c287

removing the low level api from test_ixia_traffic_restpy.py

c33e7c8

changed test scripts and lib functions

b789490

added google style comments and changed function names

0678c57

Added the google doc string for the methods in ixia_fixtures.py and i…

a0182c8

…xia_helpers.py

Implementing PR1819 review comments

cfe3cbc

Removing test_ixia_traffic_restpy.py adding test_ixia_traffic.py

ed09027

Changing some comment string

b54f209

Added stop_protocols function in ixia_helpers.py

c4c5310

Removed a sleep and added a debugging statement

c5ca281

[ixia/Keysight] updating the review comments PR1819

9ab2d65

adding a simple poc

aba759a

Changed ixia/test_ixia_poc.py a bit

23a687f

Implementing the comments of PR1819

bc27595

abhijit-dhar added 4 commits July 27, 2020 17:45

Merge remote-tracking branch 'upstream/master'

debac8c

upcading my master with the remote master

deleting tgen POC

1690344

Merge branch 'master' into rdma1

ffdaa54

merging master with Rdma1

[Ixia/Keysight] Updating first RDMA test cases

e23970c

baiwei0427 requested changes Aug 5, 2020

View reviewed changes

neethajohn requested changes Aug 5, 2020

View reviewed changes

Implemented the review comments of PR#1979

44eddb9

baiwei0427 reviewed Aug 12, 2020

View reviewed changes

abhijit-dhar added 2 commits August 14, 2020 17:33

Implementing the comment given by Wei

4f03ba6

correcting the function name

dabddb2

Updating the first RDMA test cases as per comments

96d0ebf

baiwei0427 requested changes Aug 19, 2020

View reviewed changes

Changing the files as per review comments of PR1979

867394b

abhijit-dhar requested a review from neethajohn August 21, 2020 03:11

baiwei0427 requested changes Aug 24, 2020

View reviewed changes

abhijit-dhar added 2 commits August 24, 2020 10:31

updating as per comments of wei --> for send_pause_frame in [True, Fa…

2b82d01

…lse]:

removed an unwanted variable assignment

8cc251e

baiwei0427 approved these changes Aug 24, 2020

View reviewed changes

baiwei0427 requested changes Aug 25, 2020

View reviewed changes

added a Safety check 2 * RATE PERCENTAGE <= 100

1e5a1cd

baiwei0427 approved these changes Aug 25, 2020

View reviewed changes

changed 'exp_tx_byte' to 'exp_tx_bytes'

a499c89

neethajohn reviewed Aug 26, 2020

View reviewed changes

neethajohn approved these changes Aug 26, 2020

View reviewed changes

changed 'exp_tx_byte' to 'rx_bytes'

08cf89c

neethajohn merged commit 49d716d into sonic-net:master Aug 26, 2020

		find(DisplayName='PFC Queue {}'.format(i))

		pause_duration.ValueType = 'singleValue'

		test_traffic_pause_expected=True)

		clean_configuration(session=session)

Conversation

abhijit-dhar commented Jul 28, 2020

Description of PR

Type of change

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

lgtm-com bot commented Jul 28, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

baiwei0427 Aug 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

baiwei0427 Aug 5, 2020 •

edited

Loading